| Message ID | 20221220190947.2681192-1-f.fainelli@gmail.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 24b333a866a10d4be47b9968b9c05a3e9f326ff5 |
| Headers | show |
| Series | MIPS: dts: bcm63268: Add missing properties to the TWD node | expand |
On 20/12/22 20:09, Florian Fainelli wrote: > We currently have a DTC warning with the current DTS due to the lack of > a suitable #address-cells and #size-cells property: > > DTC arch/mips/boot/dts/brcm/bcm63268-comtrend-vr-3032u.dtb > arch/mips/boot/dts/brcm/bcm63268.dtsi:115.5-22: Warning (reg_format): /ubus/timer-mfd@10000080/timer@0:reg: property has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1) > arch/mips/boot/dts/brcm/bcm63268.dtsi:120.5-22: Warning (reg_format): /ubus/timer-mfd@10000080/watchdog@1c:reg: property has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1) > arch/mips/boot/dts/brcm/bcm63268.dtsi:111.4-35: Warning (ranges_format): /ubus/timer-mfd@10000080:ranges: "ranges" property has invalid length (12 bytes) (parent #address-cells == 1, child #address-cells == 2, #size-cells == 1) > > Fixes: d3db4b96ab7f ("mips: dts: bcm63268: add TWD block timer") > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> > --- > arch/mips/boot/dts/brcm/bcm63268.dtsi | 2 ++ > 1 file changed, 2 insertions(+) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
On Tue, Dec 20, 2022 at 11:09:46AM -0800, Florian Fainelli wrote: > We currently have a DTC warning with the current DTS due to the lack of > a suitable #address-cells and #size-cells property: > > DTC arch/mips/boot/dts/brcm/bcm63268-comtrend-vr-3032u.dtb > arch/mips/boot/dts/brcm/bcm63268.dtsi:115.5-22: Warning (reg_format): /ubus/timer-mfd@10000080/timer@0:reg: property has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1) > arch/mips/boot/dts/brcm/bcm63268.dtsi:120.5-22: Warning (reg_format): /ubus/timer-mfd@10000080/watchdog@1c:reg: property has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1) > arch/mips/boot/dts/brcm/bcm63268.dtsi:111.4-35: Warning (ranges_format): /ubus/timer-mfd@10000080:ranges: "ranges" property has invalid length (12 bytes) (parent #address-cells == 1, child #address-cells == 2, #size-cells == 1) > > Fixes: d3db4b96ab7f ("mips: dts: bcm63268: add TWD block timer") > Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> > --- > arch/mips/boot/dts/brcm/bcm63268.dtsi | 2 ++ > 1 file changed, 2 insertions(+) > > diff --git a/arch/mips/boot/dts/brcm/bcm63268.dtsi b/arch/mips/boot/dts/brcm/bcm63268.dtsi > index c663efce91cf..7b788757cb1e 100644 > --- a/arch/mips/boot/dts/brcm/bcm63268.dtsi > +++ b/arch/mips/boot/dts/brcm/bcm63268.dtsi > @@ -109,6 +109,8 @@ timer-mfd@10000080 { > compatible = "brcm,bcm7038-twd", "simple-mfd", "syscon"; > reg = <0x10000080 0x30>; > ranges = <0x0 0x10000080 0x30>; > + #address-cells = <1>; > + #size-cells = <1>; > > timer@0 { > compatible = "brcm,bcm6345-timer"; > -- > 2.34.1 applied. Thomas.
diff --git a/arch/mips/boot/dts/brcm/bcm63268.dtsi b/arch/mips/boot/dts/brcm/bcm63268.dtsi index c663efce91cf..7b788757cb1e 100644 --- a/arch/mips/boot/dts/brcm/bcm63268.dtsi +++ b/arch/mips/boot/dts/brcm/bcm63268.dtsi @@ -109,6 +109,8 @@ timer-mfd@10000080 { compatible = "brcm,bcm7038-twd", "simple-mfd", "syscon"; reg = <0x10000080 0x30>; ranges = <0x0 0x10000080 0x30>; + #address-cells = <1>; + #size-cells = <1>; timer@0 { compatible = "brcm,bcm6345-timer";
We currently have a DTC warning with the current DTS due to the lack of a suitable #address-cells and #size-cells property: DTC arch/mips/boot/dts/brcm/bcm63268-comtrend-vr-3032u.dtb arch/mips/boot/dts/brcm/bcm63268.dtsi:115.5-22: Warning (reg_format): /ubus/timer-mfd@10000080/timer@0:reg: property has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1) arch/mips/boot/dts/brcm/bcm63268.dtsi:120.5-22: Warning (reg_format): /ubus/timer-mfd@10000080/watchdog@1c:reg: property has invalid length (8 bytes) (#address-cells == 2, #size-cells == 1) arch/mips/boot/dts/brcm/bcm63268.dtsi:111.4-35: Warning (ranges_format): /ubus/timer-mfd@10000080:ranges: "ranges" property has invalid length (12 bytes) (parent #address-cells == 1, child #address-cells == 2, #size-cells == 1) Fixes: d3db4b96ab7f ("mips: dts: bcm63268: add TWD block timer") Signed-off-by: Florian Fainelli <f.fainelli@gmail.com> --- arch/mips/boot/dts/brcm/bcm63268.dtsi | 2 ++ 1 file changed, 2 insertions(+)