| Message ID | 20230129120442.22858-2-paul@crapouillou.net (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 4737a703528c769c4fde6b68462f656f91f4ad99 |
| Headers | show |
| Series | rtc: jz4740: Various updates | expand |
On Sun, 29 Jan 2023 12:04:39 +0000, Paul Cercueil wrote: > The RTC in the JZ4770 is compatible with the JZ4760, but has an extra > register that permits to configure the behaviour of the CLK32K pin. The > same goes for the RTC in the JZ4780. > > With this change, the RTC node is now also a clock provider on these > SoCs, so a #clock-cells property is added. > > Signed-off-by: Paul Cercueil <paul@crapouillou.net> > > --- > v2: - add constraint on which SoCs can have the #clock-cells property > - add JZ4780 example which has a #clock-cells > v3: Don't break ABI anymore. > --- > .../devicetree/bindings/rtc/ingenic,rtc.yaml | 29 +++++++++++++++++++ > 1 file changed, 29 insertions(+) > Reviewed-by: Rob Herring <robh@kernel.org>
diff --git a/Documentation/devicetree/bindings/rtc/ingenic,rtc.yaml b/Documentation/devicetree/bindings/rtc/ingenic,rtc.yaml index af78b67b3da4..de9879bdb317 100644 --- a/Documentation/devicetree/bindings/rtc/ingenic,rtc.yaml +++ b/Documentation/devicetree/bindings/rtc/ingenic,rtc.yaml @@ -11,6 +11,17 @@ maintainers: allOf: - $ref: rtc.yaml# + - if: + not: + properties: + compatible: + contains: + enum: + - ingenic,jz4770-rtc + - ingenic,jz4780-rtc + then: + properties: + "#clock-cells": false properties: compatible: @@ -39,6 +50,9 @@ properties: clock-names: const: rtc + "#clock-cells": + const: 0 + system-power-controller: description: | Indicates that the RTC is responsible for powering OFF @@ -83,3 +97,18 @@ examples: clocks = <&cgu JZ4740_CLK_RTC>; clock-names = "rtc"; }; + + - | + #include <dt-bindings/clock/ingenic,jz4780-cgu.h> + rtc: rtc@10003000 { + compatible = "ingenic,jz4780-rtc", "ingenic,jz4760-rtc"; + reg = <0x10003000 0x4c>; + + interrupt-parent = <&intc>; + interrupts = <32>; + + clocks = <&cgu JZ4780_CLK_RTCLK>; + clock-names = "rtc"; + + #clock-cells = <0>; + };
The RTC in the JZ4770 is compatible with the JZ4760, but has an extra register that permits to configure the behaviour of the CLK32K pin. The same goes for the RTC in the JZ4780. With this change, the RTC node is now also a clock provider on these SoCs, so a #clock-cells property is added. Signed-off-by: Paul Cercueil <paul@crapouillou.net> --- v2: - add constraint on which SoCs can have the #clock-cells property - add JZ4780 example which has a #clock-cells v3: Don't break ABI anymore. --- .../devicetree/bindings/rtc/ingenic,rtc.yaml | 29 +++++++++++++++++++ 1 file changed, 29 insertions(+)