| Message ID | 20230220111801.2037164-1-keguang.zhang@gmail.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | [v2] dt-bindings: interrupt-controller: convert loongson,ls1x-intc.txt to json-schema | expand |
On 20/02/2023 12:18, Keguang Zhang wrote: > Convert the Loongson1 interrupt controller dt-bindings to json-schema. > > Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com> > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Unreviewed. > --- > V1 -> V2: Drop the description part > --- > .../loongson,ls1x-intc.txt | 24 ---------- > .../loongson,ls1x-intc.yaml | 47 +++++++++++++++++++ > 2 files changed, 47 insertions(+), 24 deletions(-) > delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.txt > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.yaml > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.txt > deleted file mode 100644 > index a63ed9fcb535..000000000000 > --- a/Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.txt > +++ /dev/null > @@ -1,24 +0,0 @@ > -Loongson ls1x Interrupt Controller > - > -Required properties: > - > -- compatible : should be "loongson,ls1x-intc". Valid strings are: > - > -- reg : Specifies base physical address and size of the registers. > -- interrupt-controller : Identifies the node as an interrupt controller > -- #interrupt-cells : Specifies the number of cells needed to encode an > - interrupt source. The value shall be 2. > -- interrupts : Specifies the CPU interrupt the controller is connected to. > - > -Example: > - > -intc: interrupt-controller@1fd01040 { > - compatible = "loongson,ls1x-intc"; > - reg = <0x1fd01040 0x18>; > - > - interrupt-controller; > - #interrupt-cells = <2>; > - > - interrupt-parent = <&cpu_intc>; > - interrupts = <2>; > -}; > diff --git a/Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.yaml > new file mode 100644 > index 000000000000..48dd071ceeea > --- /dev/null > +++ b/Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.yaml > @@ -0,0 +1,47 @@ > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > +%YAML 1.2 > +--- > +$id: http://devicetree.org/schemas/interrupt-controller/loongson,ls1x-intc.yaml# > +$schema: http://devicetree.org/meta-schemas/core.yaml# > + > +title: Loongson-1 Interrupt Controller > + What happened to description? Why did you remove it? Best regards, Krzysztof
On Mon, Feb 20, 2023 at 8:16 PM Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> wrote: > > On 20/02/2023 12:18, Keguang Zhang wrote: > > Convert the Loongson1 interrupt controller dt-bindings to json-schema. > > > > Signed-off-by: Keguang Zhang <keguang.zhang@gmail.com> > > Reviewed-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > Unreviewed. > > > --- > > V1 -> V2: Drop the description part > > --- > > .../loongson,ls1x-intc.txt | 24 ---------- > > .../loongson,ls1x-intc.yaml | 47 +++++++++++++++++++ > > 2 files changed, 47 insertions(+), 24 deletions(-) > > delete mode 100644 Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.txt > > create mode 100644 Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.yaml > > > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.txt > > deleted file mode 100644 > > index a63ed9fcb535..000000000000 > > --- a/Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.txt > > +++ /dev/null > > @@ -1,24 +0,0 @@ > > -Loongson ls1x Interrupt Controller > > - > > -Required properties: > > - > > -- compatible : should be "loongson,ls1x-intc". Valid strings are: > > - > > -- reg : Specifies base physical address and size of the registers. > > -- interrupt-controller : Identifies the node as an interrupt controller > > -- #interrupt-cells : Specifies the number of cells needed to encode an > > - interrupt source. The value shall be 2. > > -- interrupts : Specifies the CPU interrupt the controller is connected to. > > - > > -Example: > > - > > -intc: interrupt-controller@1fd01040 { > > - compatible = "loongson,ls1x-intc"; > > - reg = <0x1fd01040 0x18>; > > - > > - interrupt-controller; > > - #interrupt-cells = <2>; > > - > > - interrupt-parent = <&cpu_intc>; > > - interrupts = <2>; > > -}; > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.yaml > > new file mode 100644 > > index 000000000000..48dd071ceeea > > --- /dev/null > > +++ b/Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.yaml > > @@ -0,0 +1,47 @@ > > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) > > +%YAML 1.2 > > +--- > > +$id: http://devicetree.org/schemas/interrupt-controller/loongson,ls1x-intc.yaml# > > +$schema: http://devicetree.org/meta-schemas/core.yaml# > > + > > +title: Loongson-1 Interrupt Controller > > + > > What happened to description? Why did you remove it? > Sorry for misunderstanding your comments. I will send patch V3 to add back the description. > Best regards, > Krzysztof >
diff --git a/Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.txt b/Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.txt deleted file mode 100644 index a63ed9fcb535..000000000000 --- a/Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.txt +++ /dev/null @@ -1,24 +0,0 @@ -Loongson ls1x Interrupt Controller - -Required properties: - -- compatible : should be "loongson,ls1x-intc". Valid strings are: - -- reg : Specifies base physical address and size of the registers. -- interrupt-controller : Identifies the node as an interrupt controller -- #interrupt-cells : Specifies the number of cells needed to encode an - interrupt source. The value shall be 2. -- interrupts : Specifies the CPU interrupt the controller is connected to. - -Example: - -intc: interrupt-controller@1fd01040 { - compatible = "loongson,ls1x-intc"; - reg = <0x1fd01040 0x18>; - - interrupt-controller; - #interrupt-cells = <2>; - - interrupt-parent = <&cpu_intc>; - interrupts = <2>; -}; diff --git a/Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.yaml b/Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.yaml new file mode 100644 index 000000000000..48dd071ceeea --- /dev/null +++ b/Documentation/devicetree/bindings/interrupt-controller/loongson,ls1x-intc.yaml @@ -0,0 +1,47 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/interrupt-controller/loongson,ls1x-intc.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Loongson-1 Interrupt Controller + +maintainers: + - Keguang Zhang <keguang.zhang@gmail.com> + +properties: + compatible: + const: loongson,ls1x-intc + + reg: + maxItems: 1 + + interrupt-controller: true + + '#interrupt-cells': + const: 2 + + interrupts: + maxItems: 1 + +required: + - compatible + - reg + - interrupt-controller + - '#interrupt-cells' + - interrupts + +additionalProperties: false + +examples: + - | + intc0: interrupt-controller@1fd01040 { + compatible = "loongson,ls1x-intc"; + reg = <0x1fd01040 0x18>; + + interrupt-controller; + #interrupt-cells = <2>; + + interrupt-parent = <&cpu_intc>; + interrupts = <2>; + };