diff mbox series

[3/8] MIPS: loongson2ef: Add missing break in cs5536_isa

Message ID 20230409104309.13887-4-jiaxun.yang@flygoat.com (mailing list archive)
State Superseded
Headers show
Series MIPS: LLVM build fixes | expand

Commit Message

Jiaxun Yang April 9, 2023, 10:43 a.m. UTC 
Fixes build error:

arch/mips/loongson2ef/common/cs5536/cs5536_isa.c:217:2: error:
unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]
        default:
        ^
arch/mips/loongson2ef/common/cs5536/cs5536_isa.c:217:2:
note: insert 'break;' to avoid fall-through
        default:
        ^
        break;

Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
---
 arch/mips/loongson2ef/common/cs5536/cs5536_isa.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

Comments

Thomas Bogendoerfer April 12, 2023, 1:31 p.m. UTC | #1 
On Sun, Apr 09, 2023 at 11:43:04AM +0100, Jiaxun Yang wrote:
> Fixes build error:
> 
> arch/mips/loongson2ef/common/cs5536/cs5536_isa.c:217:2: error:
> unannotated fall-through between switch labels [-Werror,-Wimplicit-fallthrough]
>         default:
>         ^
> arch/mips/loongson2ef/common/cs5536/cs5536_isa.c:217:2:
> note: insert 'break;' to avoid fall-through
>         default:
>         ^
>         break;
> 
> Signed-off-by: Jiaxun Yang <jiaxun.yang@flygoat.com>
> ---
>  arch/mips/loongson2ef/common/cs5536/cs5536_isa.c | 2 +-
>  1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/arch/mips/loongson2ef/common/cs5536/cs5536_isa.c b/arch/mips/loongson2ef/common/cs5536/cs5536_isa.c
> index 5ad38f86ee62..d60dd9992377 100644
> --- a/arch/mips/loongson2ef/common/cs5536/cs5536_isa.c
> +++ b/arch/mips/loongson2ef/common/cs5536/cs5536_isa.c
> @@ -213,7 +213,7 @@ void pci_isa_write_reg(int reg, u32 value)
>  			lo |= 0x00000063;
>  			_wrmsr(SB_MSR_REG(SB_ERROR), hi, lo);
>  		}
> -
> +		break;
>  	default:
>  		/* ALL OTHER PCI CONFIG SPACE HEADER IS NOT IMPLEMENTED. */
>  		break;
> -- 
> 2.39.2 (Apple Git-143)

applied to mips-next.

Thomas.
diff mbox series

Patch

diff --git a/arch/mips/loongson2ef/common/cs5536/cs5536_isa.c b/arch/mips/loongson2ef/common/cs5536/cs5536_isa.c
index 5ad38f86ee62..d60dd9992377 100644
--- a/arch/mips/loongson2ef/common/cs5536/cs5536_isa.c
+++ b/arch/mips/loongson2ef/common/cs5536/cs5536_isa.c
@@ -213,7 +213,7 @@  void pci_isa_write_reg(int reg, u32 value)
 			lo |= 0x00000063;
 			_wrmsr(SB_MSR_REG(SB_ERROR), hi, lo);
 		}
-
+		break;
 	default:
 		/* ALL OTHER PCI CONFIG SPACE HEADER IS NOT IMPLEMENTED. */
 		break;