| Message ID | 20230702133113.3438049-1-trix@redhat.com (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | clocksource/drivers/loongson1: set variable ls1x_timer_lock storage-class-specifier to static | expand |
> smatch reports > drivers/clocksource/timer-loongson1-pwm.c:31:1: warning: symbol > 'ls1x_timer_lock' was not declared. Should it be static? > > This variable is only used in its defining file, so it should be static. > > Signed-off-by: Tom Rix <trix@redhat.com> Acked-by: Keguang Zhang <keguang.zhang@gmail.com> > --- > drivers/clocksource/timer-loongson1-pwm.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/drivers/clocksource/timer-loongson1-pwm.c b/drivers/clocksource/timer-loongson1-pwm.c > index 6335fee03017..244d66835508 100644 > --- a/drivers/clocksource/timer-loongson1-pwm.c > +++ b/drivers/clocksource/timer-loongson1-pwm.c > @@ -28,7 +28,7 @@ > > #define CNTR_WIDTH 24 > > -DEFINE_RAW_SPINLOCK(ls1x_timer_lock); > +static DEFINE_RAW_SPINLOCK(ls1x_timer_lock); > > struct ls1x_clocksource { > void __iomem *reg_base; > -- > 2.27.0 > -- Best regards, Keguang Zhang
diff --git a/drivers/clocksource/timer-loongson1-pwm.c b/drivers/clocksource/timer-loongson1-pwm.c index 6335fee03017..244d66835508 100644 --- a/drivers/clocksource/timer-loongson1-pwm.c +++ b/drivers/clocksource/timer-loongson1-pwm.c @@ -28,7 +28,7 @@ #define CNTR_WIDTH 24 -DEFINE_RAW_SPINLOCK(ls1x_timer_lock); +static DEFINE_RAW_SPINLOCK(ls1x_timer_lock); struct ls1x_clocksource { void __iomem *reg_base;
smatch reports drivers/clocksource/timer-loongson1-pwm.c:31:1: warning: symbol 'ls1x_timer_lock' was not declared. Should it be static? This variable is only used in its defining file, so it should be static. Signed-off-by: Tom Rix <trix@redhat.com> --- drivers/clocksource/timer-loongson1-pwm.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)