| Message ID | 20231024054412.2291220-1-arnd@kernel.org (mailing list archive) |
|---|---|
| State | Accepted |
| Headers | show |
| Series | vgacon: fix mips/sibyte build regression | expand |
Arnd Bergmann <arnd@kernel.org> writes: Hello Arnd, > From: Arnd Bergmann <arnd@arndb.de> > > The conversion to vgacon_register_screen() was missing an #include statement > for the swarm board: > > arch/mips/sibyte/swarm/setup.c:146:9: error: implicit declaration of function 'vgacon_register_screen' [-Werror=implicit-function-declaration] > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202310240429.UqeQ2Cpr-lkp@intel.com/ > Fixes: 555624c0d10b vgacon: clean up global screen_info instances > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- Loos good to me. Reviewed-by: Javier Martinez Canillas <javierm@redhat.com>
On 24/10/23 07:44, Arnd Bergmann wrote: > From: Arnd Bergmann <arnd@arndb.de> > > The conversion to vgacon_register_screen() was missing an #include statement > for the swarm board: > > arch/mips/sibyte/swarm/setup.c:146:9: error: implicit declaration of function 'vgacon_register_screen' [-Werror=implicit-function-declaration] > > Reported-by: kernel test robot <lkp@intel.com> > Closes: https://lore.kernel.org/oe-kbuild-all/202310240429.UqeQ2Cpr-lkp@intel.com/ > Fixes: 555624c0d10b vgacon: clean up global screen_info instances > Signed-off-by: Arnd Bergmann <arnd@arndb.de> > --- > arch/mips/sibyte/swarm/setup.c | 1 + > 1 file changed, 1 insertion(+) Reviewed-by: Philippe Mathieu-Daudé <philmd@linaro.org>
diff --git a/arch/mips/sibyte/swarm/setup.c b/arch/mips/sibyte/swarm/setup.c index 74e7c242b690..38c90b5e8754 100644 --- a/arch/mips/sibyte/swarm/setup.c +++ b/arch/mips/sibyte/swarm/setup.c @@ -13,6 +13,7 @@ #include <linux/memblock.h> #include <linux/init.h> #include <linux/kernel.h> +#include <linux/console.h> #include <linux/screen_info.h> #include <linux/initrd.h>