| Message ID | 20231108-fix-mips-nand-v1-6-5fc5586d04de@linaro.org (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | Fix polarity and bindings for GPIO-based NAND drivers | expand |
Hi Linus, linus.walleij@linaro.org wrote on Wed, 08 Nov 2023 15:33:54 +0100: > The implementation of the GPIO NAND controller is just "gpio" > with the usecase for NAND implied from the folder nand/raw. > > This is not so great when the module gets the name "gpio.ko". > Rename the implementation to nand-gpio.c so the module is > named nand-gpio.ko which is more reasonable. > > We put "nand" first instead of "gpio" because the order is > usually <subsystem>-<driver>.c, cf ls drivers/gpio/ Do you mind if we take the "english" version which would rather be "gpio-nand-controller.c/o"? I _really_ want people to understand we don't emulate the storage but the host part here. Thanks, Miquèl
diff --git a/drivers/mtd/nand/raw/Makefile b/drivers/mtd/nand/raw/Makefile index 25120a4afada..f0e377332812 100644 --- a/drivers/mtd/nand/raw/Makefile +++ b/drivers/mtd/nand/raw/Makefile @@ -18,7 +18,7 @@ obj-$(CONFIG_MTD_NAND_NANDSIM) += nandsim.o obj-$(CONFIG_MTD_NAND_CS553X) += cs553x_nand.o obj-$(CONFIG_MTD_NAND_NDFC) += ndfc.o obj-$(CONFIG_MTD_NAND_ATMEL) += atmel/ -obj-$(CONFIG_MTD_NAND_GPIO) += gpio.o +obj-$(CONFIG_MTD_NAND_GPIO) += nand-gpio.o omap2_nand-objs := omap2.o obj-$(CONFIG_MTD_NAND_OMAP2) += omap2_nand.o obj-$(CONFIG_MTD_NAND_OMAP_BCH_BUILD) += omap_elm.o diff --git a/drivers/mtd/nand/raw/gpio.c b/drivers/mtd/nand/raw/nand-gpio.c similarity index 100% rename from drivers/mtd/nand/raw/gpio.c rename to drivers/mtd/nand/raw/nand-gpio.c
The implementation of the GPIO NAND controller is just "gpio" with the usecase for NAND implied from the folder nand/raw. This is not so great when the module gets the name "gpio.ko". Rename the implementation to nand-gpio.c so the module is named nand-gpio.ko which is more reasonable. We put "nand" first instead of "gpio" because the order is usually <subsystem>-<driver>.c, cf ls drivers/gpio/ Signed-off-by: Linus Walleij <linus.walleij@linaro.org> --- drivers/mtd/nand/raw/Makefile | 2 +- drivers/mtd/nand/raw/{gpio.c => nand-gpio.c} | 0 2 files changed, 1 insertion(+), 1 deletion(-)