| Message ID | 20240131-mbly-clk-v4-11-bcd00510d6a0@bootlin.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add support for Mobileye EyeQ5 system controller | expand |
On 31/01/2024 17:26, Théo Lebrun wrote: > Node names should be generic. OLB, meaning "Other Logic Block", is a > name specific to this platform. Change the node name to the generic and > often-used "system-controller". > > See §2.2.2. "Generic Names Recommendation" in the devicetree > specification. > > Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com> > --- > arch/mips/boot/dts/mobileye/eyeq5.dtsi | 2 +- There is no such file in next-20240201 and your cover letter does not link to any dependency. Something is not right. Best regards, Krzysztof
On 01/02/2024 10:10, Krzysztof Kozlowski wrote: > On 31/01/2024 17:26, Théo Lebrun wrote: >> Node names should be generic. OLB, meaning "Other Logic Block", is a >> name specific to this platform. Change the node name to the generic and >> often-used "system-controller". >> >> See §2.2.2. "Generic Names Recommendation" in the devicetree >> specification. >> >> Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com> >> --- >> arch/mips/boot/dts/mobileye/eyeq5.dtsi | 2 +- > > There is no such file in next-20240201 and your cover letter does not > link to any dependency. Something is not right. Ah, I found it now. Best regards, Krzysztof
diff --git a/arch/mips/boot/dts/mobileye/eyeq5.dtsi b/arch/mips/boot/dts/mobileye/eyeq5.dtsi index fd34c49af510..81497febcdee 100644 --- a/arch/mips/boot/dts/mobileye/eyeq5.dtsi +++ b/arch/mips/boot/dts/mobileye/eyeq5.dtsi @@ -100,7 +100,7 @@ uart2: serial@a00000 { clock-names = "uartclk", "apb_pclk"; }; - olb: olb@e00000 { + olb: system-controller@e00000 { compatible = "mobileye,eyeq5-olb", "syscon", "simple-mfd"; reg = <0 0xe00000 0x0 0x400>; reg-io-width = <4>;
Node names should be generic. OLB, meaning "Other Logic Block", is a name specific to this platform. Change the node name to the generic and often-used "system-controller". See §2.2.2. "Generic Names Recommendation" in the devicetree specification. Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com> --- arch/mips/boot/dts/mobileye/eyeq5.dtsi | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)