| Message ID | 20240131-mbly-clk-v4-4-bcd00510d6a0@bootlin.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | Add support for Mobileye EyeQ5 system controller | expand |
On 31/01/2024 17:26, Théo Lebrun wrote: > Add DT schema bindings for the EyeQ5 clock controller driver. > > Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com> > --- No changelog, tags ignored, I scrolled through first two pages of cover letter and also no changelog. This is a friendly reminder during the review process. It looks like you received a tag and forgot to add it. If you do not know the process, here is a short explanation: Please add Acked-by/Reviewed-by/Tested-by tags when posting new versions, under or above your Signed-off-by tag. Tag is "received", when provided in a message replied to you on the mailing list. Tools like b4 can help here. However, there's no need to repost patches *only* to add the tags. The upstream maintainer will do that for tags received on the version they apply. https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 If a tag was not added on purpose, please state why and what changed. Best regards, Krzysztof
Hello, On Thu Feb 1, 2024 at 9:58 AM CET, Krzysztof Kozlowski wrote: > On 31/01/2024 17:26, Théo Lebrun wrote: > > Add DT schema bindings for the EyeQ5 clock controller driver. > > > > Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com> > > --- > > No changelog, tags ignored, I scrolled through first two pages of cover > letter and also no changelog. In this case we fit into the "If a tag was not added on purpose". Sorry the changelog was not explicit enough. In my mind it fits into the first bullet point of the cover letter changelog: > - Have the three drivers access MMIO directly rather than through the > syscon & regmap. That change means important changes to the dt-bindings to adapt to this new behavior. In particular we now have reg and reg-names properties that got added and made required. I wanted to have your review on that and did not want to tag the patch as already reviewed. > > This is a friendly reminder during the review process. > > It looks like you received a tag and forgot to add it. > > If you do not know the process, here is a short explanation: > Please add Acked-by/Reviewed-by/Tested-by tags when posting new > versions, under or above your Signed-off-by tag. Tag is "received", when > provided in a message replied to you on the mailing list. Tools like b4 > can help here. However, there's no need to repost patches *only* to add > the tags. The upstream maintainer will do that for tags received on the > version they apply. > > https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 > > If a tag was not added on purpose, please state why and what changed. As an aside, what's your preference on location for this information? Cover letter changelog? Following '---' in the specific commit message? Somewhere else? Thanks, -- Théo Lebrun, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
On 01/02/2024 11:38, Théo Lebrun wrote: > Hello, > > On Thu Feb 1, 2024 at 9:58 AM CET, Krzysztof Kozlowski wrote: >> On 31/01/2024 17:26, Théo Lebrun wrote: >>> Add DT schema bindings for the EyeQ5 clock controller driver. >>> >>> Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com> >>> --- >> >> No changelog, tags ignored, I scrolled through first two pages of cover >> letter and also no changelog. > > In this case we fit into the "If a tag was not added on purpose". Sorry > the changelog was not explicit enough. In my mind it fits into the > first bullet point of the cover letter changelog: > >> - Have the three drivers access MMIO directly rather than through the >> syscon & regmap. ... which I might not even connect to binding patches. I see only one entry regarding bindings in your changelog, so I find it not much informative. For the future, please state that you ignore tags for given reason. > > That change means important changes to the dt-bindings to adapt to this > new behavior. In particular we now have reg and reg-names properties > that got added and made required. > > I wanted to have your review on that and did not want to tag the patch > as already reviewed. Makes sense, but how can I know it? Other people often ignore the tags, so safe assumption is that it happened here as well. > >> >> This is a friendly reminder during the review process. >> >> It looks like you received a tag and forgot to add it. >> >> If you do not know the process, here is a short explanation: >> Please add Acked-by/Reviewed-by/Tested-by tags when posting new >> versions, under or above your Signed-off-by tag. Tag is "received", when >> provided in a message replied to you on the mailing list. Tools like b4 >> can help here. However, there's no need to repost patches *only* to add >> the tags. The upstream maintainer will do that for tags received on the >> version they apply. >> >> https://elixir.bootlin.com/linux/v6.5-rc3/source/Documentation/process/submitting-patches.rst#L577 >> >> If a tag was not added on purpose, please state why and what changed. > > As an aside, what's your preference on location for this information? > Cover letter changelog? Following '---' in the specific commit message? > Somewhere else? Both are accepted, but if you do it in cover letter, it should be obvious for the reader that patches XYZ were changed. It's not. Best regards, Krzysztof
Hello, On Thu Feb 1, 2024 at 12:00 PM CET, Krzysztof Kozlowski wrote: > On 01/02/2024 11:38, Théo Lebrun wrote: > > Hello, > > > > On Thu Feb 1, 2024 at 9:58 AM CET, Krzysztof Kozlowski wrote: > >> On 31/01/2024 17:26, Théo Lebrun wrote: > >>> Add DT schema bindings for the EyeQ5 clock controller driver. > >>> > >>> Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com> > >>> --- > >> > >> No changelog, tags ignored, I scrolled through first two pages of cover > >> letter and also no changelog. > > > > In this case we fit into the "If a tag was not added on purpose". Sorry > > the changelog was not explicit enough. In my mind it fits into the > > first bullet point of the cover letter changelog: > > > >> - Have the three drivers access MMIO directly rather than through the > >> syscon & regmap. > > ... which I might not even connect to binding patches. I see only one > entry regarding bindings in your changelog, so I find it not much > informative. > > For the future, please state that you ignore tags for given reason. > > > > > That change means important changes to the dt-bindings to adapt to this > > new behavior. In particular we now have reg and reg-names properties > > that got added and made required. > > > > I wanted to have your review on that and did not want to tag the patch > > as already reviewed. > > Makes sense, but how can I know it? Other people often ignore the tags, > so safe assumption is that it happened here as well. I'm prepping a new revision. Should I be taking your previous Reviewed-By tags in? You sent them for the previous revision, do the changes in this V4 look good to you? Thanks Krzysztof, -- Théo Lebrun, Bootlin Embedded Linux and Kernel engineering https://bootlin.com
diff --git a/Documentation/devicetree/bindings/clock/mobileye,eyeq5-clk.yaml b/Documentation/devicetree/bindings/clock/mobileye,eyeq5-clk.yaml new file mode 100644 index 000000000000..44eff4618ca7 --- /dev/null +++ b/Documentation/devicetree/bindings/clock/mobileye,eyeq5-clk.yaml @@ -0,0 +1,52 @@ +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) +%YAML 1.2 +--- +$id: http://devicetree.org/schemas/clock/mobileye,eyeq5-clk.yaml# +$schema: http://devicetree.org/meta-schemas/core.yaml# + +title: Mobileye EyeQ5 clock controller + +description: + The EyeQ5 clock controller handles 10 read-only PLLs derived from the main + crystal clock. It also exposes one divider clock, a child of one of the PLLs. + Its registers live in a shared region called OLB. + +maintainers: + - Grégory Clement <gregory.clement@bootlin.com> + - Théo Lebrun <theo.lebrun@bootlin.com> + - Vladimir Kondratiev <vladimir.kondratiev@mobileye.com> + +properties: + compatible: + const: mobileye,eyeq5-clk + + reg: + minItems: 2 + maxItems: 2 + + reg-names: + items: + - const: plls + - const: ospi + + "#clock-cells": + const: 1 + + clocks: + maxItems: 1 + description: + Input parent clock to all PLLs. Expected to be the main crystal. + + clock-names: + items: + - const: ref + +required: + - compatible + - reg + - reg-names + - "#clock-cells" + - clocks + - clock-names + +additionalProperties: false diff --git a/MAINTAINERS b/MAINTAINERS index 260bcfc6da8f..42db14d184be 100644 --- a/MAINTAINERS +++ b/MAINTAINERS @@ -14786,10 +14786,12 @@ M: Gregory CLEMENT <gregory.clement@bootlin.com> M: Théo Lebrun <theo.lebrun@bootlin.com> L: linux-mips@vger.kernel.org S: Maintained +F: Documentation/devicetree/bindings/clock/mobileye,eyeq5-clk.yaml F: Documentation/devicetree/bindings/mips/mobileye.yaml F: arch/mips/boot/dts/mobileye/ F: arch/mips/configs/eyeq5_defconfig F: arch/mips/mobileye/board-epm5.its.S +F: include/dt-bindings/clock/mobileye,eyeq5-clk.h F: include/dt-bindings/soc/mobileye,eyeq5.h MODULE SUPPORT diff --git a/include/dt-bindings/clock/mobileye,eyeq5-clk.h b/include/dt-bindings/clock/mobileye,eyeq5-clk.h new file mode 100644 index 000000000000..26d8930335e4 --- /dev/null +++ b/include/dt-bindings/clock/mobileye,eyeq5-clk.h @@ -0,0 +1,22 @@ +/* SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause) */ +/* + * Copyright (C) 2024 Mobileye Vision Technologies Ltd. + */ + +#ifndef _DT_BINDINGS_CLOCK_MOBILEYE_EYEQ5_CLK_H +#define _DT_BINDINGS_CLOCK_MOBILEYE_EYEQ5_CLK_H + +#define EQ5C_PLL_CPU 0 +#define EQ5C_PLL_VMP 1 +#define EQ5C_PLL_PMA 2 +#define EQ5C_PLL_VDI 3 +#define EQ5C_PLL_DDR0 4 +#define EQ5C_PLL_PCI 5 +#define EQ5C_PLL_PER 6 +#define EQ5C_PLL_PMAC 7 +#define EQ5C_PLL_MPC 8 +#define EQ5C_PLL_DDR1 9 + +#define EQ5C_DIV_OSPI 10 + +#endif
Add DT schema bindings for the EyeQ5 clock controller driver. Signed-off-by: Théo Lebrun <theo.lebrun@bootlin.com> --- .../bindings/clock/mobileye,eyeq5-clk.yaml | 52 ++++++++++++++++++++++ MAINTAINERS | 2 + include/dt-bindings/clock/mobileye,eyeq5-clk.h | 22 +++++++++ 3 files changed, 76 insertions(+)