| Message ID | 20240718-md-mips-arch-mips-sibyte-common-v1-1-49b29b0555eb@quicinc.com (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 2c716cf17edee74424336e87fe42b99ee5e91bad |
| Headers | show |
| Series | mips: sibyte: add missing MODULE_DESCRIPTION() macro | expand |
On Thu, Jul 18, 2024 at 04:17:52PM -0700, Jeff Johnson wrote: > Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the > description is missing"), a module without a MODULE_DESCRIPTION() will > result in a warning with make W=1. The following warning is being > observed when ARCH=mips and CONFIG_SIBYTE_TBPROF=m: > > WARNING: modpost: missing MODULE_DESCRIPTION() in arch/mips/sibyte/common/sb_tbprof.o > > Add the missing invocation of the MODULE_DESCRIPTION() macro. > > Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> > --- > I'm trying to fix all of these issues in 6.11, so please take this > through your "for current" path instead of your "for next" path. If > you don't have a "for current" path, Greg KH has indicated he'll pick > up the stragglers before the 6.11 rc-final. > --- > arch/mips/sibyte/common/sb_tbprof.c | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/mips/sibyte/common/sb_tbprof.c b/arch/mips/sibyte/common/sb_tbprof.c > index af5333986900..149a9151bc0b 100644 > --- a/arch/mips/sibyte/common/sb_tbprof.c > +++ b/arch/mips/sibyte/common/sb_tbprof.c > @@ -589,4 +589,5 @@ module_exit(sbprof_tb_cleanup); > > MODULE_ALIAS_CHARDEV_MAJOR(SBPROF_TB_MAJOR); > MODULE_AUTHOR("Ralf Baechle <ralf@linux-mips.org>"); > +MODULE_DESCRIPTION("Support for ZBbus profiling"); > MODULE_LICENSE("GPL"); > > --- > base-commit: 51835949dda3783d4639cfa74ce13a3c9829de00 > change-id: 20240718-md-mips-arch-mips-sibyte-common-7c51d90b31f2 applied to mips-next. Thomas.
diff --git a/arch/mips/sibyte/common/sb_tbprof.c b/arch/mips/sibyte/common/sb_tbprof.c index af5333986900..149a9151bc0b 100644 --- a/arch/mips/sibyte/common/sb_tbprof.c +++ b/arch/mips/sibyte/common/sb_tbprof.c @@ -589,4 +589,5 @@ module_exit(sbprof_tb_cleanup); MODULE_ALIAS_CHARDEV_MAJOR(SBPROF_TB_MAJOR); MODULE_AUTHOR("Ralf Baechle <ralf@linux-mips.org>"); +MODULE_DESCRIPTION("Support for ZBbus profiling"); MODULE_LICENSE("GPL");
Since commit 1fffe7a34c89 ("script: modpost: emit a warning when the description is missing"), a module without a MODULE_DESCRIPTION() will result in a warning with make W=1. The following warning is being observed when ARCH=mips and CONFIG_SIBYTE_TBPROF=m: WARNING: modpost: missing MODULE_DESCRIPTION() in arch/mips/sibyte/common/sb_tbprof.o Add the missing invocation of the MODULE_DESCRIPTION() macro. Signed-off-by: Jeff Johnson <quic_jjohnson@quicinc.com> --- I'm trying to fix all of these issues in 6.11, so please take this through your "for current" path instead of your "for next" path. If you don't have a "for current" path, Greg KH has indicated he'll pick up the stragglers before the 6.11 rc-final. --- arch/mips/sibyte/common/sb_tbprof.c | 1 + 1 file changed, 1 insertion(+) --- base-commit: 51835949dda3783d4639cfa74ce13a3c9829de00 change-id: 20240718-md-mips-arch-mips-sibyte-common-7c51d90b31f2