| Message ID | 20241221035352.1020228-2-ariel.otilibili-anieli@eurecom.fr (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | broadcom, ethernet/marvell,cx231xx,can/dev: Remove unused values and dead code | expand |
On Sat, Dec 21, 2024 at 04:44:15AM +0100, Ariel Otilibili wrote: > Coverity-IDs: 1487817, 1561102 > Signed-off-by: Ariel Otilibili <ariel.otilibili-anieli@eurecom.fr> One patch per driver please. > --- a/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c > +++ b/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c > @@ -329,11 +329,9 @@ static int cn10k_mcs_write_rx_flowid(struct otx2_nic *pfvf, > mac_da = ether_addr_to_u64(secy->netdev->dev_addr); > > req->data[0] = FIELD_PREP(MCS_TCAM0_MAC_DA_MASK, mac_da); > - req->mask[0] = ~0ULL; > req->mask[0] = ~MCS_TCAM0_MAC_DA_MASK; > > req->data[1] = FIELD_PREP(MCS_TCAM1_ETYPE_MASK, ETH_P_MACSEC); > - req->mask[1] = ~0ULL; > req->mask[1] &= ~MCS_TCAM1_ETYPE_MASK; > As i said to another patch, you need to argue why you change is correct. If you have no idea what the correct fix is, you should simply report the issue to the Maintainer, and look at the git history for these lines and see who added them, and ask them what is the correct fix. Andrew
diff --git a/drivers/firmware/broadcom/tee_bnxt_fw.c b/drivers/firmware/broadcom/tee_bnxt_fw.c index 40e3183a3d11..e0ea4ddb9a74 100644 --- a/drivers/firmware/broadcom/tee_bnxt_fw.c +++ b/drivers/firmware/broadcom/tee_bnxt_fw.c @@ -143,8 +143,6 @@ int tee_bnxt_copy_coredump(void *buf, u32 offset, u32 size) prepare_args(TA_CMD_BNXT_COPY_COREDUMP, &arg, param); while (rbytes) { - nbytes = rbytes; - nbytes = min_t(u32, rbytes, param[0].u.memref.size); /* Fill additional invoke cmd params */ diff --git a/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c b/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c index 6cc7a78968fc..0584528485e6 100644 --- a/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c +++ b/drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c @@ -329,11 +329,9 @@ static int cn10k_mcs_write_rx_flowid(struct otx2_nic *pfvf, mac_da = ether_addr_to_u64(secy->netdev->dev_addr); req->data[0] = FIELD_PREP(MCS_TCAM0_MAC_DA_MASK, mac_da); - req->mask[0] = ~0ULL; req->mask[0] = ~MCS_TCAM0_MAC_DA_MASK; req->data[1] = FIELD_PREP(MCS_TCAM1_ETYPE_MASK, ETH_P_MACSEC); - req->mask[1] = ~0ULL; req->mask[1] &= ~MCS_TCAM1_ETYPE_MASK; req->mask[2] = ~0ULL;
Coverity-IDs: 1487817, 1561102 Signed-off-by: Ariel Otilibili <ariel.otilibili-anieli@eurecom.fr> --- drivers/firmware/broadcom/tee_bnxt_fw.c | 2 -- drivers/net/ethernet/marvell/octeontx2/nic/cn10k_macsec.c | 2 -- 2 files changed, 4 deletions(-)