From patchwork Mon Apr 7 07:25:07 2025 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Bartosz Golaszewski X-Patchwork-Id: 14039850 Received: from mail-wr1-f48.google.com (mail-wr1-f48.google.com [209.85.221.48]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8C441225A29 for ; Mon, 7 Apr 2025 07:25:14 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.48 ARC-Seal: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010717; cv=none; b=hlGixlSzV75k5/SY9ftoe+eYemBo7ktFYA8BOmjJkE9PbTpDfAcmQmsG5rYpQ2UH5pZojXwNAI60C2kXj3Y7I4umYoYQ1vocih+3JmoK4Z4CScSZHKG6YMnmWrqjXLl9q7sZZhfZ8ecpraxDk9agu4MgxC80ive9/fyjG+PF1YE= ARC-Message-Signature: i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1744010717; c=relaxed/simple; bh=zPFQTxsu9KrfRO7qIWKrD8w2tFvy9Vh5/igl74bqvnI=; h=From:Date:Subject:MIME-Version:Content-Type:Message-Id:References: In-Reply-To:To:Cc; b=gW+6TlTmPt5IipPdZXyGkM7q6Pej3/huy8KqpVVOOmuD9RvVpXCDeWlGo1DVwPp9G+O8qP/hxt6jm4XggG+rUkWCMn0xHH85G9shYC7QLXkExMpPjaebvq5n0+m/Gcakpy7lioX1SRK5zP5MaZK1IP5FWT0Ax8oGUKEightNa4g= ARC-Authentication-Results: i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl; spf=none smtp.mailfrom=bgdev.pl; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b=QXTxvB+u; arc=none smtp.client-ip=209.85.221.48 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; spf=none smtp.mailfrom=bgdev.pl Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=bgdev-pl.20230601.gappssmtp.com header.i=@bgdev-pl.20230601.gappssmtp.com header.b="QXTxvB+u" Received: by mail-wr1-f48.google.com with SMTP id ffacd0b85a97d-39c266c2dd5so3469416f8f.3 for ; Mon, 07 Apr 2025 00:25:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bgdev-pl.20230601.gappssmtp.com; s=20230601; t=1744010713; x=1744615513; darn=vger.kernel.org; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:from:to:cc:subject:date:message-id :reply-to; bh=WUo/CGbtBVvw4imrMqD2aY6g1pYyX/Iq7KegZMsusa8=; b=QXTxvB+uqrbJjQhfkriNvxpXRuqomIeJaFPkTfsXT2O912jk78burkdykkqaDitUQI VxtZH6R0j8RoBs0Sqsb8RIG/AvTpcyoTYvQ7OgoenrY0juS5Bjj34WBy1WcHSXaWP5r8 jJvFwSzsln1fr187X3ZFwrF0r2RGrJla0HULXwXYpA1xWpZSskDN8fzHQG1ySk6sbW1v tNfTr9QaARauvlEkDD1XdZNl69uB3zvKRTyVHokAIh337vB6OlL5ZacqMbRvyyycd6Xr 2NKjc+kTIt8CtZVP1mM0Xgbwkxi6s0dyD7+RNbuv+KxwcqgS8UjWiJh5aCU0+ty5VUB8 VVTg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1744010713; x=1744615513; h=cc:to:in-reply-to:references:message-id:content-transfer-encoding :mime-version:subject:date:from:x-gm-message-state:from:to:cc :subject:date:message-id:reply-to; bh=WUo/CGbtBVvw4imrMqD2aY6g1pYyX/Iq7KegZMsusa8=; b=DYtvwdYCdHRvksPxOCdzfVT2jdQNlhUCiahElxE9ZaqeGlakAD9SWAlD1l/r/ubpor fUmMER3hB8quJFrTZzDHbLOX+2Z76cL03vNv2tbt4PEWy6hoDGDdoDWhlQF/J/8R1lwn RUzumnoavdWYLf64qlIozgNim1ZqO+vsiE+gEYJHthdAl2ClmYnB7X8rMN8aQQqwOQ5M bnFrQmZ2l2+NumNjtzJzp55e3Z9Uq7PAPLugy3RhWl0ExDFLJAiDkzknpPa7nA21QrmJ 1bUi9fEf0hfv2pc4MNetCzBE34+HxPOVF/qkIL9l22Q/8Q7AEPazzdWAeViBrvgcT6R4 SP6w== X-Gm-Message-State: AOJu0Yx18aE4XmGIuy/iuOg92sk7MaohuhPresXzWtDjru+Sb0ZKW5I8 GTEfZ0NyDe6huZunOY21Tb8XqJtHHU5WmaVkbUz7gEuTE55XTQrdWJuozoMnS7V57UGgAG2WIEx ZcVs= X-Gm-Gg: ASbGncv0km67xwB0h+gjsPCDnqAWRYdeO+82d2BYfC1euaLb82wAeWPzs8d1TsRAPEv KsuSWffX/9RfNn+xwOX+MVGxdccpKbi+BOLpXHELJMhX6bAfHCHv4FXFv8h0FA56wStfFVGXTGw TEK+n5NqIvfygTzxk5WnIP1ObgsQ6ihAnIWzzAvUtjyJLPWuwcs5nE0othJdR1CmtuVB1TYfd6r mvK/nlAOhO7sSHsMRJqbkywhQN1rRnu7DRz2q6g+DvWX07JswMmrndVh26A3BhPbJzCbTbStd1S NsKhOXEMCQFazjKhZf7x+g4oDNcR5McdethGVw== X-Google-Smtp-Source: AGHT+IFZIu6StM8ElkRE+r6BIYiBUWx6cTIS/f7UqaoT/hdn+OorxGZiBS8LLsETi1nO8uCS+7rsyQ== X-Received: by 2002:a05:6000:1886:b0:38f:2ddd:a1bb with SMTP id ffacd0b85a97d-39d0864b966mr7660682f8f.8.1744010712872; Mon, 07 Apr 2025 00:25:12 -0700 (PDT) Received: from [127.0.1.1] ([2a01:cb1d:dc:7e00:8c64:734d:705a:39a7]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-39c301b760bsm11303051f8f.55.2025.04.07.00.25.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 07 Apr 2025 00:25:12 -0700 (PDT) From: Bartosz Golaszewski Date: Mon, 07 Apr 2025 09:25:07 +0200 Subject: [PATCH 1/4] MIPS: rb532: gpio: use new line value setter callbacks Precedence: bulk X-Mailing-List: linux-mips@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Message-Id: <20250407-gpiochip-set-rv-mips-v1-1-e7f74a4eee2b@linaro.org> References: <20250407-gpiochip-set-rv-mips-v1-0-e7f74a4eee2b@linaro.org> In-Reply-To: <20250407-gpiochip-set-rv-mips-v1-0-e7f74a4eee2b@linaro.org> To: Thomas Bogendoerfer , Linus Walleij , Bartosz Golaszewski Cc: linux-mips@vger.kernel.org, linux-kernel@vger.kernel.org, linux-gpio@vger.kernel.org, Bartosz Golaszewski X-Mailer: b4 0.14.1 X-Developer-Signature: v=1; a=openpgp-sha256; l=1306; i=bartosz.golaszewski@linaro.org; h=from:subject:message-id; bh=uG5xobKQ/BCqBbmPWIob9NsHTVtZMYwi25uBBftiBYo=; b=owEBbQKS/ZANAwAKARGnLqAUcddyAcsmYgBn833WAv5DpLvQ/18Q2vsoL0ibVRB6cyZ0AoLfy goRiAcKusmJAjMEAAEKAB0WIQQWnetsC8PEYBPSx58Rpy6gFHHXcgUCZ/N91gAKCRARpy6gFHHX cplDEACpEWXa+/sW0az+OMmWA4dZHqyLntzrc0ZqCvrhHPe/R4wI7JV8uLW74+WppTO/GwvAtGI NwOAI3x63sYa6Bw2F9UuVTchSJCKTc7Fu7Jk4IXy5KDqCyM8Rx2K7ZPsJAijoP8AlSnsni9fUmI Hby/KNJlIMn8jABhNXo1mwW1MJcUEL55/lzebyuut6OEWud1BQxk9RW8vIq1ipOBf/q1baQAHxQ IxuVO0MlPAvg7aJRNbGQNzqZIGAQOdRMyTvVZM0K/MxSL7VydjwjgZlaWKUxSfnB8uZJ+5+INvt MdTL0dDHnqGVt65nf2r0yNnFmLVRy6BTBoj7eDU87MXk7kprt1jvPt4KLUp1ywlMoN+mqBEfzP4 eGwELyWO8AY7FQfwJKU+KW42oam8MLsBaWdzVPVeNx2jRrKe6r/I31ROfwL85Gou5cDEiBhOipn X7pks6NXTb1Zxk+mZK9FvE7EzC10P1E4woDAIJWrZ8GBDeMKzQMIoC0jDGnbGmEBP+ZDG/+R+HI T2WqB/CxlNNwwmpy2VeS1RPVnRSoDYPIBYIg53W7U6dyKETPwNxsaszkN4A/eTU19/USccW/sCZ 50dRsahzy0p/McaOlptmTXREd0SyMzxhlhd94EbE0s/qi8BswRxyiOYudjO/bjPho2MOgpa5y1b 5mZGodWhpbKjmNA== X-Developer-Key: i=bartosz.golaszewski@linaro.org; a=openpgp; fpr=169DEB6C0BC3C46013D2C79F11A72EA01471D772 From: Bartosz Golaszewski struct gpio_chip now has callbacks for setting line values that return an integer, allowing to indicate failures. Convert the driver to using them. Signed-off-by: Bartosz Golaszewski --- arch/mips/rb532/gpio.c | 8 +++++--- 1 file changed, 5 insertions(+), 3 deletions(-) diff --git a/arch/mips/rb532/gpio.c b/arch/mips/rb532/gpio.c index ea6ebfea4a67..0e47cd59b6cb 100644 --- a/arch/mips/rb532/gpio.c +++ b/arch/mips/rb532/gpio.c @@ -105,13 +105,15 @@ static int rb532_gpio_get(struct gpio_chip *chip, unsigned offset) /* * Set output GPIO level */ -static void rb532_gpio_set(struct gpio_chip *chip, - unsigned offset, int value) +static int rb532_gpio_set(struct gpio_chip *chip, unsigned int offset, + int value) { struct rb532_gpio_chip *gpch; gpch = gpiochip_get_data(chip); rb532_set_bit(value, offset, gpch->regbase + GPIOD); + + return 0; } /* @@ -162,7 +164,7 @@ static struct rb532_gpio_chip rb532_gpio_chip[] = { .direction_input = rb532_gpio_direction_input, .direction_output = rb532_gpio_direction_output, .get = rb532_gpio_get, - .set = rb532_gpio_set, + .set_rv = rb532_gpio_set, .to_irq = rb532_gpio_to_irq, .base = 0, .ngpio = 32,