| Message ID | 20250407082759.742105-1-thorsten.blum@linux.dev (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | MIPS: ralink: Fix refcount leak in ill_acc_of_setup() | expand |
diff --git a/arch/mips/ralink/ill_acc.c b/arch/mips/ralink/ill_acc.c index 25341b2319d0..6d1d829854b6 100644 --- a/arch/mips/ralink/ill_acc.c +++ b/arch/mips/ralink/ill_acc.c @@ -84,6 +84,7 @@ static int __init ill_acc_of_setup(void) rt_memc_w32(ILL_INT_STATUS, REG_ILL_ACC_TYPE); dev_info(&pdev->dev, "irq registered\n"); + put_device(&pdev->dev); return 0; }
The of_find_device_by_node() function increments the reference count of the embedded device, which should be released with put_device() when it is no longer needed. In ill_acc_of_setup(), put_device() is only called on error paths, but not on the success path. Fix this by calling put_device() before returning successfully. Compile-tested only. Cc: stable@vger.kernel.org Fixes: 5433acd81e873 ("MIPS: ralink: add illegal access driver") Signed-off-by: Thorsten Blum <thorsten.blum@linux.dev> --- arch/mips/ralink/ill_acc.c | 1 + 1 file changed, 1 insertion(+)