| Message ID | 32a2afa1a8f1f675a199d1aa9b4469bed2391069.1649443080.git.hns@goldelico.com (mailing list archive) |
|---|---|
| State | New |
| Headers | show |
| Series | MIPS: DTS: fix some findings by "make ci20_defconfig dt_binding_check dtbs_check" | expand |
On 08/04/2022 20:38, H. Nikolaus Schaller wrote: > arch/mips/boot/dts/ingenic/ci20.dtb: bluetooth: vcc-supply does not match any of the regexes: pinctrl-[0-9]+ > From schema: Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml > > Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> > --- > arch/mips/boot/dts/ingenic/ci20.dts | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) > > diff --git a/arch/mips/boot/dts/ingenic/ci20.dts b/arch/mips/boot/dts/ingenic/ci20.dts > index dc587b4b36009..8a120f9374331 100644 > --- a/arch/mips/boot/dts/ingenic/ci20.dts > +++ b/arch/mips/boot/dts/ingenic/ci20.dts > @@ -207,7 +207,7 @@ &uart2 { > bluetooth { > compatible = "brcm,bcm4330-bt"; > reset-gpios = <&gpf 8 GPIO_ACTIVE_HIGH>; > - vcc-supply = <&wlan0_power>; > + vbat-supply = <&wlan0_power>; Could be also vddio... Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> Best regards, Krzysztof
> Am 09.04.2022 um 13:22 schrieb Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>: > > On 08/04/2022 20:38, H. Nikolaus Schaller wrote: >> arch/mips/boot/dts/ingenic/ci20.dtb: bluetooth: vcc-supply does not match any of the regexes: pinctrl-[0-9]+ >> From schema: Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml >> >> Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> >> --- >> arch/mips/boot/dts/ingenic/ci20.dts | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) >> >> diff --git a/arch/mips/boot/dts/ingenic/ci20.dts b/arch/mips/boot/dts/ingenic/ci20.dts >> index dc587b4b36009..8a120f9374331 100644 >> --- a/arch/mips/boot/dts/ingenic/ci20.dts >> +++ b/arch/mips/boot/dts/ingenic/ci20.dts >> @@ -207,7 +207,7 @@ &uart2 { >> bluetooth { >> compatible = "brcm,bcm4330-bt"; >> reset-gpios = <&gpf 8 GPIO_ACTIVE_HIGH>; >> - vcc-supply = <&wlan0_power>; >> + vbat-supply = <&wlan0_power>; > > Could be also vddio... Good hint. Schematics has both vbat AND vddio connected. But with that finding, there is also a wifi_io regulator for 2.5V. It is always-on and NOT yet controlled. So this is worth a functional addition. But not related to dtbscheck cleanup because it even is optional. Hence a separate topic. > > > Acked-by: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org> > > > Best regards, > Krzysztof In summary for reviewing all patches: many thanks! BR, Nikolaus
diff --git a/arch/mips/boot/dts/ingenic/ci20.dts b/arch/mips/boot/dts/ingenic/ci20.dts index dc587b4b36009..8a120f9374331 100644 --- a/arch/mips/boot/dts/ingenic/ci20.dts +++ b/arch/mips/boot/dts/ingenic/ci20.dts @@ -207,7 +207,7 @@ &uart2 { bluetooth { compatible = "brcm,bcm4330-bt"; reset-gpios = <&gpf 8 GPIO_ACTIVE_HIGH>; - vcc-supply = <&wlan0_power>; + vbat-supply = <&wlan0_power>; device-wakeup-gpios = <&gpf 5 GPIO_ACTIVE_HIGH>; host-wakeup-gpios = <&gpf 6 GPIO_ACTIVE_HIGH>; shutdown-gpios = <&gpf 4 GPIO_ACTIVE_LOW>;
arch/mips/boot/dts/ingenic/ci20.dtb: bluetooth: vcc-supply does not match any of the regexes: pinctrl-[0-9]+ From schema: Documentation/devicetree/bindings/net/broadcom-bluetooth.yaml Signed-off-by: H. Nikolaus Schaller <hns@goldelico.com> --- arch/mips/boot/dts/ingenic/ci20.dts | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)