| Message ID | 9bc24670be4b1386c9b5c60f158c6acd7b723e72.1650720222.git.christophe.jaillet@wanadoo.fr (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 33d7085682b4aa212ebfadbc21da81dfefaaac16 |
| Headers | show |
| Series | MIPS: SGI-IP27: Free some unused memory | expand |
On Sat, Apr 23, 2022 at 03:24:03PM +0200, Christophe JAILLET wrote: > platform_device_add_data() duplicates the memory it is passed. So we can > free some memory to save a few bytes that would remain unused otherwise. > > Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> > --- > arch/mips/sgi-ip27/ip27-xtalk.c | 4 ++++ > 1 file changed, 4 insertions(+) > > diff --git a/arch/mips/sgi-ip27/ip27-xtalk.c b/arch/mips/sgi-ip27/ip27-xtalk.c > index 000ede156bdc..e762886d1dda 100644 > --- a/arch/mips/sgi-ip27/ip27-xtalk.c > +++ b/arch/mips/sgi-ip27/ip27-xtalk.c > @@ -53,6 +53,8 @@ static void bridge_platform_create(nasid_t nasid, int widget, int masterwid) > } > platform_device_add_resources(pdev, &w1_res, 1); > platform_device_add_data(pdev, wd, sizeof(*wd)); > + /* platform_device_add_data() duplicates the data */ > + kfree(wd); > platform_device_add(pdev); > > bd = kzalloc(sizeof(*bd), GFP_KERNEL); > @@ -83,6 +85,8 @@ static void bridge_platform_create(nasid_t nasid, int widget, int masterwid) > bd->io_offset = offset; > > platform_device_add_data(pdev, bd, sizeof(*bd)); > + /* platform_device_add_data() duplicates the data */ > + kfree(bd); > platform_device_add(pdev); > pr_info("xtalk:n%d/%x bridge widget\n", nasid, widget); > return; > -- > 2.32.0 applied to mips-next. Thomas.
diff --git a/arch/mips/sgi-ip27/ip27-xtalk.c b/arch/mips/sgi-ip27/ip27-xtalk.c index 000ede156bdc..e762886d1dda 100644 --- a/arch/mips/sgi-ip27/ip27-xtalk.c +++ b/arch/mips/sgi-ip27/ip27-xtalk.c @@ -53,6 +53,8 @@ static void bridge_platform_create(nasid_t nasid, int widget, int masterwid) } platform_device_add_resources(pdev, &w1_res, 1); platform_device_add_data(pdev, wd, sizeof(*wd)); + /* platform_device_add_data() duplicates the data */ + kfree(wd); platform_device_add(pdev); bd = kzalloc(sizeof(*bd), GFP_KERNEL); @@ -83,6 +85,8 @@ static void bridge_platform_create(nasid_t nasid, int widget, int masterwid) bd->io_offset = offset; platform_device_add_data(pdev, bd, sizeof(*bd)); + /* platform_device_add_data() duplicates the data */ + kfree(bd); platform_device_add(pdev); pr_info("xtalk:n%d/%x bridge widget\n", nasid, widget); return;
platform_device_add_data() duplicates the memory it is passed. So we can free some memory to save a few bytes that would remain unused otherwise. Signed-off-by: Christophe JAILLET <christophe.jaillet@wanadoo.fr> --- arch/mips/sgi-ip27/ip27-xtalk.c | 4 ++++ 1 file changed, 4 insertions(+)