diff mbox series

[2/2] MIPS: loongson3_defconfig: Enable blk_dev_nvme by default

Message ID F56016A1645609BF+5d1de4afc8ee6bacf8878461b848de72b556c85f.1730638429.git.wangyuli@uniontech.com (mailing list archive)
State New
Headers show
Series [1/2] MIPS: loongson3_defconfig: Update configs dependencies | expand

Commit Message

WangYuli Nov. 3, 2024, 1 p.m. UTC 
A significant number of 3A4000 machines come with NVMe drives
pre-installed, so we should support it in its defconfig.

Tested-by: Erpeng Xu <xuerpeng@uniontech.com>
Tested-by: Qiang Ma <maqianga@uniontech.com>
Signed-off-by: WangYuli <wangyuli@uniontech.com>
---
 arch/mips/configs/loongson3_defconfig | 1 +
 1 file changed, 1 insertion(+)

Comments

Krzysztof Kozlowski Nov. 3, 2024, 4:44 p.m. UTC | #1 
On 03/11/2024 14:00, WangYuli wrote:
> A significant number of 3A4000 machines come with NVMe drives
> pre-installed, so we should support it in its defconfig.
> 
> Tested-by: Erpeng Xu <xuerpeng@uniontech.com>
> Tested-by: Qiang Ma <maqianga@uniontech.com>

I am sorry, but what exactly did you test here? This is defconfig, so
you checked whether after building kernel there is such module? This is
not testing.

...

> +CONFIG_BLK_DEV_NVME=m
Best regards,
Krzysztof
diff mbox series

Patch

diff --git a/arch/mips/configs/loongson3_defconfig b/arch/mips/configs/loongson3_defconfig
index 30837f3b6acd..98844b457b7f 100644
--- a/arch/mips/configs/loongson3_defconfig
+++ b/arch/mips/configs/loongson3_defconfig
@@ -141,6 +141,7 @@  CONFIG_BLK_DEV_LOOP=y
 CONFIG_BLK_DEV_RAM=y
 CONFIG_BLK_DEV_RAM_SIZE=8192
 CONFIG_VIRTIO_BLK=y
+CONFIG_BLK_DEV_NVME=m
 CONFIG_RAID_ATTRS=m
 CONFIG_BLK_DEV_SD=y
 CONFIG_BLK_DEV_SR=y