| Message ID | alpine.DEB.2.21.2104211445290.44318@angie.orcam.me.uk (mailing list archive) |
|---|---|
| State | Accepted |
| Commit | 182dd5bad52c66a54c300fe320b772456572bf23 |
| Headers | show |
| Series | lib/math/test_div64: Fix error message formatting | expand |
On Wed, Apr 21, 2021 at 03:25:22PM +0200, Maciej W. Rozycki wrote: > Align the expected result with one actually produced for easier visual > comparison; this has to take into account what the format specifiers > will actually produce rather than the characters they consist of. E.g.: > > test_div64: ERROR: 10000000ab275080 / 00000009 => 01c71c71da20d00e,00000002 > test_div64: ERROR: expected value => 0000000013045e47,00000001 > > (with a failure induced by setting bit #60 of the divident). > > Signed-off-by: Maciej W. Rozycki <macro@orcam.me.uk> > --- > lib/math/test_div64.c | 2 +- > 1 file changed, 1 insertion(+), 1 deletion(-) applied to mips-next. Thomas.
Index: linux-3maxp-div64/lib/math/test_div64.c =================================================================== --- linux-3maxp-div64.orig/lib/math/test_div64.c +++ linux-3maxp-div64/lib/math/test_div64.c @@ -170,7 +170,7 @@ static inline bool test_div64_verify(u64 if (!test_div64_verify(quotient, remainder, i, j)) { \ pr_err("ERROR: %016llx / %08x => %016llx,%08x\n", \ divident, divisor, quotient, remainder); \ - pr_err("ERROR: expected value=> %016llx,%08x\n", \ + pr_err("ERROR: expected value => %016llx,%08x\n",\ test_div64_results[i][j].quotient, \ test_div64_results[i][j].remainder); \ result = false; \
Align the expected result with one actually produced for easier visual comparison; this has to take into account what the format specifiers will actually produce rather than the characters they consist of. E.g.: test_div64: ERROR: 10000000ab275080 / 00000009 => 01c71c71da20d00e,00000002 test_div64: ERROR: expected value => 0000000013045e47,00000001 (with a failure induced by setting bit #60 of the divident). Signed-off-by: Maciej W. Rozycki <macro@orcam.me.uk> --- lib/math/test_div64.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-)