| Message ID | cae772aa897f6b10c3f5c4c93a256b50c5de4b21.1700449792.git.zhoubinbin@loongson.cn (mailing list archive) |
|---|---|
| State | Handled Elsewhere |
| Headers | show |
| Series | dt-bindings: interrupt-controller: Fix some loongson,liointc warnings | expand |
On Mon, Nov 20, 2023 at 05:06:23PM +0800, Binbin Zhou wrote: > Since the 'loongson,parent_int_map' attribute naming is non-standard, we > should use 'loongson,parent-int-map' instead. > > Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn> > Acked-by: Jiaxun Yang <jiaxun.yang@flygoat.com> > --- > .../bindings/interrupt-controller/loongson,liointc.yaml | 8 +++----- > 1 file changed, 3 insertions(+), 5 deletions(-) > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml b/Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml > index 00b570c82903..70c125bf8095 100644 > --- a/Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml > +++ b/Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml > @@ -54,7 +54,7 @@ properties: > '#interrupt-cells': > const: 2 > > - loongson,parent_int_map: > + loongson,parent-int-map: Not what I said to do. Now you just break the ABI instead of maintaining both names. Just use loongson,parent_int_map *forever*. Drop this patch. Rob
On Tue, Nov 28, 2023 at 12:28 AM Rob Herring <robh@kernel.org> wrote: > > On Mon, Nov 20, 2023 at 05:06:23PM +0800, Binbin Zhou wrote: > > Since the 'loongson,parent_int_map' attribute naming is non-standard, we > > should use 'loongson,parent-int-map' instead. > > > > Signed-off-by: Binbin Zhou <zhoubinbin@loongson.cn> > > Acked-by: Jiaxun Yang <jiaxun.yang@flygoat.com> > > --- > > .../bindings/interrupt-controller/loongson,liointc.yaml | 8 +++----- > > 1 file changed, 3 insertions(+), 5 deletions(-) > > > > diff --git a/Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml b/Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml > > index 00b570c82903..70c125bf8095 100644 > > --- a/Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml > > +++ b/Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml > > @@ -54,7 +54,7 @@ properties: > > '#interrupt-cells': > > const: 2 > > > > - loongson,parent_int_map: > > + loongson,parent-int-map: > > Not what I said to do. Now you just break the ABI instead of maintaining > both names. > > Just use loongson,parent_int_map *forever*. Drop this patch. Hi Rob: Thanks for your reply, and I am very sorry that I may have missed your previous thought, but at the same time I'm confused about how to handle the 'parent_int_map' attribute. During the V2 patchset, krzysztof noticed the non-standard naming of this property and suggested that we rename 'parent_int_map' in the binding and label it as "deprecated". But you don't think it's worth doing that. My understanding is that it doesn't make sense to keep 'parent_int_map' for the new binding, so I'm just going to rename the property in this version. It's true that this will result in an ABI break, but at the same time corresponding changes have been made to the driver as well as in the existing DTS{i}: Patch 4: Handles attribute names in both naming styles; Patch 5: Replace all 'parent_int_map' in the MIPS DTS{i}. Do you think this is a suitable way to handle this? Or just keep the "_" naming? Thanks. Binbin > > Rob
diff --git a/Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml b/Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml index 00b570c82903..70c125bf8095 100644 --- a/Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml +++ b/Documentation/devicetree/bindings/interrupt-controller/loongson,liointc.yaml @@ -54,7 +54,7 @@ properties: '#interrupt-cells': const: 2 - loongson,parent_int_map: + loongson,parent-int-map: description: | This property points how the children interrupts will be mapped into CPU interrupt lines. Each cell refers to a parent interrupt line from 0 to 3 @@ -71,8 +71,7 @@ required: - interrupts - interrupt-controller - '#interrupt-cells' - - loongson,parent_int_map - + - loongson,parent-int-map unevaluatedProperties: false @@ -109,11 +108,10 @@ examples: interrupts = <2>, <3>; interrupt-names = "int0", "int1"; - loongson,parent_int_map = <0xf0ffffff>, /* int0 */ + loongson,parent-int-map = <0xf0ffffff>, /* int0 */ <0x0f000000>, /* int1 */ <0x00000000>, /* int2 */ <0x00000000>; /* int3 */ - }; ...