| Message ID | ce48e2d625bdd4766496d44ae089e9de@208suo.com (mailing list archive) |
|---|---|
| State | Superseded |
| Headers | show |
| Series | MIPS: Octeon: remove unneeded variable | expand |
On Wed, 14 Jun 2023, baomingtong001@208suo.com wrote: > fix the following coccicheck warning: > > arch/mips/cavium-octeon/executive/cvmx-spi.c:152:5-8: Unneeded variable: > "res". Have you actually tried to rebuild with your "fix" applied? Please always do before submitting patches. Maciej
diff --git a/arch/mips/cavium-octeon/executive/cvmx-spi.c b/arch/mips/cavium-octeon/executive/cvmx-spi.c index eb9333e84a6b..1f8b85473677 100644 --- a/arch/mips/cavium-octeon/executive/cvmx-spi.c +++ b/arch/mips/cavium-octeon/executive/cvmx-spi.c @@ -149,10 +149,9 @@ int cvmx_spi_start_interface(int interface, cvmx_spi_mode_t mode, int timeout, */ int cvmx_spi_restart_interface(int interface, cvmx_spi_mode_t mode, int timeout) { - int res = -1; if (!(OCTEON_IS_MODEL(OCTEON_CN38XX) || OCTEON_IS_MODEL(OCTEON_CN58XX))) - return res; + return -1;
fix the following coccicheck warning: arch/mips/cavium-octeon/executive/cvmx-spi.c:152:5-8: Unneeded variable: "res". Signed-off-by: Mingtong Bao <baomingtong001@208suo.com> --- arch/mips/cavium-octeon/executive/cvmx-spi.c | 5 ++--- 1 file changed, 2 insertions(+), 3 deletions(-) cvmx_dprintf("SPI%d: Restart %s\n", interface, modes[mode]); @@ -175,7 +174,7 @@ int cvmx_spi_restart_interface(int interface, cvmx_spi_mode_t mode, int timeout) /* Callback to handle interface coming up */ INVOKE_CB(cvmx_spi_callbacks.interface_up_cb, interface, mode); - return res; + return -1; } EXPORT_SYMBOL_GPL(cvmx_spi_restart_interface);