From patchwork Sun Sep 1 16:10:39 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Fredrik Noring X-Patchwork-Id: 11125457 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 92CE214DE for ; Sun, 1 Sep 2019 16:10:43 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [209.132.180.67]) by mail.kernel.org (Postfix) with ESMTP id 7028E233A2 for ; Sun, 1 Sep 2019 16:10:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728779AbfIAQKm (ORCPT ); Sun, 1 Sep 2019 12:10:42 -0400 Received: from pio-pvt-msa1.bahnhof.se ([79.136.2.40]:58412 "EHLO pio-pvt-msa1.bahnhof.se" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726121AbfIAQKm (ORCPT ); Sun, 1 Sep 2019 12:10:42 -0400 Received: from localhost (localhost [127.0.0.1]) by pio-pvt-msa1.bahnhof.se (Postfix) with ESMTP id A76E23F73E; Sun, 1 Sep 2019 18:10:40 +0200 (CEST) X-Virus-Scanned: Debian amavisd-new at bahnhof.se X-Spam-Flag: NO X-Spam-Score: -1.899 X-Spam-Level: X-Spam-Status: No, score=-1.899 tagged_above=-999 required=6.31 tests=[BAYES_00=-1.9, URIBL_BLOCKED=0.001] autolearn=ham autolearn_force=no Received: from pio-pvt-msa1.bahnhof.se ([127.0.0.1]) by localhost (pio-pvt-msa1.bahnhof.se [127.0.0.1]) (amavisd-new, port 10024) with ESMTP id yzvVOPONVFVy; Sun, 1 Sep 2019 18:10:40 +0200 (CEST) Received: from localhost (h-41-252.A163.priv.bahnhof.se [46.59.41.252]) (Authenticated sender: mb547485) by pio-pvt-msa1.bahnhof.se (Postfix) with ESMTPA id 671063F752; Sun, 1 Sep 2019 18:10:39 +0200 (CEST) Date: Sun, 1 Sep 2019 18:10:39 +0200 From: Fredrik Noring To: Paul Burton , linux-mips@vger.kernel.org Cc: "Maciej W. Rozycki" , =?utf-8?q?J=C3=BCrgen?= Urban Subject: [PATCH 066/120] FIXME: Export _dma_cache_{wback,wback_inv,inv} Message-ID: References: MIME-Version: 1.0 Content-Disposition: inline In-Reply-To: User-Agent: Mutt/1.10.1 (2018-07-13) Sender: linux-mips-owner@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: linux-mips@vger.kernel.org Commit e58cfbfb32d1 ("MIPS: remove the _dma_cache_wback_inv export") removes EXPORT_SYMBOL(_dma_cache_wback_inv) but what are the acceptable alternatives? Streaming DMA mappings? dma_cache_wback_inv() and dma_cache_inv() are used in subsequent changes, but I suppose these must be changed to something appropriate. The current DMA handling is very simple, although the hardware is quite capable (for example, with scatter-gather lists, chaining and so on). Signed-off-by: Fredrik Noring --- arch/mips/mm/cache.c | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/arch/mips/mm/cache.c b/arch/mips/mm/cache.c index 33b409391ddb..a01923b30086 100644 --- a/arch/mips/mm/cache.c +++ b/arch/mips/mm/cache.c @@ -62,6 +62,10 @@ void (*_dma_cache_wback_inv)(unsigned long start, unsigned long size); void (*_dma_cache_wback)(unsigned long start, unsigned long size); void (*_dma_cache_inv)(unsigned long start, unsigned long size); +EXPORT_SYMBOL(_dma_cache_wback_inv); +EXPORT_SYMBOL(_dma_cache_wback); +EXPORT_SYMBOL(_dma_cache_inv); + #endif /* CONFIG_DMA_NONCOHERENT */ /*