From patchwork Wed Jul 25 10:38:50 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Nir Dotan X-Patchwork-Id: 10543829 X-Patchwork-Delegate: idosch@idosch.org Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 033511822 for ; Wed, 25 Jul 2018 10:39:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E50DF29A57 for ; Wed, 25 Jul 2018 10:39:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D96CC29A95; Wed, 25 Jul 2018 10:39:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, UNPARSEABLE_RELAY autolearn=ham version=3.3.1 Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id A1E4429A57 for ; Wed, 25 Jul 2018 10:39:31 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 41bBYY2D3yzDrVP for ; Wed, 25 Jul 2018 20:39:29 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=mellanox.com X-Original-To: linux-mlxsw@lists.ozlabs.org Delivered-To: linux-mlxsw@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=mellanox.com (client-ip=193.47.165.129; helo=mellanox.co.il; envelope-from=nird@mellanox.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=mellanox.com Received: from mellanox.co.il (mail-il-dmz.mellanox.com [193.47.165.129]) by lists.ozlabs.org (Postfix) with ESMTP id 41bBYR3R8pzDrHF for ; Wed, 25 Jul 2018 20:39:19 +1000 (AEST) Received: from Internal Mail-Server by MTLPINE1 (envelope-from nird@mellanox.com) with ESMTPS (AES256-SHA encrypted); 25 Jul 2018 13:42:30 +0300 Received: from r-vnc13.mtr.labs.mlnx (r-vnc13.mtr.labs.mlnx [10.208.0.13]) by labmailer.mlnx (8.13.8/8.13.8) with ESMTP id w6PAdFHF013855; Wed, 25 Jul 2018 13:39:15 +0300 Received: from r-vnc13.mtr.labs.mlnx (r-vnc13.mtr.labs.mlnx [127.0.0.1]) by r-vnc13.mtr.labs.mlnx (8.14.4/8.14.4) with ESMTP id w6PAdFJU002622; Wed, 25 Jul 2018 13:39:15 +0300 Received: (from nird@localhost) by r-vnc13.mtr.labs.mlnx (8.14.4/8.14.4/Submit) id w6PAdFZc002617; Wed, 25 Jul 2018 13:39:15 +0300 From: Nir Dotan To: mlxsw-wiki@mellanox.com Subject: [PATCH mlxsw.wiki] Bridge: Update VLAN-aware bridge section Date: Wed, 25 Jul 2018 13:38:50 +0300 Message-Id: <20180725103850.2466-1-nird@mellanox.com> X-Mailer: git-send-email 2.8.4 X-BeenThere: linux-mlxsw@lists.ozlabs.org X-Mailman-Version: 2.1.27 Precedence: list List-Id: mlxsw driver development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , MIME-Version: 1.0 Errors-To: linux-mlxsw-bounces+patchwork-linux-mlxsw=patchwork.kernel.org@lists.ozlabs.org X-Virus-Scanned: ClamAV using ClamSMTP Update text as port netdevs can be enslaved to a non VLAN-aware bridge. Signed-off-by: Nir Dotan --- Bridge.md | 12 ++---------- 1 file changed, 2 insertions(+), 10 deletions(-) diff --git a/Bridge.md b/Bridge.md index 21779dd..f931a75 100644 --- a/Bridge.md +++ b/Bridge.md @@ -123,15 +123,7 @@ $ ip link set dev BRDEV up ##### VLAN-aware Bridge -Port netdevs can only be enslaved to a VLAN-aware bridge. Trying to enslave -`sw1p5` to `br0` while `vlan_filtering` is set to `0` results in an error. - -``` -$ ip link set dev sw1p5 master br0 -RTNETLINK answers: Invalid argument -``` - -To enslave `sw1p5` and `sw1p6` to `br0`, run: +To enslave `sw1p5` and `sw1p6` to a VLAN-aware `br0`, run: ``` $ ip link set dev br0 type bridge vlan_filtering 1 @@ -139,7 +131,7 @@ $ ip link set dev sw1p5 master br0 $ ip link set dev sw1p6 master br0 ``` -Accordingly, trying to set `vlan_filtering` to `0` while port netdevs are +Trying to set `vlan_filtering` to `0` while port netdevs are enslaved to it generates an error: ```