From patchwork Tue Apr 24 10:03:17 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Petr Machata X-Patchwork-Id: 10359215 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork.web.codeaurora.org (Postfix) with ESMTP id E87A760225 for ; Tue, 24 Apr 2018 10:04:05 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id D8E5228D56 for ; Tue, 24 Apr 2018 10:04:05 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id CB5D528D58; Tue, 24 Apr 2018 10:04:05 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.8 required=2.0 tests=BAD_ENC_HEADER,BAYES_00, DKIM_SIGNED, MAILING_LIST_MULTI, T_DKIM_INVALID autolearn=ham version=3.3.1 Received: from lists.ozlabs.org (lists.ozlabs.org [203.11.71.2]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.wl.linuxfoundation.org (Postfix) with ESMTPS id AE7CC28D56 for ; Tue, 24 Apr 2018 10:04:04 +0000 (UTC) Received: from lists.ozlabs.org (lists.ozlabs.org [IPv6:2401:3900:2:1::3]) by lists.ozlabs.org (Postfix) with ESMTP id 40Vf741QdMzF1sD for ; Tue, 24 Apr 2018 20:04:00 +1000 (AEST) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=mellanox.com Authentication-Results: lists.ozlabs.org; dkim=fail reason="signature verification failed" (1024-bit key; unprotected) header.d=Mellanox.com header.i=@Mellanox.com header.b="FWseTHMa"; dkim-atps=neutral X-Original-To: linux-mlxsw@lists.ozlabs.org Delivered-To: linux-mlxsw@lists.ozlabs.org Authentication-Results: lists.ozlabs.org; spf=pass (mailfrom) smtp.mailfrom=mellanox.com (client-ip=40.107.1.47; helo=eur02-he1-obe.outbound.protection.outlook.com; envelope-from=petrm@mellanox.com; receiver=) Authentication-Results: lists.ozlabs.org; dmarc=pass (p=none dis=none) header.from=mellanox.com Authentication-Results: lists.ozlabs.org; dkim=pass (1024-bit key; unprotected) header.d=Mellanox.com header.i=@Mellanox.com header.b="FWseTHMa"; dkim-atps=neutral Received: from EUR02-HE1-obe.outbound.protection.outlook.com (mail-eopbgr10047.outbound.protection.outlook.com [40.107.1.47]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-SHA384 (256/256 bits)) (No client certificate requested) by lists.ozlabs.org (Postfix) with ESMTPS id 40Vf6s0DzCzF1RV for ; Tue, 24 Apr 2018 20:03:47 +1000 (AEST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=Mellanox.com; s=selector1; h=From:Date:Subject:Message-ID:Content-Type:MIME-Version; bh=k+jhmfbkYP6HxjgMv649Mrg1IqqafVbtlaibG8DHEEA=; b=FWseTHMatvv/5mGDzB0NIqzHLTz3AYDQs+m0Q1TQYeJC4RBchOdVU+9Z0Aqw3rvF9umOWZU1eCH6AZYGl5//j3jjoWHcWA4xvwrkRZZAkInPu8FBY2RXF6nauLIvYSpLKWj5ppc9A0L+GjdH6x4LMQFeXQTZVOLZH+3sVWP5Cqc= Authentication-Results: spf=none (sender IP is ) smtp.mailfrom=petrm@mellanox.com; Received: from dev-r-vrt-156.mtr.labs.mlnx (37.142.13.130) by VI1PR05MB4190.eurprd05.prod.outlook.com (2603:10a6:803:4e::16) with Microsoft SMTP Server (version=TLS1_2, cipher=TLS_ECDHE_RSA_WITH_AES_256_CBC_SHA384_P256) id 15.20.696.15; Tue, 24 Apr 2018 10:03:36 +0000 From: Petr Machata To: Ido Schimmel Subject: Re: [PATCH net-next internal] selftests: forwarding: Allow running specific tests References: <20180424090059.23930-1-idosch@mellanox.com> Date: Tue, 24 Apr 2018 13:03:17 +0300 In-Reply-To: (Petr Machata's message of "Tue, 24 Apr 2018 12:29:11 +0300") Message-ID: User-Agent: Gnus/5.13 (Gnus v5.13) Emacs/24.5 (gnu/linux) MIME-Version: 1.0 X-Originating-IP: [37.142.13.130] X-ClientProxiedBy: VI1PR08CA0095.eurprd08.prod.outlook.com (2603:10a6:800:d3::21) To VI1PR05MB4190.eurprd05.prod.outlook.com (2603:10a6:803:4e::16) X-MS-PublicTrafficType: Email X-MS-Office365-Filtering-HT: Tenant X-Microsoft-Antispam: UriScan:; BCL:0; PCL:0; RULEID:(7020095)(4652020)(48565401081)(5600026)(2017052603328)(7153060)(7193020); SRVR:VI1PR05MB4190; X-Microsoft-Exchange-Diagnostics: 1; VI1PR05MB4190; 3:tPm4NtqUzV/gtLYQ3iKycAy3dBqcyt3ZPRh+3phfulNE9Xy/nXyDrG5JG3xVu/e378VVylfRlJyvPJgYKtB5mrYJBRUaGOl30upug9FFUe9Uqqu5PAgUg2queoHuNxh8nDQhvXqEf3tIw418dL9DsL86W8cPLCBcgzpSF65fgtX19UgY5wQnOl9yS76jLgwRIUOfA8CebzD360t0CgNEngdUX0rlcbTL8sEVP/yxYHgnzHRgx1hkhLwOzok/psw9; 25:Kk9ijhrHqK70R0GQ3bkKuhRnR+HPdOd7Vt3n9mYaQyTaZcoJhptFodsxBI5kQkyHpBp1cj5MkFuZzp7g7S88hf6YQ4rKxX3xFEjHIUz0gu4BnnbgvElj+35sWe8y1Z+YaSOBJeH8cWvUHEbcfaBR8qM/jcEkxsnr5D6ZMVKRPGxNR2v6fH33Rq+K3dJBMZuug+UztfSTlIEQPNk4/GKVVlhqfTWKkGoNNxntMeTm+mvC6eEGRltwkcu0Bo/UBA5+yTyWxPSQcaxtBm/KnVzjL+/+N2a6IWiLF8cCiEwJk+QSHRda9YDRq+Q6mXSWH49CWTl7+RKL2yE4205bNJBK5A==; 31:4/0r2IsFCxlT/NggrwGmepU3TdLuIyBJ8tdg3HedFbUAwFV937ndieKkjgI9a+Cd3pfOgwEnB7kvf7/Oi05/NyYlg+/mW/9Sd+iQsUeGB3PV1qgUeWIfGTajGSSCOjsmYMGoBJ2AssLaEq+RAjtRDLDzwhRIfPIQVv2BBqx4n3IVw+JkDaMoYdKXL05bUpvGiGkMXqgu1qlYaX9xVIeGGGvlfhkeeB3bvL11L0wEeeE= X-MS-TrafficTypeDiagnostic: VI1PR05MB4190: X-Microsoft-Exchange-Diagnostics: 1; VI1PR05MB4190; 20:VCmwi7OACy88DlqgThoom9HvfIy8BdRH8uiqRWCavcs0cOJ+F6oRGKURw1avqY+GBdOnhKCK7lBMSYrO4u3veE8KFKPkNbEFqsMf6MuyBQS9vgruCp4wwuHOx7nTbo/rl0Ic006v9/S6NUKHS1PCivdErTC2EuQRXCHbQNZFm8NR7L00oGJnNg4W/H9nWQu4CmT1mDqlDjNg6vGLKqePz7kU9mQn4QK1RMml28ptF81MQCO10mvkbKlXDfqRT6jzrwoN5c1GNOIS8/XXWRbiKeJcKkXDRtUSlrxCL6k/S/tcr5WbumFDxX1Zd5cWMnYZfZJOAPXKT1oRYRyaBf/xri+RjE9QZ58PDIL/EbNIfsw2vSxXnvBlCDUczSLJD0aBY2bwA21PjI97lt/B2vIfNucoG64f2iQfbN8AO+Cw+OEUWyaynuISSOKp4FpAzt7e9zH6q8cPtbtrYe7zrWIh+9lcLxd3Y3xwk7EqH8z8QY5tqXbzAspSTr1sPxJyK+ss; 4:El8RhxuzqJj7rxkW87ckzO/RcW7S4wRHJ8OmNFQyaSKS9eVd+MvYXPHn1EJImg0tC3eum6HRBP5KNFUlWvqakjVSL3Wr4dyiMMg0vSIYK1F3S1KmtqDSSv0O0aeO4uaH0K/rCY4l0YUUxpg1P5MG3UJ1Zh8zdETJs0IlnhfmD/Pl8f3OoU1F5bFRJXyC+zO3blflab3X0NjJRt3gURMxL2W5Q7WzSMw9Qj7aGyrg1rd2eGZ9ogIh32xph8rT7dpl62H67/g0pA3NPvr+Om8NEA== X-Microsoft-Antispam-PRVS: X-Exchange-Antispam-Report-Test: UriScan:; X-Exchange-Antispam-Report-CFA-Test: BCL:0; PCL:0; RULEID:(8211001083)(6040522)(2401047)(5005006)(8121501046)(93006095)(93001095)(3231232)(944501410)(52105095)(10201501046)(3002001)(6055026)(6041310)(20161123562045)(20161123564045)(201703131423095)(201702281528075)(20161123555045)(201703061421075)(201703061406153)(20161123560045)(20161123558120)(6072148)(201708071742011); SRVR:VI1PR05MB4190; BCL:0; PCL:0; RULEID:; SRVR:VI1PR05MB4190; X-Forefront-PRVS: 0652EA5565 X-Forefront-Antispam-Report: SFV:NSPM; SFS:(10009020)(366004)(39860400002)(39380400002)(396003)(376002)(346002)(199004)(189003)(51416003)(7696005)(52116002)(81156014)(8676002)(81166006)(316002)(58126008)(476003)(956004)(446003)(16586007)(11346002)(107886003)(486006)(6116002)(2906002)(97736004)(3846002)(9686003)(4326008)(6246003)(7736002)(55016002)(76176011)(5660300001)(229853002)(6862004)(8936002)(50466002)(47776003)(68736007)(53936002)(6636002)(66066001)(6666003)(105586002)(26005)(478600001)(16526019)(25786009)(6506007)(86362001)(106356001)(386003)(48376002)(305945005); DIR:OUT; SFP:1101; SCL:1; SRVR:VI1PR05MB4190; H:dev-r-vrt-156.mtr.labs.mlnx; FPR:; SPF:None; LANG:en; PTR:InfoNoRecords; A:1; MX:1; Received-SPF: None (protection.outlook.com: mellanox.com does not designate permitted sender hosts) X-Microsoft-Exchange-Diagnostics: =?us-ascii?Q?1; VI1PR05MB4190; 23:ezsBOv21of3Li1+t+wQ0g1Sta5beoSfoF7pmd0Qv7?= =?us-ascii?Q?SVlLQ3Ga1doFlHUWRwP70TaosxczPb8gElrZ09cN/1oLOOsHdOSgbUZvNfVL?= =?us-ascii?Q?d+0YqOdIKEGQKOIu+N9j+h+SA47Cq8NRAgmWC0RTo8OJCcvqQJsERYazopHz?= =?us-ascii?Q?TLXbiG/ymeEhvL8X1BlcB6vT53aIAJES7JCNNneDZmKuBkdUrDW/cFHas3xx?= =?us-ascii?Q?LbnFwTurD95EGC7titS4LGGoK8gSu8a3vDwmzTDiUZcRF9qZm43zAEH2+6xZ?= =?us-ascii?Q?CvZyrFzjG/QQmrFcr9F6yW9pwx39dUAb40vgpUx+gX8LRwDRzNTigidZacCL?= =?us-ascii?Q?YKx2bg1nVB6k8COYGRHjAoDi5+AyWRTHx2VkhvYUneAcQ55S9xRHPLoSSbH2?= =?us-ascii?Q?UhCVI5zqc++lzSmOYr/esx72UiuWRp5sqkKFTOZwwxDu8DGqCbqJ0V27cwSU?= =?us-ascii?Q?XtbGk0zMzokvK9gcZSgCdGzwL5yr0+Q6K8p+a3MfAhqCnOe9snXgwFhPlzG/?= =?us-ascii?Q?fPoMQ6mE1SXJZHKcRapqAr2KxGlEVkmxQlh2Ysp0No85+N5DiOR7KTCNnm/4?= =?us-ascii?Q?oa16bFN/jwymNWDrVBwqVH7omaLVm1InkLQhDJe24lVjyKAN9I1lBGUxKfBK?= =?us-ascii?Q?b28rTAPE+LZsHgRw6yFsBWDh6YY9upvE7gv5EGoiL6KTes/7OX8x61Y1EQQi?= =?us-ascii?Q?5ecMXMmrkEoqzfZLo0UySFZGG46xZsyeZRo2as5Ht1H77L1AXakloJ6FpWQ1?= =?us-ascii?Q?NNs61oO5WN0DWxNwT6fEzL3kcs7n9NdaPTZI9tY7MtqvdlVwH+EnN3NKSqPo?= =?us-ascii?Q?kxB/KAZnz5qZPBYqKfW1B0HG9yu8xBe5jOgx2xz7le9e3UCfuGCIYt667T25?= =?us-ascii?Q?pJYHRNuQ41LkbO1D/ga60UnVK5k4JmDa5HvcSVVCO3xnuTfeqNCsmcYpnFCj?= =?us-ascii?Q?gTpfb18rf6LT/X+Vd9UCuRFZLk8R4FIIvxthavBfrO8AJbTMlv2L4jZ0mt1F?= =?us-ascii?Q?pmPnSpLpTV5gvFHHBzFVVEVFfBCsBmHiAaL962wtknkaKgFVmqamc0YHoUcE?= =?us-ascii?Q?cqI0KwJfgbcPaEfSfye3XmZD2BRPBAraTuxcLu5GJuwgzvlX1mQmEe0vmiNC?= =?us-ascii?Q?tUsHl3cihFr1W+kl2TdPbSytToS/LnKXHKY6Fot75W0C1NsOtejWM5UT2xgy?= =?us-ascii?Q?gP0fvj4OtxBwMXmWVNAzBcYubvg7ZW/7OpjUt6S9YvxhFf6F+c2lABEXA=3D?= =?us-ascii?Q?=3D?= X-Microsoft-Antispam-Message-Info: w9HfSUAqfu5t9GN75EeU/I9+yFJamftNSF6kUFskrFjsh3ojBreU02F0ss2pAurSlBglZVla0gJG6G31RpmX+RnPxCnyGIyxLTWVswHXWatsoSIxKUU+kdj6J1rqVsEpZxZTzck8YTPbfij9DjtFHGC3EmWGPhTYWEMxudz/UQoDSa+eC5CIQsULw9iu96yj X-Microsoft-Exchange-Diagnostics: 1; VI1PR05MB4190; 6:2GuPz4nab1pPzrUZhpQqIBeRYZ8llUcFQ/sb+5q04mOGlpirIu9SlHwzJ2sbg30FHRo1XlfjLV1oqiko340BSdcTOF1J/yqq8v8m2Zb5CCwfuNqLcEcKagJP1Xodn0NY3JACVIey80/kjyYvttdvVPluYYlsqab/tqPp6zYC5Nwqkydy3+w8nOYpZ1UvPDwKERWOhQ+phFzEz2g+CSgwxqdeF/9QmAn9hNAkxfIB5q7yRI0cir6sgdHglYq6XjN47hUJ3E3VEquH1kb8I0fPciYjQcmigpl5+hFvnK6onMM3eKvb9/UxjGo/ciZdwetT6K19IYMT6clUOFuq3fdfNeSI5EfkFI/GGJ9cPOmTt1g31wlIG66RZZ7py3UmlIF0Gp4DsrCIzl+M9zQ8aZexUcd87I3sIkT5qo9/X4slSQS6XfHeSe72sBxmQm/m4cgWpC8DaVjgeTfU29YNvECxgw==; 5:8/zFvOhlnHCpBq1dQKVaUvP3F3FG3Amj0BUgZWhR7fi5HdbITeHPahyfqRyv6nIN949ROQTnePYaLm3Bq4uT1b6IvQEjaqMBm3v94uPhlMaEcuI4EhOl/LSlxt1D926yjrlppdU/NODgLYz0uUioKQ+pAnAGShmw+VpbTOPovbw=; 24:HDfQjQpJuneCDadFp3S1vYYGn/kgL8DfiqzD/yFNgbIzoOSRiMM+Sb05DiVqQIYwWvmQ2MHhi99+m+q+t8mCiV3RB90lbG2vgiCO8b8oUlQ= SpamDiagnosticOutput: 1:99 SpamDiagnosticMetadata: NSPM X-Microsoft-Exchange-Diagnostics: 1; VI1PR05MB4190; 7:59ltVg+mGpsKYbnbnpbPzmgHmZYKv61nTqDh1B4yopKPtAW6Q8+CyMBolTkq4LKAbKIboE8JcyWylqgZSIcqWzKii/olwqnU7M+CoQseEchHfzfIxuM4H7nBqP69W0kXJEnQl5qWAatVnoqdgxYejGV3zfkF09WtU9rvnAISmzyIYq5X7jH1GFEU//6NmYrwcP8hT0rBnJFpFn1AVVnYL9ogaZOGNsuSwWmS8M+RBzJxxJSq8TCakDZ05U9XuxN0 X-MS-Office365-Filtering-Correlation-Id: d57ab5c5-ae88-4fab-9b57-08d5a9caa625 X-OriginatorOrg: Mellanox.com X-MS-Exchange-CrossTenant-OriginalArrivalTime: 24 Apr 2018 10:03:36.9388 (UTC) X-MS-Exchange-CrossTenant-Network-Message-Id: d57ab5c5-ae88-4fab-9b57-08d5a9caa625 X-MS-Exchange-CrossTenant-FromEntityHeader: Hosted X-MS-Exchange-CrossTenant-Id: a652971c-7d2e-4d9b-a6a4-d149256f461b X-MS-Exchange-Transport-CrossTenantHeadersStamped: VI1PR05MB4190 X-BeenThere: linux-mlxsw@lists.ozlabs.org X-Mailman-Version: 2.1.26 Precedence: list List-Id: mlxsw driver development List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Cc: linux-internal@mellanox.com, linux-mlxsw@lists.ozlabs.org Errors-To: linux-mlxsw-bounces+patchwork-linux-mlxsw=patchwork.kernel.org@lists.ozlabs.org Sender: "Linux-mlxsw" X-Virus-Scanned: ClamAV using ClamSMTP Petr Machata writes: > Ido Schimmel writes: > >> tcflags="skip_sw" >> - gact_drop_and_ok_test >> - mirred_egress_test "redirect" >> - mirred_egress_test "mirror" >> gact_trap_test >> + tests_run > > I guess it's reasonable to assume that any ACL-capable ASIC will > actually be able to trap packets. But wait, the test also assumes that redirect is supported. Maybe do this, and just add the test to ALL_TESTS? One could also simply do this, but then listing the test in TESTS would lead to it being executed even in SW-only scenarios. tcflags="skip_sw" ALL_TESTS="$ALL_TESTS gact_trap_test" tests_run Petr diff --git a/tools/testing/selftests/net/forwarding/tc_actions.sh b/tools/testing/selftests/net/forwarding/tc_actions.sh index 3a6385e..7abd6e3 100755 --- a/tools/testing/selftests/net/forwarding/tc_actions.sh +++ b/tools/testing/selftests/net/forwarding/tc_actions.sh @@ -111,6 +111,10 @@ gact_trap_test() { RET=0 + if [ "${tcflags/skip_hw}" != "$tcflags" ]; then + return 0; + fi + tc filter add dev $swp1 ingress protocol ip pref 1 handle 101 flower \ skip_hw dst_ip 192.0.2.2 action drop tc filter add dev $swp1 ingress protocol ip pref 3 handle 103 flower \