From patchwork Tue Nov 13 06:33:06 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Arun KS X-Patchwork-Id: 10679783 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 065301759 for ; Tue, 13 Nov 2018 06:33:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id E5B90286A7 for ; Tue, 13 Nov 2018 06:33:32 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id D526528857; Tue, 13 Nov 2018 06:33:32 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 598D6286A7 for ; Tue, 13 Nov 2018 06:33:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 3D3746B027C; Tue, 13 Nov 2018 01:33:31 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 3832B6B027D; Tue, 13 Nov 2018 01:33:31 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 272FA6B027F; Tue, 13 Nov 2018 01:33:31 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by kanga.kvack.org (Postfix) with ESMTP id D82286B027C for ; Tue, 13 Nov 2018 01:33:30 -0500 (EST) Received: by mail-pf1-f197.google.com with SMTP id i22-v6so8727535pfj.1 for ; Mon, 12 Nov 2018 22:33:30 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id; bh=UKdMST+uUza5h4kPK64N2jGpYn9i+7czLJP54MU+3p8=; b=WeSO8T3lS4lQD2JxmAxl15d4ZBnUzb/cayniusyKoJ82rJeBXEfivyuvBDOZhBXBLB jRp6b1KjeEli4e3HPrO2tLbEgxnptcglcd9CD2D83UttyBnO9zarCwE47cHto32ywnd6 i7anh0BqkjprCbk/6d1ZrC0G2jW6lVSFiIrwJZLjcp2/bMKy71MqWDYXouFriWm6cLOV rg+8FJPSZMLJXE7mCFoXsjTnJRlnpfKgmwnLmCOv4EMkAn2oLr5ltnP560rESWUVqMNR x1qbr6uoqmNU9CP8CldBTXAu599m26ZV3Scbk85Eur0Y+L13W8dFjBlBRiR6XEmtdESr l/3Q== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of arunks@qualcomm.com designates 103.229.18.197 as permitted sender) smtp.mailfrom=arunks@qualcomm.com X-Gm-Message-State: AGRZ1gLsee2S6IkrSfi6VzxXCEgQcqsh3ktd3GhcdD6QreLiLt0kTlw/ Nl4vi3Nkr1l6MtGf0kuLD/SbzY8kaCzO6I+C4TqaFIRLLf6KbowUqC1R+bPTj4J0b7UlW6ILHeE qdSLHYWMg2GiowzQexGMyQIn3iaDfexgkPIrADrxDT5jh3hcD3jPkjspYGswOTb4= X-Received: by 2002:a62:8d51:: with SMTP id z78-v6mr3893393pfd.234.1542090810539; Mon, 12 Nov 2018 22:33:30 -0800 (PST) X-Google-Smtp-Source: AJdET5firpvWjMZxv7CFyoT+Lco9vJaI6ZG7o2NPof5Q1uG8qwNH9t4IRi6HbRvjWiJ/tgHDhXAb X-Received: by 2002:a62:8d51:: with SMTP id z78-v6mr3893355pfd.234.1542090809309; Mon, 12 Nov 2018 22:33:29 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1542090809; cv=none; d=google.com; s=arc-20160816; b=PjzbczN2cM7SuE2xxYvGVgu/CciUlNTEZEE/fkVIj/ltXD2XLn/THEESI41lHrtat1 SwOdBoN5p9BjMfGJ/oOvjEbBUKyroUUd/MBSaMAN4LECiTn9DB8AK5ghFBBBsq/pcv79 bAa509RxWPnFwcu3HkmOks5WNyW8AeCC5w9e61E6LsUMOa5wd6sAGLZgWhR3XD+bZBoD 4T/azIZuH3PzhLgYZx66hsHptXllwkeiG+6bSKnxbUggNeRCwl+Jlo9eX8UCCGr6C1eR UH18gMy6ykc7IxXbJnhrZavkCqp5mfrNutlubfambQwjcPYmNpPZoaloWE/FohETtFF7 kDNQ== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:cc:to:from; bh=UKdMST+uUza5h4kPK64N2jGpYn9i+7czLJP54MU+3p8=; b=qZYd8rTwN42BW8ZC7l0Jq6lyNSIsqB02leFsaIlurbMruwP26LHAd/7oMcWkFCmFkV xvQ+VOmJcaEFRG/qwH8QVRyKzbkD22DdVHl/XeWTdP6Nnzu7qwycT+LLypZVc7o8OoB5 qnTBXsW3A+2GOt49UDqkDmDxAzEjprOsJw6IqVGTxwpcmmpyIBPQTaj7QBFELvVk0rPl HEdq575+29fKriPSHc6yXODL/GcxYn4nT53TTMKreQJbznyvBsSBCIep/S/iOKZa6YSA yk1hnCXwdB+8ZAd9GTU84yIJBjyDlrbpRGfKTt4UQYGAeKONTvhg7ea74SlBZZi7hPq9 4UzQ== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of arunks@qualcomm.com designates 103.229.18.197 as permitted sender) smtp.mailfrom=arunks@qualcomm.com Received: from alexa-out-blr-01.qualcomm.com (alexa-out-blr-01.qualcomm.com. [103.229.18.197]) by mx.google.com with ESMTPS id f3-v6si20203009pld.186.2018.11.12.22.33.28 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Mon, 12 Nov 2018 22:33:29 -0800 (PST) Received-SPF: pass (google.com: domain of arunks@qualcomm.com designates 103.229.18.197 as permitted sender) client-ip=103.229.18.197; Authentication-Results: mx.google.com; spf=pass (google.com: domain of arunks@qualcomm.com designates 103.229.18.197 as permitted sender) smtp.mailfrom=arunks@qualcomm.com X-IronPort-AV: E=Sophos;i="5.54,498,1534789800"; d="scan'208";a="284439" Received: from ironmsg03-blr.qualcomm.com ([10.86.208.132]) by alexa-out-blr-01.qualcomm.com with ESMTP/TLS/AES256-SHA; 13 Nov 2018 12:03:26 +0530 X-IronPort-AV: E=McAfee;i="5900,7806,9075"; a="2020977" Received: from blr-ubuntu-104.ap.qualcomm.com (HELO blr-ubuntu-104.qualcomm.com) ([10.79.40.64]) by ironmsg03-blr.qualcomm.com with ESMTP; 13 Nov 2018 12:03:26 +0530 Received: by blr-ubuntu-104.qualcomm.com (Postfix, from userid 346745) id CA7AA269C; Tue, 13 Nov 2018 12:03:24 +0530 (IST) From: Arun KS To: Cc: keescook@chromium.org, khlebnikov@yandex-team.ru, minchan@kernel.org, getarunks@gmail.com, gregkh@linuxfoundation.org, akpm@linux-foundation.org, mhocko@kernel.org, vbabka@suse.cz, linux-kernel@vger.kernel.org, linux-mm@kvack.org, vatsa@codeaurora.org, willy@infradead.org, Arun KS Subject: [PATCH v5 0/4] mm: convert totalram_pages, totalhigh_pages and managed pages to atomic Date: Tue, 13 Nov 2018 12:03:06 +0530 Message-Id: <1542090790-21750-1-git-send-email-arunks@codeaurora.org> X-Mailer: git-send-email 1.9.1 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP This series convert totalram_pages, totalhigh_pages and zone->managed_pages to atomic variables. The patch was comiple tested on x86(x86_64_defconfig & i386_defconfig) on 4.20-rc2. And memory hotplug tested on arm64, but on an older version of kernel. totalram_pages, zone->managed_pages and totalhigh_pages updates are protected by managed_page_count_lock, but readers never care about it. Convert these variables to atomic to avoid readers potentially seeing a store tear. Main motivation was that managed_page_count_lock handling was complicating things. It was discussed in length here, https://lore.kernel.org/patchwork/patch/995739/#1181785 It seemes better to remove the lock and convert variables to atomic. With the change, preventing poteintial store-to-read tearing comes as a bonus. Changes in v5: - totalram_pgs renamed to nr_pages. https://lore.kernel.org/patchwork/patch/1011293/#1194248 Changes in v4: - Fixed kbuild test robot error. - Modified changelog. - Rebased to 4.20.-rc2 Changes in v3: - Fixed kbuild test robot errors. - Modified changelogs to be more clear. - EXPORT_SYMBOL for _totalram_pages and _totalhigh_pages. Arun KS (4): mm: reference totalram_pages and managed_pages once per function mm: convert zone->managed_pages to atomic variable mm: convert totalram_pages and totalhigh_pages variables to atomic mm: Remove managed_page_count spinlock arch/csky/mm/init.c | 4 +- arch/powerpc/platforms/pseries/cmm.c | 10 ++-- arch/s390/mm/init.c | 2 +- arch/um/kernel/mem.c | 4 +- arch/x86/kernel/cpu/microcode/core.c | 5 +- drivers/char/agp/backend.c | 4 +- drivers/gpu/drm/amd/amdkfd/kfd_crat.c | 2 +- drivers/gpu/drm/i915/i915_gem.c | 2 +- drivers/gpu/drm/i915/selftests/i915_gem_gtt.c | 4 +- drivers/hv/hv_balloon.c | 19 +++---- drivers/md/dm-bufio.c | 2 +- drivers/md/dm-crypt.c | 2 +- drivers/md/dm-integrity.c | 2 +- drivers/md/dm-stats.c | 2 +- drivers/media/platform/mtk-vpu/mtk_vpu.c | 2 +- drivers/misc/vmw_balloon.c | 2 +- drivers/parisc/ccio-dma.c | 4 +- drivers/parisc/sba_iommu.c | 4 +- drivers/staging/android/ion/ion_system_heap.c | 2 +- drivers/xen/xen-selfballoon.c | 6 +-- fs/ceph/super.h | 2 +- fs/file_table.c | 7 +-- fs/fuse/inode.c | 2 +- fs/nfs/write.c | 2 +- fs/nfsd/nfscache.c | 2 +- fs/ntfs/malloc.h | 2 +- fs/proc/base.c | 2 +- include/linux/highmem.h | 28 ++++++++++- include/linux/mm.h | 27 +++++++++- include/linux/mmzone.h | 15 +++--- include/linux/swap.h | 1 - kernel/fork.c | 5 +- kernel/kexec_core.c | 5 +- kernel/power/snapshot.c | 2 +- lib/show_mem.c | 2 +- mm/highmem.c | 5 +- mm/huge_memory.c | 2 +- mm/kasan/quarantine.c | 2 +- mm/memblock.c | 6 +-- mm/mm_init.c | 2 +- mm/oom_kill.c | 2 +- mm/page_alloc.c | 72 +++++++++++++-------------- mm/shmem.c | 7 +-- mm/slab.c | 2 +- mm/swap.c | 2 +- mm/util.c | 2 +- mm/vmalloc.c | 4 +- mm/vmstat.c | 4 +- mm/workingset.c | 2 +- mm/zswap.c | 4 +- net/dccp/proto.c | 7 +-- net/decnet/dn_route.c | 2 +- net/ipv4/tcp_metrics.c | 2 +- net/netfilter/nf_conntrack_core.c | 7 +-- net/netfilter/xt_hashlimit.c | 5 +- net/sctp/protocol.c | 7 +-- security/integrity/ima/ima_kexec.c | 2 +- 57 files changed, 196 insertions(+), 142 deletions(-)