From patchwork Sat Nov 16 03:14:59 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alex Shi X-Patchwork-Id: 11247431 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 32BA21393 for ; Sat, 16 Nov 2019 03:15:17 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 051D92073B for ; Sat, 16 Nov 2019 03:15:17 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 051D92073B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2060A6B0003; Fri, 15 Nov 2019 22:15:16 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 1B6B06B0006; Fri, 15 Nov 2019 22:15:16 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 0CD256B0007; Fri, 15 Nov 2019 22:15:16 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0100.hostedemail.com [216.40.44.100]) by kanga.kvack.org (Postfix) with ESMTP id EB2CD6B0003 for ; Fri, 15 Nov 2019 22:15:15 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with SMTP id 6E6DD4DA5 for ; Sat, 16 Nov 2019 03:15:15 +0000 (UTC) X-FDA: 76160674590.10.steam13_103c834985334 X-Spam-Summary: 2,0,0,f4f0d4a6d96e9fe5,d41d8cd98f00b204,alex.shi@linux.alibaba.com,:alex.shi@linux.alibaba.com:cgroups@vger.kernel.org:linux-kernel@vger.kernel.org::akpm@linux-foundation.org:mgorman@techsingularity.net:tj@kernel.org:hughd@google.com:khlebnikov@yandex-team.ru:daniel.m.jordan@oracle.com:yang.shi@linux.alibaba.com:willy@infradead.org,RULES_HIT:41:69:152:355:379:541:967:968:973:988:989:1260:1261:1277:1311:1313:1314:1345:1381:1437:1515:1516:1518:1534:1542:1593:1594:1711:1730:1747:1777:1792:1801:2393:2525:2559:2563:2682:2685:2691:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3353:3622:3865:3866:3867:3868:3871:3872:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4362:4605:5007:6119:6261:6737:7903:9025:10004:10400:11657:11658:11914:12043:12048:12296:12297:12895:13071:13894:14040:14096:14097:14180:14181:14394:14659:14721:14915:21060:21080:21451:21627:21795:21809:30051:30054:30056:30070,0,RBL:115.124.30.44:@linux.alibaba.com:.lbl8.mailshe ll.net-6 X-HE-Tag: steam13_103c834985334 X-Filterd-Recvd-Size: 3872 Received: from out30-44.freemail.mail.aliyun.com (out30-44.freemail.mail.aliyun.com [115.124.30.44]) by imf21.hostedemail.com (Postfix) with ESMTP for ; Sat, 16 Nov 2019 03:15:11 +0000 (UTC) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R201e4;CH=green;DM=||false|;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e04420;MF=alex.shi@linux.alibaba.com;NM=1;PH=DS;RN=12;SR=0;TI=SMTPD_---0TiBwoht_1573874108; Received: from localhost(mailfrom:alex.shi@linux.alibaba.com fp:SMTPD_---0TiBwoht_1573874108) by smtp.aliyun-inc.com(127.0.0.1); Sat, 16 Nov 2019 11:15:08 +0800 From: Alex Shi To: alex.shi@linux.alibaba.com, cgroups@vger.kernel.org, linux-kernel@vger.kernel.org, linux-mm@kvack.org, akpm@linux-foundation.org, mgorman@techsingularity.net, tj@kernel.org, hughd@google.com, khlebnikov@yandex-team.ru, daniel.m.jordan@oracle.com, yang.shi@linux.alibaba.com, willy@infradead.org Subject: [PATCH v3 0/8] per lruvec lru_lock for memcg Date: Sat, 16 Nov 2019 11:14:59 +0800 Message-Id: <1573874106-23802-1-git-send-email-alex.shi@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi all, This patchset move lru_lock into lruvec, give a lru_lock for each of lruvec, thus bring a lru_lock for each of memcg per node. According to Daniel Jordan's suggestion, I run 64 'dd' with on 32 containers on my 2s* 8 core * HT box with the modefied case: https://git.kernel.org/pub/scm/linux/kernel/git/wfg/vm-scalability.git/tree/case-lru-file-readtwice With this change above lru_lock censitive testing improved 17% with multiple containers scenario. And no performance lose w/o mem_cgroup. Thanks Hugh Dickins and Konstantin Khlebnikov, they both bring the same idea 7 years ago. Now I believe considering my testing result, and google internal using fact. This feather is clearly benefit multi-container user. So I like to introduce it here. v3: rebase on linux-next, and fold the relock fix patch into introduceing patch v2: bypass a performance regression bug and fix some function issues v1: initial version, aim testing show 5% performance incrase Alex Shi (7): mm/lru: add per lruvec lock for memcg mm/lruvec: add irqsave flags into lruvec struct mm/lru: replace pgdat lru_lock with lruvec lock mm/lru: only change the lru_lock iff page's lruvec is different mm/pgdat: remove pgdat lru_lock mm/lru: likely enhancement mm/lru: revise the comments of lru_lock Documentation/admin-guide/cgroup-v1/memcg_test.rst | 15 +---- Documentation/admin-guide/cgroup-v1/memory.rst | 6 +- Documentation/trace/events-kmem.rst | 2 +- Documentation/vm/unevictable-lru.rst | 22 +++---- include/linux/memcontrol.h | 67 +++++++++++++++++++ include/linux/mm_types.h | 2 +- include/linux/mmzone.h | 7 +- mm/compaction.c | 62 +++++++++++------ mm/filemap.c | 4 +- mm/huge_memory.c | 16 ++--- mm/memcontrol.c | 64 ++++++++++++++---- mm/mlock.c | 27 ++++---- mm/mmzone.c | 1 + mm/page_alloc.c | 1 - mm/page_idle.c | 5 +- mm/rmap.c | 2 +- mm/swap.c | 77 +++++++++------------- mm/vmscan.c | 74 +++++++++++---------- 18 files changed, 277 insertions(+), 177 deletions(-)