From patchwork Wed Apr 29 03:26:33 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Joonsoo Kim X-Patchwork-Id: 11515943 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 146E092C for ; Wed, 29 Apr 2020 03:27:04 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BA2722082E for ; Wed, 29 Apr 2020 03:27:03 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="lSUOxeDY" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BA2722082E Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=gmail.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id E83CF8E0005; Tue, 28 Apr 2020 23:27:02 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id E59C58E0001; Tue, 28 Apr 2020 23:27:02 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id D70A48E0005; Tue, 28 Apr 2020 23:27:02 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0210.hostedemail.com [216.40.44.210]) by kanga.kvack.org (Postfix) with ESMTP id C0BC38E0001 for ; Tue, 28 Apr 2020 23:27:02 -0400 (EDT) Received: from smtpin05.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 7A0278248047 for ; Wed, 29 Apr 2020 03:27:02 +0000 (UTC) X-FDA: 76759456284.05.lead96_77a1373055b60 X-Spam-Summary: 2,0,0,6046bd5c34cb009f,d41d8cd98f00b204,js1304@gmail.com,,RULES_HIT:2:41:152:355:379:541:800:960:967:973:988:989:1260:1277:1311:1313:1314:1345:1437:1515:1516:1518:1535:1593:1594:1605:1606:1730:1747:1777:1792:1801:2194:2198:2199:2200:2393:2525:2559:2564:2682:2685:2693:2731:2859:2902:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3865:3866:3867:3868:3870:3871:3872:3873:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4119:4250:4321:4362:4605:5007:6261:6653:6742:7576:7875:7903:8957:8985:9025:9413:10004:11026:11638:11658:11914:12043:12296:12297:12517:12519:12555:12679:12895:12986:13053:13141:13153:13160:13161:13180:13228:13229:13230:13548:13846:13894:14096:14097:14394:14659:21080:21324:21325:21433:21444:21451:21627:21666:21749:21819:21939:21990:30029:30054:30070:30079,0,RBL:209.85.216.68:@gmail.com:.lbl8.mailshell.net-62.18.0.100 66.100.201.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNS BL:neutr X-HE-Tag: lead96_77a1373055b60 X-Filterd-Recvd-Size: 8583 Received: from mail-pj1-f68.google.com (mail-pj1-f68.google.com [209.85.216.68]) by imf26.hostedemail.com (Postfix) with ESMTP for ; Wed, 29 Apr 2020 03:27:01 +0000 (UTC) Received: by mail-pj1-f68.google.com with SMTP id mq3so218247pjb.1 for ; Tue, 28 Apr 2020 20:27:01 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=pxvKdEsbzWLexhjczXLGWAsQ8wUE/7iE8HqIboMrVpI=; b=lSUOxeDYze8V31PTz+egnzCkEh33P7lSJWrg5PHVpeYJ6FbWnBHiqx1iV5B5gKH4mc mHDkgD2O1N6p2K+umxFLEmCUSx4lNQgF2ynH2aZ1IabsHKyM0KjhdKkxGc1Zo3OkUKi9 pCBPxa1CoUm4ZFexb0FB6+ftPSqZiyaTpZMt4VlJOrjaVcSL5/B7tTibVgxy+3a0eaus uXP+/ICx3qNHizcr+fs2nwlSJuoRsGLX8HqkHqkHSIS0qQubC1t+0cALqtqW+36spGJC CYDDyuEzGiKpZqUsUjHymldoISiDajkx+RcdvKSmbCLik6iSeWmTl9smpTF7XnVU9A2E nBzQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=pxvKdEsbzWLexhjczXLGWAsQ8wUE/7iE8HqIboMrVpI=; b=h3L3JYgWliZSzH0fHNMCwYn4evTMFnZK5621cusGCX5ytVh2p3wNF6C7Ao/IL0ntzK 8vqiVzebC4++lPLBtTMi/vh9AFJQFQeHSXwl1ZVG2feZLISqbgqJduTVLvNrPlkm9qdG fYL4Tk6/YJfh8JoIFxj2Uh92i4tSE7ROJmZ4t/TeCzwfnbG+ixhKwh8+AR0sHiWvgmYX YMRfALrycJM2d/QtjceFKWUsfqStEKmvkaQWzEEPzm/Nb1xVBuaqFEenvWwBX/T4vo6Z fSFMBf25TcwMArABwetL+E9XEz2uwsHNdV72MCyLPGQnvZb0v7KT+YAlpEubSCAVrpeV KDFg== X-Gm-Message-State: AGi0PuYmQUJZ+cGRpymDieezmwL32Fry0DeVlLHIakqh+NywIXZkwRGD rPsJPj7bKQEKh/5vdn3RwC0= X-Google-Smtp-Source: APiQypJKSgZnczB4t88QIC6U5iAGRia6aXAWJjn7eL62QB9d/UDUX60LObRanrnaMVPF3mgsDQbpWQ== X-Received: by 2002:a17:90a:a888:: with SMTP id h8mr679701pjq.174.1588130820755; Tue, 28 Apr 2020 20:27:00 -0700 (PDT) Received: from localhost.localdomain ([114.206.198.176]) by smtp.gmail.com with ESMTPSA id q11sm9559796pfl.97.2020.04.28.20.26.56 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 28 Apr 2020 20:27:00 -0700 (PDT) From: js1304@gmail.com X-Google-Original-From: iamjoonsoo.kim@lge.com To: Andrew Morton Cc: linux-mm@kvack.org, linux-kernel@vger.kernel.org, Vlastimil Babka , Laura Abbott , "Aneesh Kumar K . V" , Mel Gorman , Michal Hocko , Johannes Weiner , Roman Gushchin , Minchan Kim , Rik van Riel , Christian Koenig , Huang Rui , Eric Biederman , "Rafael J . Wysocki" , Pavel Machek , kernel-team@lge.com, Christoph Hellwig , Joonsoo Kim Subject: [PATCH v2 00/10] change the implementation of the PageHighMem() Date: Wed, 29 Apr 2020 12:26:33 +0900 Message-Id: <1588130803-20527-1-git-send-email-iamjoonsoo.kim@lge.com> X-Mailer: git-send-email 2.7.4 MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: From: Joonsoo Kim Changes on v2 - add "acked-by", "reviewed-by" tags - replace PageHighMem() with use open-code, instead of using new PageHighMemZone() macro. Related file is "include/linux/migrate.h" Hello, This patchset separates two use cases of PageHighMem() by introducing PageHighMemZone() macro. And, it changes the implementation of PageHighMem() to reflect the actual meaning of this macro. This patchset is a preparation step for the patchset, "mm/cma: manage the memory of the CMA area by using the ZONE_MOVABLE" [1]. PageHighMem() is used for two different cases. One is to check if there is a direct mapping for this page or not. The other is to check the zone of this page, that is, weather it is the highmem type zone or not. Until now, both the cases are the perfectly same thing. So, implementation of the PageHighMem() uses the one case that checks if the zone of the page is the highmem type zone or not. "#define PageHighMem(__p) is_highmem_idx(page_zonenum(__p))" ZONE_MOVABLE is special. It is considered as normal type zone on !CONFIG_HIGHMEM, but, it is considered as highmem type zone on CONFIG_HIGHMEM. Let's focus on later case. In later case, all pages on the ZONE_MOVABLE has no direct mapping until now. However, following patchset "mm/cma: manage the memory of the CMA area by using the ZONE_MOVABLE" , which is once merged and reverted, will be tried again and will break this assumption that all pages on the ZONE_MOVABLE has no direct mapping. Hence, the ZONE_MOVABLE which is considered as highmem type zone could have the both types of pages, direct mapped and not. Since the ZONE_MOVABLE could have both type of pages, __GFP_HIGHMEM is still required to allocate the memory from it. And, we conservatively need to consider the ZONE_MOVABLE as highmem type zone. Even in this situation, PageHighMem() for the pages on the ZONE_MOVABLE when it is called for checking the direct mapping should return correct result. Current implementation of PageHighMem() just returns TRUE if the zone of the page is on a highmem type zone. So, it could be wrong if the page on the MOVABLE_ZONE is actually direct mapped. To solve this potential problem, this patch introduces a new PageHighMemZone() macro. In following patches, two use cases of PageHighMem() are separated by calling proper macro, PageHighMem() and PageHighMemZone(). Then, implementation of PageHighMem() will be changed as just checking if the direct mapping exists or not, regardless of the zone of the page. Note that there are some rules to determine the proper macro. 1. If PageHighMem() is called for checking if the direct mapping exists or not, use PageHighMem(). 2. If PageHighMem() is used to predict the previous gfp_flags for this page, use PageHighMemZone(). The zone of the page is related to the gfp_flags. 3. If purpose of calling PageHighMem() is to count highmem page and to interact with the system by using this count, use PageHighMemZone(). This counter is usually used to calculate the available memory for an kernel allocation and pages on the highmem zone cannot be available for an kernel allocation. 4. Otherwise, use PageHighMemZone(). It's safe since it's implementation is just copy of the previous PageHighMem() implementation and won't be changed. My final plan is to change the name, PageHighMem() to PageNoDirectMapped() or something else in order to represent proper meaning. This patchset is based on next-20200428 and you can find the full patchset on the following link. https://github.com/JoonsooKim/linux/tree/page_highmem-cleanup-v2.00-next-20200428 Thanks. [1]: https://lore.kernel.org/linux-mm/1512114786-5085-1-git-send-email-iamjoonsoo.kim@lge.com Joonsoo Kim (10): mm/page-flags: introduce PageHighMemZone() drm/ttm: separate PageHighMem() and PageHighMemZone() use case kexec: separate PageHighMem() and PageHighMemZone() use case power: separate PageHighMem() and PageHighMemZone() use case mm/gup: separate PageHighMem() and PageHighMemZone() use case mm/hugetlb: separate PageHighMem() and PageHighMemZone() use case mm: separate PageHighMem() and PageHighMemZone() use case mm/page_alloc: correct the use of is_highmem_idx() mm/migrate: replace PageHighMem() with open-code mm/page-flags: change the implementation of the PageHighMem() drivers/gpu/drm/ttm/ttm_memory.c | 4 ++-- drivers/gpu/drm/ttm/ttm_page_alloc.c | 2 +- drivers/gpu/drm/ttm/ttm_page_alloc_dma.c | 2 +- drivers/gpu/drm/ttm/ttm_tt.c | 2 +- include/linux/migrate.h | 4 +++- include/linux/page-flags.h | 10 +++++++++- kernel/kexec_core.c | 2 +- kernel/power/snapshot.c | 12 ++++++------ mm/gup.c | 2 +- mm/hugetlb.c | 2 +- mm/memory_hotplug.c | 2 +- mm/page_alloc.c | 4 ++-- 12 files changed, 29 insertions(+), 19 deletions(-)