From patchwork Mon Jan 25 02:58:48 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Anshuman Khandual X-Patchwork-Id: 12042869 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 7A7D8C433E0 for ; Mon, 25 Jan 2021 02:58:48 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id DE2AD2085B for ; Mon, 25 Jan 2021 02:58:47 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org DE2AD2085B Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=arm.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 134056B0005; Sun, 24 Jan 2021 21:58:47 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 0E5156B0007; Sun, 24 Jan 2021 21:58:47 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id F3BD06B0008; Sun, 24 Jan 2021 21:58:46 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0074.hostedemail.com [216.40.44.74]) by kanga.kvack.org (Postfix) with ESMTP id DA7486B0005 for ; Sun, 24 Jan 2021 21:58:46 -0500 (EST) Received: from smtpin19.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 926163626 for ; Mon, 25 Jan 2021 02:58:46 +0000 (UTC) X-FDA: 77742789852.19.box98_5a0aafd27582 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin19.hostedemail.com (Postfix) with ESMTP id 711481AD1B5 for ; Mon, 25 Jan 2021 02:58:46 +0000 (UTC) X-HE-Tag: box98_5a0aafd27582 X-Filterd-Recvd-Size: 5809 Received: from foss.arm.com (foss.arm.com [217.140.110.172]) by imf35.hostedemail.com (Postfix) with ESMTP for ; Mon, 25 Jan 2021 02:58:45 +0000 (UTC) Received: from usa-sjc-imap-foss1.foss.arm.com (unknown [10.121.207.14]) by usa-sjc-mx-foss1.foss.arm.com (Postfix) with ESMTP id 00158ED1; Sun, 24 Jan 2021 18:58:44 -0800 (PST) Received: from p8cg001049571a15.arm.com (unknown [10.163.91.27]) by usa-sjc-imap-foss1.foss.arm.com (Postfix) with ESMTPA id 1FCE83F66E; Sun, 24 Jan 2021 18:58:39 -0800 (PST) From: Anshuman Khandual To: linux-mm@kvack.org, akpm@linux-foundation.org, hca@linux.ibm.com, catalin.marinas@arm.com Cc: Anshuman Khandual , Oscar Salvador , Vasily Gorbik , Will Deacon , Ard Biesheuvel , Mark Rutland , David Hildenbrand , linux-arm-kernel@lists.infradead.org, linux-s390@vger.kernel.org, linux-kernel@vger.kernel.org Subject: [PATCH V4 0/4] mm/memory_hotplug: Pre-validate the address range with platform Date: Mon, 25 Jan 2021 08:28:48 +0530 Message-Id: <1611543532-18698-1-git-send-email-anshuman.khandual@arm.com> X-Mailer: git-send-email 2.7.4 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This series adds a mechanism allowing platforms to weigh in and prevalidate incoming address range before proceeding further with the memory hotplug. This helps prevent potential platform errors for the given address range, down the hotplug call chain, which inevitably fails the hotplug itself. This mechanism was suggested by David Hildenbrand during another discussion with respect to a memory hotplug fix on arm64 platform. https://lore.kernel.org/linux-arm-kernel/1600332402-30123-1-git-send-email-anshuman.khandual@arm.com/ This mechanism focuses on the addressibility aspect and not [sub] section alignment aspect. Hence check_hotplug_memory_range() and check_pfn_span() have been left unchanged. Wondering if all these can still be unified in an expanded memhp_range_allowed() check, that can be called from multiple memory hot add and remove paths. This series applies on v5.11-rc5 and has been tested on arm64. But only build tested on s390. Changes in V4: - Moved arch_get_mappable_range() earlier in vmem_add_mapping() on s390 - Moved mhp_range_allowed() back in pagemap_range() as in V2 series - Changed max_phys as (1ULL << MAX_PHYSMEM_BITS) - 1 in mhp_get_pluggable_range() - Renamed all memhp instances into mhp - Dropped the RFC tag from the last patch Changes in V3: https://lore.kernel.org/linux-mm/1610975582-12646-1-git-send-email-anshuman.khandual@arm.com/ - Updated the commit message in [PATCH 1/3] - Replaced 1 with 'true' and 0 with 'false' in memhp_range_allowed() - Updated memhp_range.end as VMEM_MAX_PHYS - 1 and updated vmem_add_mapping() on s390 - Changed memhp_range_allowed() behaviour in __add_pages() - Updated __add_pages() to return E2BIG when memhp_range_allowed() fails for non-linear mapping based requests Changes in V2: https://lore.kernel.org/linux-mm/1608218912-28932-1-git-send-email-anshuman.khandual@arm.com/ - Changed s390 version per Heiko and updated the commit message - Called memhp_range_allowed() only for arch_add_memory() in pagemap_range() - Exported the symbol memhp_get_pluggable_range() Changes in V1: https://lore.kernel.org/linux-mm/1607400978-31595-1-git-send-email-anshuman.khandual@arm.com/ - Fixed build problems with (MEMORY_HOTPLUG & !MEMORY_HOTREMOVE) - Added missing prototype for arch_get_mappable_range() - Added VM_BUG_ON() check for memhp_range_allowed() in arch_add_memory() per David Changes in RFC V2: https://lore.kernel.org/linux-mm/1606706992-26656-1-git-send-email-anshuman.khandual@arm.com/ Incorporated all review feedbacks from David. - Added additional range check in __segment_load() on s390 which was lost - Changed is_private init in pagemap_range() - Moved the framework into mm/memory_hotplug.c - Made arch_get_addressable_range() a __weak function - Renamed arch_get_addressable_range() as arch_get_mappable_range() - Callback arch_get_mappable_range() only handles range requiring linear mapping - Merged multiple memhp_range_allowed() checks in register_memory_resource() - Replaced WARN() with pr_warn() in memhp_range_allowed() - Replaced error return code ERANGE with E2BIG Changes in RFC V1: https://lore.kernel.org/linux-mm/1606098529-7907-1-git-send-email-anshuman.khandual@arm.com/ Cc: Oscar Salvador Cc: Heiko Carstens Cc: Vasily Gorbik Cc: Catalin Marinas Cc: Will Deacon Cc: Ard Biesheuvel Cc: Mark Rutland Cc: David Hildenbrand Cc: Andrew Morton Cc: linux-arm-kernel@lists.infradead.org Cc: linux-s390@vger.kernel.org Cc: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org Anshuman Khandual (3): mm/memory_hotplug: Prevalidate the address range being added with platform arm64/mm: Define arch_get_mappable_range() s390/mm: Define arch_get_mappable_range() David Hildenbrand (1): virtio-mem: check against mhp_get_pluggable_range() which memory we can hotplug arch/arm64/mm/mmu.c | 15 +++---- arch/s390/mm/init.c | 1 + arch/s390/mm/vmem.c | 14 +++++- drivers/virtio/virtio_mem.c | 40 +++++++++++------ include/linux/memory_hotplug.h | 10 +++++ mm/memory_hotplug.c | 78 +++++++++++++++++++++++++--------- mm/memremap.c | 6 ++- 7 files changed, 122 insertions(+), 42 deletions(-)