From patchwork Tue Mar 9 15:25:08 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Xunlei Pang X-Patchwork-Id: 12125811 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS,UNPARSEABLE_RELAY,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F19B9C433E0 for ; Tue, 9 Mar 2021 15:25:28 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6DF1365253 for ; Tue, 9 Mar 2021 15:25:28 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6DF1365253 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=linux.alibaba.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id DCEEF8D00FE; Tue, 9 Mar 2021 10:25:27 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id D57DE8D007F; Tue, 9 Mar 2021 10:25:27 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BD1768D00FE; Tue, 9 Mar 2021 10:25:27 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0215.hostedemail.com [216.40.44.215]) by kanga.kvack.org (Postfix) with ESMTP id 9C6B88D007F for ; Tue, 9 Mar 2021 10:25:27 -0500 (EST) Received: from smtpin07.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with ESMTP id 5443A824999B for ; Tue, 9 Mar 2021 15:25:27 +0000 (UTC) X-FDA: 77900709894.07.DEB88AF Received: from out30-132.freemail.mail.aliyun.com (out30-132.freemail.mail.aliyun.com [115.124.30.132]) by imf25.hostedemail.com (Postfix) with ESMTP id 8322D600100D for ; Tue, 9 Mar 2021 15:25:20 +0000 (UTC) X-Alimail-AntiSpam: AC=PASS;BC=-1|-1;BR=01201311R471e4;CH=green;DM=||false|;DS=||;FP=0|-1|-1|-1|0|-1|-1|-1;HT=e01e01424;MF=xlpang@linux.alibaba.com;NM=1;PH=DS;RN=14;SR=0;TI=SMTPD_---0UR8pmsK_1615303512; Received: from localhost(mailfrom:xlpang@linux.alibaba.com fp:SMTPD_---0UR8pmsK_1615303512) by smtp.aliyun-inc.com(127.0.0.1); Tue, 09 Mar 2021 23:25:13 +0800 From: Xunlei Pang To: Christoph Lameter , Pekka Enberg , Vlastimil Babka , Roman Gushchin , Konstantin Khlebnikov , David Rientjes , Matthew Wilcox , Shu Ming , Andrew Morton Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, Wen Yang , James Wang , Xunlei Pang Subject: [PATCH v3 0/4] mm/slub: Fix count_partial() problem Date: Tue, 9 Mar 2021 23:25:08 +0800 Message-Id: <1615303512-35058-1-git-send-email-xlpang@linux.alibaba.com> X-Mailer: git-send-email 1.8.3.1 X-Stat-Signature: wf9ma1gj4cjgc19gtjj1g4t6upniuwn6 X-Rspamd-Server: rspam02 X-Rspamd-Queue-Id: 8322D600100D Received-SPF: none (linux.alibaba.com>: No applicable sender policy available) receiver=imf25; identity=mailfrom; envelope-from=""; helo=out30-132.freemail.mail.aliyun.com; client-ip=115.124.30.132 X-HE-DKIM-Result: none/none X-HE-Tag: 1615303520-418230 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: count_partial() can hold n->list_lock spinlock for quite long, which makes much trouble to the system. This series eliminate this problem. v1->v2: - Improved changelog and variable naming for PATCH 1~2. - PATCH3 adds per-cpu counter to avoid performance regression in concurrent __slab_free(). v2->v3: - Changed "page->inuse" to the safe "new.inuse", etc. - Used CONFIG_SLUB_DEBUG and CONFIG_SYSFS condition for new counters. - atomic_long_t -> unsigned long [Testing] There seems might be a little performance impact under extreme __slab_free() concurrent calls according to my tests. On my 32-cpu 2-socket physical machine: Intel(R) Xeon(R) CPU E5-2650 v2 @ 2.60GHz 1) perf stat --null --repeat 10 -- hackbench 20 thread 20000 == original, no patched Performance counter stats for 'hackbench 20 thread 20000' (10 runs): 24.536050899 seconds time elapsed ( +- 0.24% ) Performance counter stats for 'hackbench 20 thread 20000' (10 runs): 24.588049142 seconds time elapsed ( +- 0.35% ) == patched with patch1~4 Performance counter stats for 'hackbench 20 thread 20000' (10 runs): 24.670892273 seconds time elapsed ( +- 0.29% ) Performance counter stats for 'hackbench 20 thread 20000' (10 runs): 24.746755689 seconds time elapsed ( +- 0.21% ) 2) perf stat --null --repeat 10 -- hackbench 32 thread 20000 == original, no patched Performance counter stats for 'hackbench 32 thread 20000' (10 runs): 39.784911855 seconds time elapsed ( +- 0.14% ) Performance counter stats for 'hackbench 32 thread 20000' (10 runs): 39.868687608 seconds time elapsed ( +- 0.19% ) == patched with patch1~4 Performance counter stats for 'hackbench 32 thread 20000' (10 runs): 39.681273015 seconds time elapsed ( +- 0.21% ) Performance counter stats for 'hackbench 32 thread 20000' (10 runs): 39.681238459 seconds time elapsed ( +- 0.09% ) Xunlei Pang (4): mm/slub: Introduce two counters for partial objects mm/slub: Get rid of count_partial() percpu: Export per_cpu_sum() mm/slub: Use percpu partial free counter include/linux/percpu-defs.h | 10 ++++ kernel/locking/percpu-rwsem.c | 10 ---- mm/slab.h | 4 ++ mm/slub.c | 120 +++++++++++++++++++++++++++++------------- 4 files changed, 97 insertions(+), 47 deletions(-)