From patchwork Mon Mar 21 12:57:04 2022 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Ryusuke Konishi X-Patchwork-Id: 12787207 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by smtp.lore.kernel.org (Postfix) with ESMTP id 03166C433F5 for ; Mon, 21 Mar 2022 12:57:14 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 59D8E6B0072; Mon, 21 Mar 2022 08:57:14 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 525B76B0073; Mon, 21 Mar 2022 08:57:14 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 39F4F6B0074; Mon, 21 Mar 2022 08:57:14 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from relay.hostedemail.com (relay.a.hostedemail.com [64.99.140.24]) by kanga.kvack.org (Postfix) with ESMTP id 231CA6B0072 for ; Mon, 21 Mar 2022 08:57:14 -0400 (EDT) Received: from smtpin06.hostedemail.com (a10.router.float.18 [10.200.18.1]) by unirelay09.hostedemail.com (Postfix) with ESMTP id D545023FBF for ; Mon, 21 Mar 2022 12:57:13 +0000 (UTC) X-FDA: 79268393946.06.E97175E Received: from mail-pl1-f180.google.com (mail-pl1-f180.google.com [209.85.214.180]) by imf29.hostedemail.com (Postfix) with ESMTP id 58810120016 for ; Mon, 21 Mar 2022 12:57:13 +0000 (UTC) Received: by mail-pl1-f180.google.com with SMTP id h5so12649087plf.7 for ; Mon, 21 Mar 2022 05:57:13 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20210112; h=from:to:cc:subject:date:message-id; bh=sCS6c171oyN7Cq0gnRAYsCzijiKw228qCeDaGu15gbQ=; b=kxKHOOABq7S1CRI0KHi/xF4YyJwZK6cmyIAmwClbqrsolrkKTytDk72Ruj1zQ60y+T Nu8rNFZiEQIf1Y85wSPGdZnAGOotwnU4irRb20LPXBjW3zPkW8vg5i7swBTxNpr5kQV5 sofHwBwkj7lvrMa17ETqe0YBxjeqA2mGuyt2bAsCMEQGh2iqppvq9gr7hhy/Z4Y5izRf rSgUKLtRTkM46bqRfxVYyCt8xaSxRcm1WaUgyKJhgfdBCvkpzqhdkyi37ugmo5MLzrRR ckgR32huHN2VCsgpYMOPznMSjSo8U9JjG7G4k1pIN+nkF3U4MQfqcWKBXVWc9l70Fmf1 MQpg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:from:to:cc:subject:date:message-id; bh=sCS6c171oyN7Cq0gnRAYsCzijiKw228qCeDaGu15gbQ=; b=sa4KILP3Vn8SxVOqQncX33B5heo5Q5Z0MpU3pBUW1lNJx/LufDypD7nUyiwIhktCqd rEyAEnd6azUeBAP/X8Xumts7ECvAlP5KXHYDMSpDo+P5imknXTp2XjroYODceisuFFVy 0hBgJSG1VvPDlrMWD2lvXs6bY3Bk/R28xN/N+nviowj9r1fEOx4ORx5oHCTTj+XQW/iW OCUwWUXQrtLzLorXSWjGMk362E9GgwKptcrra4GgKyXuNangjJyvKvWloEZflDD/rknV i27ogJ5epeDF1Z9BvSJx1P+zi+9lD1Mwu3qhztW8fnu6qYEVxwIppZyBtMTB4OK90Drm BVGg== X-Gm-Message-State: AOAM532Nto1JMzLdeVA6RZOLHHt+fgejOKP/ZJZ+2IX/ZIlru6l808ny lBXduR/nOHaIoZFwCi//qxo= X-Google-Smtp-Source: ABdhPJza+rnxixluZ0BEyTT7Cn7E8pppNLNxJ1YwY3wqwVIRgg/wezDWXN7ZSR4DmrPnM8fJJVdOPQ== X-Received: by 2002:a17:903:24f:b0:153:32c0:7d6f with SMTP id j15-20020a170903024f00b0015332c07d6fmr12467134plh.36.1647867432121; Mon, 21 Mar 2022 05:57:12 -0700 (PDT) Received: from carrot.localdomain (i114-180-38-233.s42.a014.ap.plala.or.jp. [114.180.38.233]) by smtp.gmail.com with ESMTPSA id gb5-20020a17090b060500b001c6d46f7e75sm8009046pjb.30.2022.03.21.05.57.09 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Mar 2022 05:57:11 -0700 (PDT) From: Ryusuke Konishi To: Andrew Morton Cc: linux-nilfs , Matthew Wilcox , David Hildenbrand , LKML , "linux-mm@kvack.org" Subject: [PATCH 0/3] nilfs2 lockdep warning fixes Date: Mon, 21 Mar 2022 21:57:04 +0900 Message-Id: <1647867427-30498-1-git-send-email-konishi.ryusuke@gmail.com> X-Mailer: git-send-email 1.8.3.1 X-Rspamd-Server: rspam06 X-Rspamd-Queue-Id: 58810120016 X-Stat-Signature: fmwm8grgjigq4jcbfoc43u3kcdnhgwrs Authentication-Results: imf29.hostedemail.com; dkim=pass header.d=gmail.com header.s=20210112 header.b=kxKHOOAB; spf=pass (imf29.hostedemail.com: domain of konishi.ryusuke@gmail.com designates 209.85.214.180 as permitted sender) smtp.mailfrom=konishi.ryusuke@gmail.com; dmarc=pass (policy=none) header.from=gmail.com X-Rspam-User: X-HE-Tag: 1647867433-602192 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Hi Andrew, please consider applying the following changes to -mm tree. Ryusuke Konishi (3): nilfs2: fix lockdep warnings in page operations for btree nodes nilfs2: fix lockdep warnings during disk space reclamation nilfs2: get rid of nilfs_mapping_init() The first two are to resolve the lockdep warning issue, and the last one is the accompanying cleanup and low priority. The merge window is already open, but this is for the reported issues, so I'll send it without waiting at this point when tests have passed. Based on your comment, this series solves the issue by separating inode object as needed. Since I was worried about the impact of the object composition changes, I tested the series carefully not to cause regressions especially for delicate functions such like disk space reclamation and snapshots. Thanks, Ryusuke Konishi --- fs/nilfs2/btnode.c | 23 +++++++- fs/nilfs2/btnode.h | 1 + fs/nilfs2/btree.c | 27 ++++++--- fs/nilfs2/dat.c | 4 +- fs/nilfs2/gcinode.c | 7 ++- fs/nilfs2/inode.c | 159 +++++++++++++++++++++++++++++++++++++++++++++++----- fs/nilfs2/mdt.c | 43 +++++++++----- fs/nilfs2/mdt.h | 6 +- fs/nilfs2/nilfs.h | 16 +++--- fs/nilfs2/page.c | 16 +----- fs/nilfs2/page.h | 1 - fs/nilfs2/segment.c | 9 ++- fs/nilfs2/super.c | 5 +- 13 files changed, 241 insertions(+), 76 deletions(-)