[v3,0/4] Refactoring for remove_memory_section/unregister_mem_sect_under_nodes

Message

Oscar Salvador Aug. 15, 2018, 2:42 p.m. UTC

From: Oscar Salvador <[e-mail]>

v2 -> v3:
        - NODEMASK_FREE can deal with NULL pointers, so do not
          make it conditional (by David).
        - Split up node_online's check patch (David's suggestion)
        - Added Reviewed-by from Andrew and David
        - Fix checkpath.pl warnings

This patchset does some cleanups and refactoring in the memory-hotplug code.

The first and the second patch are pretty straightforward, as they
only remove unused arguments/checks.

The third one refactors unregister_mem_sect_under_nodes.
This is needed to have a proper fallback in case we could not allocate
memory. (details can be seen in patch3).

The fourth patch removes a node_online check.
We are getting the nid from pages that are yet not removed, but a node
can only be offline when its memory/cpu's have been removed.
Therefore, we do not really need to check for the node to be online here.
Since this change has a patch for itself, we could quickly revert it
if we notice that something is wrong with it, or drop it if people
are concerned about it.

Oscar Salvador (4):
  mm/memory-hotplug: Drop unused args from remove_memory_section
  mm/memory_hotplug: Drop mem_blk check from
    unregister_mem_sect_under_nodes
  mm/memory_hotplug: Refactor unregister_mem_sect_under_nodes
  mm/memory_hotplug: Drop node_online check in
    unregister_mem_sect_under_nodes

 drivers/base/memory.c |  5 ++---
 drivers/base/node.c   | 29 +++++++++++++++--------------
 include/linux/node.h  |  5 ++---
 3 files changed, 19 insertions(+), 20 deletions(-)