From patchwork Wed Aug 15 14:42:15 2018 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Oscar Salvador X-Patchwork-Id: 10566667 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id DAC311510 for ; Wed, 15 Aug 2018 14:42:33 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id BFAD92A902 for ; Wed, 15 Aug 2018 14:42:33 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id B35342A905; Wed, 15 Aug 2018 14:42:33 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 8A7322A902 for ; Wed, 15 Aug 2018 14:42:32 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 79EA26B0007; Wed, 15 Aug 2018 10:42:31 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 74DE16B0008; Wed, 15 Aug 2018 10:42:31 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 63B546B000A; Wed, 15 Aug 2018 10:42:31 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-wr1-f71.google.com (mail-wr1-f71.google.com [209.85.221.71]) by kanga.kvack.org (Postfix) with ESMTP id 07F996B0007 for ; Wed, 15 Aug 2018 10:42:31 -0400 (EDT) Received: by mail-wr1-f71.google.com with SMTP id p12-v6so1018855wro.7 for ; Wed, 15 Aug 2018 07:42:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id; bh=HKTu6y7RFvN/c9bNONpAZT5RMhKAMFpnA8OBIKrulj4=; b=YiMuy5RbIVqOxh3biRPwZxzShmP6ZkrM2RBIdw8C6Xzz62OYSoxs3QAcSKMYglHZVH HzXKNbft4bLmRdW6Ubo4e4T3/IhZEsD/I2VwUU3Gx7L53uK2epr0R5olrZ2gMMGYYN0C vUcr6b1JD1xvq9nXxGWgELovRgbH6hW9Xv2JSa0WULtAR6jQAUECLv9Gzz16a2rBbUz2 qcA9fcAdk5A5BS4BUHE1AdqwRZ+xTasCRoQA9lURkNogUEs5PoEFUQfv0t9aNjClBMn1 Ci9TKRkGO48loWrSBF38pjVr3r6jERCUvEg3RXCCrnFutXoN8ZFj5UtTrL979bGRPkZY 7hWQ== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of osalvador.vilardaga@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=osalvador.vilardaga@gmail.com X-Gm-Message-State: AOUpUlHsYw/0N6JfqGf2zhh/fqas3xvReTPt+RzhzA0Wmn0SRGZKOtOM msm44arkMjuXkpoklOw9rn0rZpYcOb9WYQCWRW9w2h7FMMzgPf5mIHozpjPjhrVXCQiEJqrp5MO ZyzJyan0ziwNlVvNIDY5/+ZcTo1dba3YCv/xxcQftAvCD+tDo8dNUvbXgoXoxr+EavHJAbWNrFs Dbf4+XXKgr/1vcPCrcrAijXeQ1/xXeqN3JW87sYNzW0KEeOXi9Rz+ktLxX7fADzAdP7biqfFuWX eINKZsGj3dhVfMS8vdmRxDqkU6B5KCykTT/kPw7ZckEipJA1JWtVUVjUQ04g9SYRvRg3nqhVVo6 DqaEUeDljfRmgx867zn9nIqZTX0VT13JpE38z7UUeywYAUjOqD5wyNJnPt1dHroOLkkOYOzAWA= = X-Received: by 2002:a1c:9550:: with SMTP id x77-v6mr12987595wmd.135.1534344150479; Wed, 15 Aug 2018 07:42:30 -0700 (PDT) X-Received: by 2002:a1c:9550:: with SMTP id x77-v6mr12987569wmd.135.1534344149379; Wed, 15 Aug 2018 07:42:29 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1534344149; cv=none; d=google.com; s=arc-20160816; b=AxDp3G/2Q9VXkFwdzntrMmD+z223MEQFL+RPQFM5/Rg5+KW0EYX/nM4haqlC+xz3f7 6pk1eHJoPP4OYuqYfCnwo7Xj++1Tqk28hV6mfGoOaNSTL1VP9C9P+5WvHEVGQSC8+FWU uY9738Rr9rjZj/MtlcvwFNGVhQt9m5X7OMFKO33UOOfFhebN8SmgNPVhU/8vO1TbpuDW X7r0IC95VLkc/xaHVBReDIudHOQE4GZaaw2oYw8udmCWctAVbgXVuclyQVEPMCvReeKS LoWaY2jPGc8aMPrkF+N4Y7MsDkZPafLx0gcLSkISayT+KeAXOG8h8XpsM7kuwtjIXHRR BUTg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=message-id:date:subject:cc:to:from:arc-authentication-results; bh=HKTu6y7RFvN/c9bNONpAZT5RMhKAMFpnA8OBIKrulj4=; b=orqvUlqEqbes6MhHJNUagEyf8PPVz4NlZfKiU8E4sdg8y0veQkfQ50wdkQgUlmlT2F MsyNDnhIPZT56dzu33tADSMjCEvHFpqfL6URXZGJHe11TTEHzbkH1VjvyPSj2+hpXdRU m74MKrzwdTBaujFJM4+z2gwKFU4OJgnJYRuLsjk5fP+wlio+BGHOWgV9lx4cspH3oG5N ZTDDadtE7WY1f0H/uJWeNBxY/s9+M2aNl5AL44OhZldjdf0S16AIDFPvj/5yI7iO/m8a s1e/uviveV+qZY0sebyXGlOtYR5NqgIA3uuaL7lb3/E29NVn4+PxmROWGHxFlBSX8YpD dvHg== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of osalvador.vilardaga@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=osalvador.vilardaga@gmail.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id u12-v6sor8237529wro.63.2018.08.15.07.42.29 for (Google Transport Security); Wed, 15 Aug 2018 07:42:29 -0700 (PDT) Received-SPF: pass (google.com: domain of osalvador.vilardaga@gmail.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; spf=pass (google.com: domain of osalvador.vilardaga@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=osalvador.vilardaga@gmail.com X-Google-Smtp-Source: AA+uWPyVMqcDc0hq5aVceYRpuuHsQsIQqvGeStNN7n2rWVKCmxP/V0BfsIC5ZJfGyGcKL4M7qwB9bg== X-Received: by 2002:adf:97cf:: with SMTP id t15-v6mr16509928wrb.283.1534344149128; Wed, 15 Aug 2018 07:42:29 -0700 (PDT) Received: from techadventures.net (techadventures.net. [62.201.165.239]) by smtp.gmail.com with ESMTPSA id p11-v6sm16189775wrs.51.2018.08.15.07.42.28 (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Wed, 15 Aug 2018 07:42:28 -0700 (PDT) Received: from d104.suse.de (charybdis-ext.suse.de [195.135.221.2]) by techadventures.net (Postfix) with ESMTPA id AAFB312489C; Wed, 15 Aug 2018 16:42:27 +0200 (CEST) From: Oscar Salvador To: akpm@linux-foundation.org Cc: mhocko@suse.com, vbabka@suse.cz, dan.j.williams@intel.com, yasu.isimatu@gmail.com, jonathan.cameron@huawei.com, david@redhat.com, Pavel.Tatashin@microsoft.com, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Oscar Salvador Subject: [PATCH v3 0/4] Refactoring for remove_memory_section/unregister_mem_sect_under_nodes Date: Wed, 15 Aug 2018 16:42:15 +0200 Message-Id: <20180815144219.6014-1-osalvador@techadventures.net> X-Mailer: git-send-email 2.13.6 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP From: Oscar Salvador v2 -> v3: - NODEMASK_FREE can deal with NULL pointers, so do not make it conditional (by David). - Split up node_online's check patch (David's suggestion) - Added Reviewed-by from Andrew and David - Fix checkpath.pl warnings This patchset does some cleanups and refactoring in the memory-hotplug code. The first and the second patch are pretty straightforward, as they only remove unused arguments/checks. The third one refactors unregister_mem_sect_under_nodes. This is needed to have a proper fallback in case we could not allocate memory. (details can be seen in patch3). The fourth patch removes a node_online check. We are getting the nid from pages that are yet not removed, but a node can only be offline when its memory/cpu's have been removed. Therefore, we do not really need to check for the node to be online here. Since this change has a patch for itself, we could quickly revert it if we notice that something is wrong with it, or drop it if people are concerned about it. Oscar Salvador (4): mm/memory-hotplug: Drop unused args from remove_memory_section mm/memory_hotplug: Drop mem_blk check from unregister_mem_sect_under_nodes mm/memory_hotplug: Refactor unregister_mem_sect_under_nodes mm/memory_hotplug: Drop node_online check in unregister_mem_sect_under_nodes drivers/base/memory.c | 5 ++--- drivers/base/node.c | 29 +++++++++++++++-------------- include/linux/node.h | 5 ++--- 3 files changed, 19 insertions(+), 20 deletions(-)