From patchwork Fri Jan 11 15:05:41 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Souptick Joarder X-Patchwork-Id: 10758179 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id B7646746 for ; Fri, 11 Jan 2019 15:01:46 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 9D8AB2A0DC for ; Fri, 11 Jan 2019 15:01:46 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 99EDD2A08F; Fri, 11 Jan 2019 15:01:46 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.0 required=2.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,FREEMAIL_FROM,MAILING_LIST_MULTI,RCVD_IN_DNSWL_NONE autolearn=ham version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 6D6642A0E4 for ; Fri, 11 Jan 2019 15:01:45 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id 694F08E0002; Fri, 11 Jan 2019 10:01:44 -0500 (EST) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 61A518E0001; Fri, 11 Jan 2019 10:01:44 -0500 (EST) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4CC7F8E0002; Fri, 11 Jan 2019 10:01:44 -0500 (EST) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-pf1-f197.google.com (mail-pf1-f197.google.com [209.85.210.197]) by kanga.kvack.org (Postfix) with ESMTP id 05D198E0001 for ; Fri, 11 Jan 2019 10:01:44 -0500 (EST) Received: by mail-pf1-f197.google.com with SMTP id b17so10476163pfc.11 for ; Fri, 11 Jan 2019 07:01:43 -0800 (PST) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:dkim-signature:date:from:to:cc:subject :message-id:mime-version:content-disposition:user-agent; bh=SrodQzZztcg8txHZaZFxducSgC9DqvYe1eV09xmVfQk=; b=UfhLjmKzCxzkCCxresFGYS1ICtrx02Nl/hqJYbRDEtDq90RyEhEfPow8HVSqXojKuM EmD+CHGugfWqPGxWvHY0Svq0ImwdjFlVnDsBrk22X2+sXVFXiIWwXSmbYdCAcaDahe0X EC3qg1NqhsGw3ItBjwsw/7eLoY2/kUgo1jKPTrMIpiNFUgJ7goexgHM4ZD9mzjxGAC9N XY70I6iY4NgKjVbz8JeLviySYCErsvY91u0+9oevLW0H1QYLwoV+9Cd0KJJsoew9cqM1 97OcK7Ua+JUQYlgZ9SM+DfakFW/868C7fA7zRYCV9CLvxs0d3666/LMS6sCV9FWanxlK HNVw== X-Gm-Message-State: AJcUukfydVzo7t/yWaq/KnOcH2PExYcE0GIaTu+QViSOgT2GqYx6JudM 8qKLhPlaRzTJ8XNa92D8Wqo/luQYOcG7gUjE9Iz83sn2kOrd02W+ruFuQpUKIEJx6eUjkHuqF14 eG1PCgchKjCF4zJDxsuDRiMXqX0yBsN7N/tqJPejWq3Yp+kBFJS0FMrM4wwyBhGwtlCOCGqNF2q CxzRcKf4LizpVfPLr6KewICsgN2TG1CMTWxJQ/G1bE52JWfn4WfECYqS8XiI6sHJdGgk0WDmVnJ iTfdAKpz0LulTQ7dJ69cdA22yLTDhcUE30d+jophE91blwZCVJ0XXWo86GbJkZO9StzRMQqOH30 fQxK+UOcrSV9n+wfr0mLpe15WIzRrHHA3kVQcgxrO7C/1TKltdWRJMiWSQdbUgO9c1nlqtPXhig p X-Received: by 2002:a63:31cc:: with SMTP id x195mr13802014pgx.52.1547218903517; Fri, 11 Jan 2019 07:01:43 -0800 (PST) X-Received: by 2002:a63:31cc:: with SMTP id x195mr13801930pgx.52.1547218902492; Fri, 11 Jan 2019 07:01:42 -0800 (PST) ARC-Seal: i=1; a=rsa-sha256; t=1547218902; cv=none; d=google.com; s=arc-20160816; b=xn/Ayux50L1buU1/Frd9CAO0YolSWQm8J7NxuD64QZ0NDQcbHpHub7F9IoQVzHKfX3 0ntIUc7xcSs5qjTPGuZ81HJu5IZlNKwgV3mzkzcujUdPJ6r//+xEIx8UPAwRJ1CvZyNL yPUSjwaTWUMIJPDI0NDlq7I3PSJrtsl1DgTQSvnmipkCSTfmAS08Ml9TdznzZ89nvNpk rb+aEUMVGrQHJ/M4FoTK7sp7CGAedQk2AgKjw82THj8rJd9ySiwBPZ2UlHYzoq5gTcaH 3xLylUlRaByFhXbmodn03ue3lNMm+LEmh/Zu9NvGWbN5lCBUnsM6CoYW73M7Tyz9skZl gXIg== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=user-agent:content-disposition:mime-version:message-id:subject:cc :to:from:date:dkim-signature; bh=SrodQzZztcg8txHZaZFxducSgC9DqvYe1eV09xmVfQk=; b=oRjDbYIT2B+6ieoPWqvv+NvHyXgxilf9AXxEdI5SQqJa25d4PTGGw11sBNsAorjgGi DSJYVE9NAqz2cuYP8QUDV4hwxA66WLa6kIcDFHM+R8xr2p2LJrc3ARo4ZmdFV4MjZPv7 6RtsqB1yYOjHXf9LcD++wxCT7JcFr1BtamY/kcHBPOXoVQk3XH6JNb9RBcayaeP38Zq1 1NGMykwfk5lJOhBaoZLmcp944jm2QqTyGTTIy0omzxASban2dxU34K7EistdXdOOaHUc d+yFZS0e8hK201Ub6jGaqvQ8Jj+trQHuHqC97JB4egpBWdcZMAO4r9VKwsCuy1tNjDrx pZ3Q== ARC-Authentication-Results: i=1; mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="RpzAMn/t"; spf=pass (google.com: domain of jrdr.linux@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jrdr.linux@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com Received: from mail-sor-f65.google.com (mail-sor-f65.google.com. [209.85.220.65]) by mx.google.com with SMTPS id h9sor53947593pgs.76.2019.01.11.07.01.42 for (Google Transport Security); Fri, 11 Jan 2019 07:01:42 -0800 (PST) Received-SPF: pass (google.com: domain of jrdr.linux@gmail.com designates 209.85.220.65 as permitted sender) client-ip=209.85.220.65; Authentication-Results: mx.google.com; dkim=pass header.i=@gmail.com header.s=20161025 header.b="RpzAMn/t"; spf=pass (google.com: domain of jrdr.linux@gmail.com designates 209.85.220.65 as permitted sender) smtp.mailfrom=jrdr.linux@gmail.com; dmarc=pass (p=NONE sp=QUARANTINE dis=NONE) header.from=gmail.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20161025; h=date:from:to:cc:subject:message-id:mime-version:content-disposition :user-agent; bh=SrodQzZztcg8txHZaZFxducSgC9DqvYe1eV09xmVfQk=; b=RpzAMn/tFZO9w1bOsU0R3bl0Czqgh3vozKcpize0+4T5FcTI3eGHnL7a/siSocGNeS YpzDw/x5TPn/ZIK8D8rFRVnfSd+kRunfwlXMPBFnoy0agtIVT3l2o8n93yulfDdqPfpM 02pnJKSJtBrMnNoIKfIXvp+dl7xWo/ZINl/06zWYmqtI8R6Rd1tzw33GJStW9BWNcyJd UTxrdHPrzQA7Dgo9vXmzvN7LPm0x/n5eENgEHExKf5wRU3L1BPvidyksamluwHiEMfNj jLP1Epne1X0o4Fs5YlsShABd8w6xov+ORe//hxIum1KwYBI45AwbqyCzizyY7CZsappy j23Q== X-Google-Smtp-Source: ALg8bN63Mqumr33i923Eaojw1CNwJqGO3fUgNxuFX1Idnsn+2UvfCqyMDy2gA5SSe2/mxV+qUcpzvQ== X-Received: by 2002:a63:f30d:: with SMTP id l13mr13690215pgh.399.1547218901644; Fri, 11 Jan 2019 07:01:41 -0800 (PST) Received: from jordon-HP-15-Notebook-PC ([49.207.52.190]) by smtp.gmail.com with ESMTPSA id l70sm87429186pgd.20.2019.01.11.07.01.39 (version=TLS1 cipher=ECDHE-RSA-AES128-SHA bits=128/128); Fri, 11 Jan 2019 07:01:40 -0800 (PST) Date: Fri, 11 Jan 2019 20:35:41 +0530 From: Souptick Joarder To: akpm@linux-foundation.org, willy@infradead.org, mhocko@suse.com, kirill.shutemov@linux.intel.com, vbabka@suse.cz, riel@surriel.com, sfr@canb.auug.org.au, rppt@linux.vnet.ibm.com, peterz@infradead.org, linux@armlinux.org.uk, robin.murphy@arm.com, iamjoonsoo.kim@lge.com, treding@nvidia.com, keescook@chromium.org, m.szyprowski@samsung.com, stefanr@s5r6.in-berlin.de, hjc@rock-chips.com, heiko@sntech.de, airlied@linux.ie, oleksandr_andrushchenko@epam.com, joro@8bytes.org, pawel@osciak.com, kyungmin.park@samsung.com, mchehab@kernel.org, boris.ostrovsky@oracle.com, jgross@suse.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-arm-kernel@lists.infradead.org, linux1394-devel@lists.sourceforge.net, dri-devel@lists.freedesktop.org, linux-rockchip@lists.infradead.org, xen-devel@lists.xen.org, iommu@lists.linux-foundation.org, linux-media@vger.kernel.org Subject: [PATCH 0/9] Use vm_insert_range and vm_insert_range_buggy Message-ID: <20190111150541.GA2670@jordon-HP-15-Notebook-PC> MIME-Version: 1.0 Content-Disposition: inline User-Agent: Mutt/1.5.21 (2010-09-15) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP Previouly drivers have their own way of mapping range of kernel pages/memory into user vma and this was done by invoking vm_insert_page() within a loop. As this pattern is common across different drivers, it can be generalized by creating new functions and use it across the drivers. vm_insert_range() is the API which could be used to mapped kernel memory/pages in drivers which has considered vm_pgoff vm_insert_range_buggy() is the API which could be used to map range of kernel memory/pages in drivers which has not considered vm_pgoff. vm_pgoff is passed default as 0 for those drivers. We _could_ then at a later "fix" these drivers which are using vm_insert_range_buggy() to behave according to the normal vm_pgoff offsetting simply by removing the _buggy suffix on the function name and if that causes regressions, it gives us an easy way to revert. There is an existing bug in [7/9], where user passed length is not verified against object_count. For any value of length > object_count it will end up overrun page array which could lead to a potential bug. This is fixed as part of these conversion. Souptick Joarder (9): mm: Introduce new vm_insert_range and vm_insert_range_buggy API arch/arm/mm/dma-mapping.c: Convert to use vm_insert_range drivers/firewire/core-iso.c: Convert to use vm_insert_range_buggy drm/rockchip/rockchip_drm_gem.c: Convert to use vm_insert_range drm/xen/xen_drm_front_gem.c: Convert to use vm_insert_range iommu/dma-iommu.c: Convert to use vm_insert_range videobuf2/videobuf2-dma-sg.c: Convert to use vm_insert_range_buggy xen/gntdev.c: Convert to use vm_insert_range xen/privcmd-buf.c: Convert to use vm_insert_range_buggy arch/arm/mm/dma-mapping.c | 22 ++---- drivers/firewire/core-iso.c | 15 +---- drivers/gpu/drm/rockchip/rockchip_drm_gem.c | 17 +---- drivers/gpu/drm/xen/xen_drm_front_gem.c | 18 ++--- drivers/iommu/dma-iommu.c | 12 +--- drivers/media/common/videobuf2/videobuf2-dma-sg.c | 22 ++---- drivers/xen/gntdev.c | 16 ++--- drivers/xen/privcmd-buf.c | 8 +-- include/linux/mm.h | 4 ++ mm/memory.c | 81 +++++++++++++++++++++++ mm/nommu.c | 14 ++++ 11 files changed, 129 insertions(+), 100 deletions(-)