From patchwork Tue Mar 26 16:47:39 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Jerome Glisse X-Patchwork-Id: 10871603 Return-Path: Received: from mail.wl.linuxfoundation.org (pdx-wl-mail.web.codeaurora.org [172.30.200.125]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6F6E3186D for ; Tue, 26 Mar 2019 16:48:08 +0000 (UTC) Received: from mail.wl.linuxfoundation.org (localhost [127.0.0.1]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id 602AB28DD7 for ; Tue, 26 Mar 2019 16:48:08 +0000 (UTC) Received: by mail.wl.linuxfoundation.org (Postfix, from userid 486) id 541B128DCC; Tue, 26 Mar 2019 16:48:08 +0000 (UTC) X-Spam-Checker-Version: SpamAssassin 3.3.1 (2010-03-16) on pdx-wl-mail.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-2.9 required=2.0 tests=BAYES_00,MAILING_LIST_MULTI, RCVD_IN_DNSWL_NONE autolearn=unavailable version=3.3.1 Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.wl.linuxfoundation.org (Postfix) with ESMTP id CD36228DD7 for ; Tue, 26 Mar 2019 16:48:04 +0000 (UTC) Received: by kanga.kvack.org (Postfix) id DEAA76B0003; Tue, 26 Mar 2019 12:48:03 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id D9A6C6B0006; Tue, 26 Mar 2019 12:48:03 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id C89086B000D; Tue, 26 Mar 2019 12:48:03 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from mail-qt1-f200.google.com (mail-qt1-f200.google.com [209.85.160.200]) by kanga.kvack.org (Postfix) with ESMTP id 9FBC66B0003 for ; Tue, 26 Mar 2019 12:48:03 -0400 (EDT) Received: by mail-qt1-f200.google.com with SMTP id i3so14110782qtc.7 for ; Tue, 26 Mar 2019 09:48:03 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-original-authentication-results:x-gm-message-state:from:to:cc :subject:date:message-id:mime-version:content-transfer-encoding; bh=LiR7M+gjL1jwp4S7wm8Je1S/i9RmM3FIjpOd06XnOUo=; b=D9c42xKX+QVduWtsHbv3CluKvYkpqt2VZUubTuQeelF6Kqr2gsOSMFTPpEya6eMpxu ca11VakishxDxbnDVqY404qqLt/bhDez6grLaVjPbsaTvW6i2b2ZEgNLtofvtaMHvICI wRQx/oNnMkGSwUdFY1k9CGttwHUNIePUd2YKPcKMVuPEKBGQF58LXksR7iF/VyPl0BHv blPnF8l11RRLCd7sn1ZlVFFnkPKIubqm8WaPrqPXzo74nasRRyUIMAeR5YxaAqHIEzMr MJbaZQNvAKraBw0s2ABjHHy0P5+z8KdAx0Aa93vbm6oCbX5+cTleISE0sE4Y8bgHvMfY sqhQ== X-Original-Authentication-Results: mx.google.com; spf=pass (google.com: domain of jglisse@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=jglisse@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com X-Gm-Message-State: APjAAAXtgmx3p6Wrdi+lEsZb1Xymiz1tiEQKH8YL/L8IytC7jzSFP0ym U8oTK6WtWBT6yyxpKOMbUETlmmvbPZS9NeITLwa5EQc/gYtV+/EgzCppkl8z8lOakU6OeNJRoWT r0DlqGwly5oP2tTOjVyC1DUv/zqIJOSncVXCNGfzIaZpRabDmWajFQd+R5QbOsusPZQ== X-Received: by 2002:a37:b345:: with SMTP id c66mr5615907qkf.219.1553618883368; Tue, 26 Mar 2019 09:48:03 -0700 (PDT) X-Google-Smtp-Source: APXvYqykre79woPyY7eEzWzZxpczlWE+BRIWuMeentNQ8xED9pb9u0xM5tEu8UZV2z00ZgLQyYuB X-Received: by 2002:a37:b345:: with SMTP id c66mr5615833qkf.219.1553618882318; Tue, 26 Mar 2019 09:48:02 -0700 (PDT) ARC-Seal: i=1; a=rsa-sha256; t=1553618882; cv=none; d=google.com; s=arc-20160816; b=L7xz5ikwN8GBBdVDftJ2PRMLK5Z0OjPuT2NdpsXVg2tinbwqSfdNXlr9CLM76kjEcD fdGGZxmf88zJU05fhuEGzE5HusfUziyB6EuIZYo2mZRr66ax9+1Yp2nYMmZ0FOsQOxup iwJmk8a0bjdONY23D9ZJNxxuQplQySvjM5Lnfw2dGxKrJnFuFxfE+QtmmzAi4k0jKnzG bZfcC2zNaU9zJvI5lhgRzxmF1of4Bvw5lctumjk3hbvY0JUp05tiDaCdpSvCxE5ARV5D UN+anAL0k1H/xNUVZvA6CmK3wYzL3qMkzCWgD6VEqO3Sf7dGGrdpIIJNluAh+kkPL6cA 4tug== ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=arc-20160816; h=content-transfer-encoding:mime-version:message-id:date:subject:cc :to:from; bh=LiR7M+gjL1jwp4S7wm8Je1S/i9RmM3FIjpOd06XnOUo=; b=b2i+AYiXCsXMQPTS746VyZHan4WqV3Bllii5s6MXx8tjx2E/j+Bc8Go2L2Sds8aEsw w90ueI+QGaUI0o2GNcs/XQ5nJpy68NO6JOulLK5EoZ0SsjFjFG+pzoq6O1QeqRq+tFnW xF+qEQzY2xkQgaaSnImFkGVeK1oZHA4cVOpMdKKW9tFbEVpvfueX53mPizThOAJPocqz knlf4Crk/1k3PlRnhYt2vjKRCuYDeqGBhDaaH9OLI2zDpmFrQE+9/5FWgOmKecI7FTTM P59iGhZgSMO7CZV1/GZeQEuT7MGVxI1He+QTR46fW/w7cL9dYZ+mHK2YTQVFqOsywcgS dN4g== ARC-Authentication-Results: i=1; mx.google.com; spf=pass (google.com: domain of jglisse@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=jglisse@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from mx1.redhat.com (mx1.redhat.com. [209.132.183.28]) by mx.google.com with ESMTPS id p186si3793041qkd.108.2019.03.26.09.48.02 for (version=TLS1_2 cipher=ECDHE-RSA-AES128-GCM-SHA256 bits=128/128); Tue, 26 Mar 2019 09:48:02 -0700 (PDT) Received-SPF: pass (google.com: domain of jglisse@redhat.com designates 209.132.183.28 as permitted sender) client-ip=209.132.183.28; Authentication-Results: mx.google.com; spf=pass (google.com: domain of jglisse@redhat.com designates 209.132.183.28 as permitted sender) smtp.mailfrom=jglisse@redhat.com; dmarc=pass (p=NONE sp=NONE dis=NONE) header.from=redhat.com Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mx1.redhat.com (Postfix) with ESMTPS id 47087461D1; Tue, 26 Mar 2019 16:48:01 +0000 (UTC) Received: from localhost.localdomain.com (unknown [10.20.6.236]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6C2B88429D; Tue, 26 Mar 2019 16:47:55 +0000 (UTC) From: jglisse@redhat.com To: linux-kernel@vger.kernel.org Cc: =?utf-8?b?SsOpcsO0bWUgR2xpc3Nl?= , Andrew Morton , linux-mm@kvack.org, =?utf-8?q?Ch?= =?utf-8?q?ristian_K=C3=B6nig?= , Joonas Lahtinen , Jani Nikula , Rodrigo Vivi , Jan Kara , Andrea Arcangeli , Peter Xu , Felix Kuehling , Jason Gunthorpe , Ross Zwisler , Dan Williams , Paolo Bonzini , Alex Deucher , =?utf-8?b?UmFkaW0gS3LEjW3DocWZ?= , Michal Hocko , Ben Skeggs , Ralph Campbell , John Hubbard , kvm@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-rdma@vger.kernel.org, Arnd Bergmann Subject: [PATCH v6 0/8] mmu notifier provide context informations Date: Tue, 26 Mar 2019 12:47:39 -0400 Message-Id: <20190326164747.24405-1-jglisse@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Greylist: Sender IP whitelisted, not delayed by milter-greylist-4.5.16 (mx1.redhat.com [10.5.110.29]); Tue, 26 Mar 2019 16:48:01 +0000 (UTC) X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: X-Virus-Scanned: ClamAV using ClamSMTP From: Jérôme Glisse (Andrew this apply on top of my HMM patchset as otherwise you will have conflict with changes to mm/hmm.c) Changes since v5: - drop KVM bits waiting for KVM people to express interest if they do not then i will post patchset to remove change_pte_notify as without the changes in v5 change_pte_notify is just useless (it it is useless today upstream it is just wasting cpu cycles) - rebase on top of lastest Linus tree Previous cover letter with minor update: Here i am not posting users of this, they already have been posted to appropriate mailing list [6] and will be merge through the appropriate tree once this patchset is upstream. Note that this serie does not change any behavior for any existing code. It just pass down more information to mmu notifier listener. The rational for this patchset: CPU page table update can happens for many reasons, not only as a result of a syscall (munmap(), mprotect(), mremap(), madvise(), ...) but also as a result of kernel activities (memory compression, reclaim, migration, ...). This patch introduce a set of enums that can be associated with each of the events triggering a mmu notifier: - UNMAP: munmap() or mremap() - CLEAR: page table is cleared (migration, compaction, reclaim, ...) - PROTECTION_VMA: change in access protections for the range - PROTECTION_PAGE: change in access protections for page in the range - SOFT_DIRTY: soft dirtyness tracking Being able to identify munmap() and mremap() from other reasons why the page table is cleared is important to allow user of mmu notifier to update their own internal tracking structure accordingly (on munmap or mremap it is not longer needed to track range of virtual address as it becomes invalid). Without this serie, driver are force to assume that every notification is an munmap which triggers useless trashing within drivers that associate structure with range of virtual address. Each driver is force to free up its tracking structure and then restore it on next device page fault. With this serie we can also optimize device page table update [6]. More over this can also be use to optimize out some page table updates like for KVM where we can update the secondary MMU directly from the callback instead of clearing it. ACKS AMD/RADEON https://lkml.org/lkml/2019/2/1/395 ACKS RDMA https://lkml.org/lkml/2018/12/6/1473 Cheers, Jérôme [1] v1 https://lkml.org/lkml/2018/3/23/1049 [2] v2 https://lkml.org/lkml/2018/12/5/10 [3] v3 https://lkml.org/lkml/2018/12/13/620 [4] v4 https://lkml.org/lkml/2019/1/23/838 [5] v5 https://lkml.org/lkml/2019/2/19/752 [6] patches to use this: https://lkml.org/lkml/2019/1/23/833 https://lkml.org/lkml/2019/1/23/834 https://lkml.org/lkml/2019/1/23/832 https://lkml.org/lkml/2019/1/23/831 Cc: Andrew Morton Cc: linux-mm@kvack.org Cc: Christian König Cc: Joonas Lahtinen Cc: Jani Nikula Cc: Rodrigo Vivi Cc: Jan Kara Cc: Andrea Arcangeli Cc: Peter Xu Cc: Felix Kuehling Cc: Jason Gunthorpe Cc: Ross Zwisler Cc: Dan Williams Cc: Paolo Bonzini Cc: Alex Deucher Cc: Radim Krčmář Cc: Michal Hocko Cc: Christian Koenig Cc: Ben Skeggs Cc: Ralph Campbell Cc: John Hubbard Cc: kvm@vger.kernel.org Cc: dri-devel@lists.freedesktop.org Cc: linux-rdma@vger.kernel.org Cc: Arnd Bergmann Jérôme Glisse (8): mm/mmu_notifier: helper to test if a range invalidation is blockable mm/mmu_notifier: convert user range->blockable to helper function mm/mmu_notifier: convert mmu_notifier_range->blockable to a flags mm/mmu_notifier: contextual information for event enums mm/mmu_notifier: contextual information for event triggering invalidation v2 mm/mmu_notifier: use correct mmu_notifier events for each invalidation mm/mmu_notifier: pass down vma and reasons why mmu notifier is happening v2 mm/mmu_notifier: mmu_notifier_range_update_to_read_only() helper drivers/gpu/drm/amd/amdgpu/amdgpu_mn.c | 8 ++-- drivers/gpu/drm/i915/i915_gem_userptr.c | 2 +- drivers/gpu/drm/radeon/radeon_mn.c | 4 +- drivers/infiniband/core/umem_odp.c | 5 +- drivers/xen/gntdev.c | 6 +-- fs/proc/task_mmu.c | 3 +- include/linux/mmu_notifier.h | 63 +++++++++++++++++++++++-- kernel/events/uprobes.c | 3 +- mm/hmm.c | 6 +-- mm/huge_memory.c | 14 +++--- mm/hugetlb.c | 12 +++-- mm/khugepaged.c | 3 +- mm/ksm.c | 6 ++- mm/madvise.c | 3 +- mm/memory.c | 25 ++++++---- mm/migrate.c | 5 +- mm/mmu_notifier.c | 12 ++++- mm/mprotect.c | 4 +- mm/mremap.c | 3 +- mm/oom_kill.c | 3 +- mm/rmap.c | 6 ++- virt/kvm/kvm_main.c | 3 +- 22 files changed, 147 insertions(+), 52 deletions(-)