From patchwork Fri Oct 18 09:42:38 2019 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Alexander Potapenko X-Patchwork-Id: 11197965 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id D37DA14ED for ; Fri, 18 Oct 2019 09:43:16 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 869AF21D7C for ; Fri, 18 Oct 2019 09:43:16 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="PUkzffYN" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 869AF21D7C Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id B63DF8E001B; Fri, 18 Oct 2019 05:43:15 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id B135B8E0003; Fri, 18 Oct 2019 05:43:15 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 9DB9B8E001B; Fri, 18 Oct 2019 05:43:15 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0244.hostedemail.com [216.40.44.244]) by kanga.kvack.org (Postfix) with ESMTP id 6B1188E0003 for ; Fri, 18 Oct 2019 05:43:15 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay03.hostedemail.com (Postfix) with SMTP id F31898248041 for ; Fri, 18 Oct 2019 09:43:14 +0000 (UTC) X-FDA: 76056417108.25.cause68_73997c240863e X-Spam-Summary: 50,0,0,6bf24df3c566b515,d41d8cd98f00b204,3mympxqykcnwejgbcpemmejc.amkjglsv-kkit8ai.mpe@flex--glider.bounces.google.com,:glider@google.com:viro@zeniv.linux.org.uk:akpm@linux-foundation.org:aryabinin@virtuozzo.com:luto@kernel.org:ard.biesheuvel@linaro.org:arnd@arndb.de:hch@lst.de:dmitry.torokhov@gmail.com:dvyukov@google.com:edumazet@google.com:ericvh@gmail.com:gregkh@linuxfoundation.org:harry.wentland@amd.com:herbert@gondor.apana.org.au:mingo@elte.hu:axboe@kernel.dk:martin.petersen@oracle.com:schwidefsky@de.ibm.com:mst@redhat.com:monstr@monstr.eu:pmladek@suse.com:sergey.senozhatsky@gmail.com:rostedt@goodmis.org:tiwai@suse.com:tytso@mit.edu:tglx@linutronix.de:vegard.nossum@oracle.com:wsa@the-dreams.de:gor@linux.ibm.com:iii@linux.ibm.com:mark.rutland@arm.com:,RULES_HIT:4:41:152:355:379:541:800:960:967:973:982:988:989:1260:1263:1277:1313:1314:1345:1431:1437:1516:1518:1593:1594:1605:1730:1747:1777:1792:1801:1981:2194:2199:2393:2525:2553:2560:2564:2637:2682:2685:2736 :2859:29 X-HE-Tag: cause68_73997c240863e X-Filterd-Recvd-Size: 15148 Received: from mail-vk1-f202.google.com (mail-vk1-f202.google.com [209.85.221.202]) by imf41.hostedemail.com (Postfix) with ESMTP for ; Fri, 18 Oct 2019 09:43:14 +0000 (UTC) Received: by mail-vk1-f202.google.com with SMTP id i20so2133487vkk.21 for ; Fri, 18 Oct 2019 02:43:14 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=aa2531C47nc0bhd/nSaGhlOEjDE53VfX74ef9UVFrtY=; b=PUkzffYNF+znLu26nrKIUVJjxanDVuTHRj6c72vX1huDV9jgfsCe5ie+uDzLoNg973 8VdjtnYkK67YsyaGy4rZ7XU4XcdL9231Js789ngUILqIk0T/D7qm/KTLysPcrgygcCPJ 702mwvlRTnbKYxgu88xv2TjtsmbJYEFHTl3AGunQkIzaY7BpY9xMSjMBB1Z2gTyHqj/5 qprdTtaCI77rzONBG63GVvdOGbIcZxHNQce+YD7Qi0kj6u8ckRxQWP1uASavSvmOZmit lWtRC32H4U3Eo+A1K3X/r/GYkAMSE9IqXPPcsJ10lDHw+R6sI2coyDi4qG88kUHHVEsw 2fXw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=aa2531C47nc0bhd/nSaGhlOEjDE53VfX74ef9UVFrtY=; b=a5me93GFh4kR4G7Wj5GLb9DzykdFE1mfb+9Qc1JZvqLEdg+8MHzyoIhvrQ28rgLgX6 UydeO5ezbHRez+/mmcYS5OjwcPjKjkXzSgx+nb7nUyqQFnaCkrpF3URIx22L8UKh0/kX AxO4LZZg/yJbk+2pqrGOeFkwDgCOMdFGaqlzNOIxUaAnOiQ/WlqVw5qkga/qmy8sfPJW fIbp7B0Guz1s1yOW8vHg3LeJswEUfSEIHwGMNjHhMMCnbH3f+kdGV9P0YP1PT9R2lsgf gaJGVoPdel8w5KBHHyqgrnoNReW7pq6S0mYbIC7E2SZBaQXEYb762EpeYpQVWEf77Brz FA2Q== X-Gm-Message-State: APjAAAUy+kOlSfH1X9qTmTiDKpbBTKQMJpY7sx0oYv00tmKwWVvtfKR9 VzqhKm1HxBgWkOIBJpm7VBJ4iDhu+hs= X-Google-Smtp-Source: APXvYqwD/oorD/xK2+l0n49DPBQ/ngOeV23keAz7qA5A6zYat4uAz4+kzttUp0NhmIhrlht8VZDiKgGQhg8= X-Received: by 2002:a1f:1ad6:: with SMTP id a205mr4769508vka.71.1571391793290; Fri, 18 Oct 2019 02:43:13 -0700 (PDT) Date: Fri, 18 Oct 2019 11:42:38 +0200 Message-Id: <20191018094304.37056-1-glider@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.23.0.866.gb869b98d4c-goog Subject: [PATCH RFC v1 00/26] Add KernelMemorySanitizer infrastructure From: glider@google.com To: Alexander Potapenko Cc: Alexander Viro , Andrew Morton , Andrey Ryabinin , Andy Lutomirski , Ard Biesheuvel , Arnd Bergmann , Christoph Hellwig , Dmitry Torokhov , Dmitry Vyukov , Eric Dumazet , Eric Van Hensbergen , Greg Kroah-Hartman , Harry Wentland , Herbert Xu , Ingo Molnar , Jens Axboe , "Martin K . Petersen" , Martin Schwidefsky , "Michael S. Tsirkin" , Michal Simek , Petr Mladek , Sergey Senozhatsky , Steven Rostedt , Takashi Iwai , "Theodore Ts'o" , Thomas Gleixner , Vegard Nossum , Wolfram Sang , Vasily Gorbik , Ilya Leoshkevich , Mark Rutland , linux-mm@kvack.org X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: KernelMemorySanitizer (KMSAN) is a detector of errors related to uses of uninitialized memory. It relies on compile-time Clang instrumentation (similar to MSan: https://clang.llvm.org/docs/MemorySanitizer.html) and tracks the state of every bit of kernel memory, being able to report an error if uninitialized value is used in a condition, dereferenced or copied to userspace, USB or network. KMSAN has reported more than 200 bugs in the past two years, most of them with the help of syzkaller (http://syzkaller.appspot.com). The proposed patchset contains KMSAN runtime implementation together with small changes to other subsystems needed to make KMSAN work. The latter changes fall into several categories: - nice-to-have features that are independent from KMSAN but simplify its implementation (stackdepot changes, CONFIG_GENERIC_CSUM etc.); - Kconfig changes that prohibit options incompatible with KMSAN; - calls to KMSAN runtime functions that help KMSAN do the bookkeeping (e.g. tell it to allocate, copy or delete the metadata); - calls to KMSAN runtime functions that tell KMSAN to check memory escaping the kernel for uninitialized values. These are required to increase the number of true positive error reports; - calls to runtime functions that tell KMSAN to ignore certain memory ranges to avoid false negative reports. Most certainly there can be better ways to deal with every such report. This patchset allows one to boot and run a defconfig+KMSAN kernel on a QEMU without known major false positives. It however doesn't guarantee there are no false positives in drivers of certain devices or less tested subsystems, although KMSAN is actively tested on syzbot with quite a rich config. One may find it handy to review these patches in Gerrit: https://linux-review.googlesource.com/c/linux/kernel/git/torvalds/linux/+/1081 I've ensured the Change-Id: tags stay away from commit descriptions. Note: checkpatch.pl complains a lot about the use of BUG_ON in KMSAN source. I don't have a strong opinion on this, but KMSAN is a debugging tool, so any runtime invariant violation in it renders the tool useless. Therefore it doesn't make much sense to not terminate after a bug in KMSAN. Alexander Potapenko (26): stackdepot: check depot_index before accessing the stack slab stackdepot: prevent Clang from optimizing away stackdepot_memcmp() kasan: stackdepot: move filter_irq_stacks() to stackdepot.c stackdepot: reserve 5 extra bits in depot_stack_handle_t printk_safe: externalize printk_context kasan: compiler.h: rename __no_kasan_or_inline into __no_memory_tool_or_inline kmsan: add ReST documentation kmsan: gfp: introduce __GFP_NO_KMSAN_SHADOW kmsan: introduce __no_sanitize_memory and __SANITIZE_MEMORY__ kmsan: reduce vmalloc space kmsan: add KMSAN runtime kmsan: x86: sync metadata pages on page fault kmsan: add tests for KMSAN kmsan: make READ_ONCE_TASK_STACK() return initialized values kmsan: Kconfig changes to disable options incompatible with KMSAN kmsan: Changing existing files to enable KMSAN builds kmsan: disable KMSAN instrumentation for certain kernel parts kmsan: mm: call KMSAN hooks from SLUB code kmsan: call KMSAN hooks where needed kmsan: disable instrumentation of certain functions kmsan: unpoison |tlb| in arch_tlb_gather_mmu() kmsan: use __msan_memcpy() where possible. kmsan: unpoisoning buffers from devices etc. kmsan: hooks for copy_to_user() and friends kmsan: disable strscpy() optimization under KMSAN net: kasan: kmsan: support CONFIG_GENERIC_CSUM on x86, enable it for KASAN/KMSAN To: Alexander Potapenko Cc: Alexander Viro Cc: Andrew Morton Cc: Andrey Ryabinin Cc: Andy Lutomirski Cc: Ard Biesheuvel Cc: Arnd Bergmann Cc: Christoph Hellwig Cc: Dmitry Torokhov Cc: Dmitry Vyukov Cc: Eric Dumazet Cc: Eric Van Hensbergen Cc: Greg Kroah-Hartman Cc: Harry Wentland Cc: Herbert Xu Cc: Ingo Molnar Cc: Jens Axboe Cc: Martin K. Petersen Cc: Martin Schwidefsky Cc: "Michael S. Tsirkin" Cc: Michal Simek Cc: Petr Mladek Cc: Sergey Senozhatsky Cc: Steven Rostedt Cc: Takashi Iwai Cc: "Theodore Ts'o" Cc: Thomas Gleixner Cc: Vegard Nossum Cc: Wolfram Sang Cc: Vasily Gorbik Cc: Ilya Leoshkevich Cc: Mark Rutland Cc: linux-mm@kvack.org Documentation/dev-tools/index.rst | 1 + Documentation/dev-tools/kmsan.rst | 418 +++++++++++++++++ Makefile | 3 +- arch/Kconfig | 2 +- arch/s390/include/asm/processor.h | 4 +- arch/x86/Kconfig | 7 + arch/x86/Kconfig.debug | 3 + arch/x86/boot/Makefile | 2 + arch/x86/boot/compressed/Makefile | 2 + arch/x86/boot/compressed/misc.h | 1 + arch/x86/entry/common.c | 1 + arch/x86/entry/entry_64.S | 18 + arch/x86/entry/vdso/Makefile | 3 + arch/x86/include/asm/checksum.h | 10 +- arch/x86/include/asm/irq_regs.h | 1 + arch/x86/include/asm/kmsan.h | 129 ++++++ arch/x86/include/asm/page_64.h | 13 + arch/x86/include/asm/page_64_types.h | 12 +- arch/x86/include/asm/pgtable_64_types.h | 15 + arch/x86/include/asm/string_64.h | 9 +- arch/x86/include/asm/syscall_wrapper.h | 1 + arch/x86/include/asm/uaccess.h | 12 + arch/x86/include/asm/unwind.h | 9 +- arch/x86/kernel/Makefile | 4 + arch/x86/kernel/apic/apic.c | 2 + arch/x86/kernel/cpu/Makefile | 1 + arch/x86/kernel/dumpstack_64.c | 1 + arch/x86/kernel/process_64.c | 5 + arch/x86/kernel/traps.c | 12 +- arch/x86/kernel/uprobes.c | 7 +- arch/x86/lib/Makefile | 2 + arch/x86/mm/Makefile | 2 + arch/x86/mm/fault.c | 20 + arch/x86/mm/ioremap.c | 3 + arch/x86/realmode/rm/Makefile | 2 + block/bio.c | 20 + block/blk.h | 7 + block/partition-generic.c | 9 +- crypto/Kconfig | 26 ++ drivers/char/random.c | 2 + drivers/firmware/efi/libstub/Makefile | 1 + drivers/gpu/drm/amd/display/Kconfig | 2 +- drivers/i2c/i2c-core-base.c | 2 + drivers/input/serio/libps2.c | 6 +- drivers/scsi/scsi_lib.c | 4 + drivers/usb/core/message.c | 6 +- drivers/usb/core/urb.c | 2 + drivers/virtio/virtio_ring.c | 14 + fs/buffer.c | 7 +- include/asm-generic/cacheflush.h | 7 +- include/asm-generic/uaccess.h | 12 +- include/linux/compiler-clang.h | 8 + include/linux/compiler-gcc.h | 5 + include/linux/compiler.h | 21 +- include/linux/dma-mapping.h | 2 + include/linux/gfp.h | 4 +- include/linux/highmem.h | 4 + include/linux/kmsan-checks.h | 123 +++++ include/linux/kmsan.h | 143 ++++++ include/linux/mm_types.h | 9 + include/linux/sched.h | 5 + include/linux/skbuff.h | 5 +- include/linux/stackdepot.h | 10 + include/linux/string.h | 2 + include/linux/uaccess.h | 32 +- init/main.c | 3 + kernel/Makefile | 1 + kernel/exit.c | 2 + kernel/fork.c | 2 + kernel/kthread.c | 2 + kernel/printk/printk.c | 8 +- kernel/printk/printk_safe.c | 2 +- kernel/profile.c | 1 + kernel/sched/core.c | 11 + kernel/softirq.c | 5 + lib/Kconfig.debug | 5 + lib/Kconfig.kmsan | 22 + lib/Makefile | 2 + lib/ioremap.c | 5 + lib/iov_iter.c | 6 + lib/stackdepot.c | 72 ++- lib/string.c | 5 +- lib/test_kmsan.c | 221 +++++++++ lib/usercopy.c | 6 +- mm/Makefile | 1 + mm/compaction.c | 9 + mm/filemap.c | 3 + mm/gup.c | 3 + mm/kasan/common.c | 23 - mm/kmsan/Makefile | 4 + mm/kmsan/kmsan.c | 570 ++++++++++++++++++++++++ mm/kmsan/kmsan.h | 147 ++++++ mm/kmsan/kmsan_entry.c | 130 ++++++ mm/kmsan/kmsan_hooks.c | 416 +++++++++++++++++ mm/kmsan/kmsan_init.c | 88 ++++ mm/kmsan/kmsan_instr.c | 259 +++++++++++ mm/kmsan/kmsan_report.c | 135 ++++++ mm/kmsan/kmsan_shadow.c | 543 ++++++++++++++++++++++ mm/kmsan/kmsan_shadow.h | 30 ++ mm/memory.c | 2 + mm/mmu_gather.c | 10 + mm/page_alloc.c | 16 + mm/readahead.c | 6 + mm/slub.c | 37 +- mm/vmalloc.c | 23 +- net/9p/protocol.c | 2 + net/sched/sch_generic.c | 2 + scripts/Makefile.kmsan | 12 + scripts/Makefile.lib | 6 + sound/core/oss/pcm_oss.c | 7 + 110 files changed, 4022 insertions(+), 80 deletions(-) create mode 100644 Documentation/dev-tools/kmsan.rst create mode 100644 arch/x86/include/asm/kmsan.h create mode 100644 include/linux/kmsan-checks.h create mode 100644 include/linux/kmsan.h create mode 100644 lib/Kconfig.kmsan create mode 100644 lib/test_kmsan.c create mode 100644 mm/kmsan/Makefile create mode 100644 mm/kmsan/kmsan.c create mode 100644 mm/kmsan/kmsan.h create mode 100644 mm/kmsan/kmsan_entry.c create mode 100644 mm/kmsan/kmsan_hooks.c create mode 100644 mm/kmsan/kmsan_init.c create mode 100644 mm/kmsan/kmsan_instr.c create mode 100644 mm/kmsan/kmsan_report.c create mode 100644 mm/kmsan/kmsan_shadow.c create mode 100644 mm/kmsan/kmsan_shadow.h create mode 100644 scripts/Makefile.kmsan