| Message ID | 20200117232254.2792-1-richardw.yang@linux.intel.com (mailing list archive) |
|---|---|
| Headers | show |
| Series | mm/mremap.c: cleanup move_page_tables() a little | expand |
On Sat, 18 Jan 2020 07:22:49 +0800 Wei Yang <richardw.yang@linux.intel.com> wrote: > move_page_tables() tries to move page table by PMD or PTE. > > The root reason is if it tries to move PMD, both old and new range should > be PMD aligned. But current code calculate old range and new range > separately. This leads to some redundant check and calculation. > > This cleanup tries to consolidate the range check in one place to reduce > some extra range handling. Thanks, I grabbed these, aimed at 5.7-rc1.
On Sat, Jan 18, 2020 at 04:07:02PM -0800, Andrew Morton wrote: >On Sat, 18 Jan 2020 07:22:49 +0800 Wei Yang <richardw.yang@linux.intel.com> wrote: > >> move_page_tables() tries to move page table by PMD or PTE. >> >> The root reason is if it tries to move PMD, both old and new range should >> be PMD aligned. But current code calculate old range and new range >> separately. This leads to some redundant check and calculation. >> >> This cleanup tries to consolidate the range check in one place to reduce >> some extra range handling. > >Thanks, I grabbed these, aimed at 5.7-rc1. Thanks :)
move_page_tables() tries to move page table by PMD or PTE. The root reason is if it tries to move PMD, both old and new range should be PMD aligned. But current code calculate old range and new range separately. This leads to some redundant check and calculation. This cleanup tries to consolidate the range check in one place to reduce some extra range handling. Wei Yang (5): mm/mremap: format the check in move_normal_pmd() same as move_huge_pmd() mm/mremap: it is sure to have enough space when extent meets requirement mm/mremap: use pmd_addr_end to calculate next in move_page_tables() mm/mremap: calculate extent in one place mm/mremap: start addresses are properly aligned include/linux/huge_mm.h | 2 +- mm/huge_memory.c | 8 +------- mm/mremap.c | 24 +++++++----------------- 3 files changed, 9 insertions(+), 25 deletions(-)