From patchwork Mon Jun 8 17:01:20 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Luis Chamberlain X-Patchwork-Id: 11593697 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 6042814E3 for ; Mon, 8 Jun 2020 17:01:33 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2E7B120814 for ; Mon, 8 Jun 2020 17:01:33 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 2E7B120814 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=kernel.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 5D9596B0005; Mon, 8 Jun 2020 13:01:32 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 5AFB86B0007; Mon, 8 Jun 2020 13:01:32 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4ED3D6B0008; Mon, 8 Jun 2020 13:01:32 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0165.hostedemail.com [216.40.44.165]) by kanga.kvack.org (Postfix) with ESMTP id 391386B0005 for ; Mon, 8 Jun 2020 13:01:32 -0400 (EDT) Received: from smtpin21.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id D985D185DDFCE for ; Mon, 8 Jun 2020 17:01:31 +0000 (UTC) X-FDA: 76906660782.21.ice29_1d12ce326dbb Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin21.hostedemail.com (Postfix) with ESMTP id 9D90F181D4B6E for ; Mon, 8 Jun 2020 17:01:31 +0000 (UTC) X-Spam-Summary: 2,0,0,7ec1e0a9f40e07a8,d41d8cd98f00b204,mcgrof@gmail.com,,RULES_HIT:41:355:379:541:965:966:967:973:988:989:1260:1311:1314:1345:1437:1515:1534:1541:1711:1730:1747:1777:1792:1981:2194:2196:2198:2199:2200:2201:2393:2525:2553:2559:2563:2682:2685:2859:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3353:3865:3866:3867:3868:3870:3871:3872:3873:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:4385:4390:4395:4470:4605:5007:6261:6671:7903:9025:9389:10004:11026:11657:11658:11914:12043:12048:12291:12296:12297:12517:12519:12555:12679:12683:12895:12986:13007:13069:13141:13161:13229:13230:13311:13357:13894:14093:14096:14181:14384:14394:14721:21080:21324:21433:21444:21451:21627:21740:30003:30054:30090,0,RBL:209.85.215.193:@gmail.com:.lbl8.mailshell.net-66.100.201.100 62.50.0.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:23,LUA_SUMMARY:none X-HE-Tag: ice29_1d12ce326dbb X-Filterd-Recvd-Size: 4488 Received: from mail-pg1-f193.google.com (mail-pg1-f193.google.com [209.85.215.193]) by imf12.hostedemail.com (Postfix) with ESMTP for ; Mon, 8 Jun 2020 17:01:31 +0000 (UTC) Received: by mail-pg1-f193.google.com with SMTP id t7so9038325pgt.3 for ; Mon, 08 Jun 2020 10:01:30 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=qUXzgbRX2wKZYMA8ok0uoS1JUpyLuZc0+BTfrQx3Bi8=; b=DwAamj5oCF2FHJ1BR9zDSH+Bc4pYoAkVeoPz7l23QBWAgCU3Im03tJwHx/f5zum+HL BrYVQxUszdbkXlzYgTBpWjEdrzMUF7KTocZ/WMVblNczUgHNgYB/VcCE2rgb+FOWu6dv +KxXn2drPSQ10JHqvagrqXVQQXggr1uaT6dFlv6lwTZJn69Y1t/P13jFak22lKFNeVbJ ZPTHaR57Nmo5e97cGG0tLRHasn/A54GWIG0ir4oDAi+OQlNB1J6pgH7O2GyeS+dfpane i+gLuemQZwF8MM4B7S7R+cMmr5t13dIPsme150NwnpPKGoqGWhWlO7CFQ1eDXYehljT6 reKA== X-Gm-Message-State: AOAM530o4RFzd0tp5swFb2jGzHA2mPDf+oq/MRKUtt6LtZpD2Wvk4gWU fPMBTRAR0g9ZL8VBCQtfQVw= X-Google-Smtp-Source: ABdhPJxAdCHgKvd/QmgBvDw7T4q6bq0lGS5DH72sx0NO830E9BqR93jPtM6XpNPD7SkanCzM5xJylA== X-Received: by 2002:a62:ee0b:: with SMTP id e11mr3788583pfi.185.1591635690050; Mon, 08 Jun 2020 10:01:30 -0700 (PDT) Received: from 42.do-not-panic.com (42.do-not-panic.com. [157.230.128.187]) by smtp.gmail.com with ESMTPSA id x77sm7839391pfc.4.2020.06.08.10.01.28 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 08 Jun 2020 10:01:28 -0700 (PDT) Received: by 42.do-not-panic.com (Postfix, from userid 1000) id DBD5D403AB; Mon, 8 Jun 2020 17:01:27 +0000 (UTC) From: Luis Chamberlain To: axboe@kernel.dk, viro@zeniv.linux.org.uk, bvanassche@acm.org, gregkh@linuxfoundation.org, rostedt@goodmis.org, mingo@redhat.com, jack@suse.cz, ming.lei@redhat.com, nstange@suse.de, akpm@linux-foundation.org Cc: mhocko@suse.com, yukuai3@huawei.com, martin.petersen@oracle.com, jejb@linux.ibm.com, linux-block@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-mm@kvack.org, linux-kernel@vger.kernel.org, Luis Chamberlain Subject: [PATCH v6 0/8] block: fix blktrace debugfs use after free Date: Mon, 8 Jun 2020 17:01:20 +0000 Message-Id: <20200608170127.20419-1-mcgrof@kernel.org> X-Mailer: git-send-email 2.23.0.rc1 MIME-Version: 1.0 X-Rspamd-Queue-Id: 9D90F181D4B6E X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam01 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Here is v6 of the blktrace fixes which address the debugfs use after free. I've followed the strategy suggested by Christoph of open coding the solution in place, and extended it with the required work for partitions and scsi-generic. Jan's blktrace sparse fix ended up depending on one of my patch, "blktrace: break out of blktrace setup on concurrent calls", and so he has sent those for inclusion prior to my series. This series would have to be applied after those two patches from Jan are merged then. Since the patch "blktrace: fix debugfs use after free" ends up being the only one modified lately, I've moved that patch to be the last one in the series now. You can find these on my git tree branch 20200608-blktrace-fixes based on linux-next 20200608 [0]. Hopefully this is it. [0] https://git.kernel.org/pub/scm/linux/kernel/git/mcgrof/linux-next.git/log/?h=20200608-blktrace-fixes Luis Chamberlain (6): block: add docs for gendisk / request_queue refcount helpers block: clarify context for refcount increment helpers block: revert back to synchronous request_queue removal blktrace: annotate required lock on do_blk_trace_setup() loop: be paranoid on exit and prevent new additions / removals blktrace: fix debugfs use after free block/blk-core.c | 27 ++++++++++-- block/blk-mq-debugfs.c | 5 --- block/blk-sysfs.c | 83 +++++++++++++++++++++++++++--------- block/blk.h | 2 - block/genhd.c | 73 ++++++++++++++++++++++++++++++- block/partitions/core.c | 3 ++ drivers/block/loop.c | 4 ++ drivers/scsi/sg.c | 3 ++ include/linux/blkdev.h | 6 +-- include/linux/blktrace_api.h | 1 - include/linux/genhd.h | 1 + kernel/trace/blktrace.c | 55 ++++++++++++++++++------ 12 files changed, 214 insertions(+), 49 deletions(-)