From patchwork Mon Sep 7 16:36:23 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Vlastimil Babka X-Patchwork-Id: 11761587 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id BECEA92C for ; Mon, 7 Sep 2020 16:36:46 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 6B36621D92 for ; Mon, 7 Sep 2020 16:36:46 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 6B36621D92 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=suse.cz Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 53D118E0005; Mon, 7 Sep 2020 12:36:45 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 4C4698E0001; Mon, 7 Sep 2020 12:36:45 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 364FF6B0062; Mon, 7 Sep 2020 12:36:45 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0215.hostedemail.com [216.40.44.215]) by kanga.kvack.org (Postfix) with ESMTP id 1626B6B0055 for ; Mon, 7 Sep 2020 12:36:45 -0400 (EDT) Received: from smtpin08.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id CF6ED180AD81A for ; Mon, 7 Sep 2020 16:36:44 +0000 (UTC) X-FDA: 77236819128.08.plot68_39046fb270cd Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin08.hostedemail.com (Postfix) with ESMTP id A2DAD1819E769 for ; Mon, 7 Sep 2020 16:36:44 +0000 (UTC) X-Spam-Summary: 1,0,0,,d41d8cd98f00b204,vbabka@suse.cz,,RULES_HIT:30054:30070,0,RBL:195.135.220.15:@suse.cz:.lbl8.mailshell.net-64.201.201.201 62.14.6.2;04yfx5n1zkddfpc1g3f8b6hgswu3oyc61q3h7uhmi5k4u93r4pazwni6cj7itt3.b9nm7np3sx9mdqb1qxszhn51p4xf9d3p5mocaf9nektiwe47zpxw4gqjk9tx1e6.n-lbl8.mailshell.net-223.238.255.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSBL:neutral,Custom_rules:0:0:0,LFtime:23,LUA_SUMMARY:none X-HE-Tag: plot68_39046fb270cd X-Filterd-Recvd-Size: 2208 Received: from mx2.suse.de (mx2.suse.de [195.135.220.15]) by imf23.hostedemail.com (Postfix) with ESMTP for ; Mon, 7 Sep 2020 16:36:44 +0000 (UTC) X-Virus-Scanned: by amavisd-new at test-mx.suse.de Received: from relay2.suse.de (unknown [195.135.221.27]) by mx2.suse.de (Postfix) with ESMTP id 2D76DB00E; Mon, 7 Sep 2020 16:36:43 +0000 (UTC) From: Vlastimil Babka To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, Michal Hocko , Pavel Tatashin , David Hildenbrand , Oscar Salvador , Joonsoo Kim , Vlastimil Babka Subject: [RFC 0/5] disable pcplists during page isolation Date: Mon, 7 Sep 2020 18:36:23 +0200 Message-Id: <20200907163628.26495-1-vbabka@suse.cz> X-Mailer: git-send-email 2.28.0 MIME-Version: 1.0 X-Rspamd-Queue-Id: A2DAD1819E769 X-Spamd-Result: default: False [0.00 / 100.00] X-Rspamd-Server: rspam05 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: As per the discussions [1] [2] this is an attempt to implement David's suggestion that page isolation should disable pcplists to avoid races. This is done without extra checks in fast paths, as I mentioned should be possible in the discussion, and explained in patch 5. Patches 1-4 are preparatory cleanups. Note this is untested RFC for now. Based on v5.9-rc4 plus Pavel's patch [2] (slated as a quick fix for mainline+stable). [1] https://lore.kernel.org/linux-mm/20200901124615.137200-1-pasha.tatashin@soleen.com/ [2] https://lore.kernel.org/linux-mm/20200903140032.380431-1-pasha.tatashin@soleen.com/ Vlastimil Babka (5): mm, page_alloc: clean up pageset high and batch update mm, page_alloc: calculate pageset high and batch once per zone mm, page_alloc(): remove setup_pageset() mm, page_alloc: cache pageset high and batch in struct zone mm, page_alloc: disable pcplists during page isolation include/linux/gfp.h | 1 + include/linux/mmzone.h | 2 + mm/internal.h | 4 ++ mm/memory_hotplug.c | 24 +++---- mm/page_alloc.c | 138 ++++++++++++++++++++++------------------- mm/page_isolation.c | 45 +++++++++++--- 6 files changed, 127 insertions(+), 87 deletions(-)