From patchwork Mon Oct 5 15:40:03 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 8bit X-Patchwork-Submitter: Kalesh Singh X-Patchwork-Id: 11816837 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9B7FC6CA for ; Mon, 5 Oct 2020 15:40:24 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5000E20B80 for ; Mon, 5 Oct 2020 15:40:24 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (2048-bit key) header.d=google.com header.i=@google.com header.b="ISCc2/Q+" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5000E20B80 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 6F883900002; Mon, 5 Oct 2020 11:40:23 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id 6CFB08E0001; Mon, 5 Oct 2020 11:40:23 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 59612900002; Mon, 5 Oct 2020 11:40:23 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0138.hostedemail.com [216.40.44.138]) by kanga.kvack.org (Postfix) with ESMTP id 2D3818E0001 for ; Mon, 5 Oct 2020 11:40:23 -0400 (EDT) Received: from smtpin04.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id B3C07180AD806 for ; Mon, 5 Oct 2020 15:40:22 +0000 (UTC) X-FDA: 77338283484.04.week46_03133d4271bf Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin04.hostedemail.com (Postfix) with ESMTP id 939B28007DCD for ; Mon, 5 Oct 2020 15:40:22 +0000 (UTC) X-Spam-Summary: 1,0,0,f07ef3125160ea70,d41d8cd98f00b204,3zd57xwskcm85v6zd2d381219916z.x97638fi-775gvx5.9c1@flex--kaleshsingh.bounces.google.com,,RULES_HIT:41:152:355:379:387:541:800:967:968:973:982:988:989:1260:1277:1311:1313:1314:1345:1437:1513:1515:1516:1518:1521:1535:1543:1593:1594:1711:1730:1747:1777:1792:1801:2194:2198:2199:2200:2393:2525:2559:2565:2570:2682:2685:2703:2859:2895:2933:2937:2939:2942:2945:2947:2951:2954:3022:3152:3355:3865:3866:3867:3868:3870:3871:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4118:4250:4321:4605:5007:6119:6261:6630:7875:7903:9010:9025:9121:9969:10004:10400:11658:13161:13229:30056,0,RBL:209.85.219.73:@flex--kaleshsingh.bounces.google.com:.lbl8.mailshell.net-66.100.201.100 62.18.0.100;04y8cf3ipqgkkddsiar9cbab6renjycpshww5bos64un8f9u5eznizzfaydyr4n.8qfj8p4d9hmwmni4xnyc6ji47b97q9qp37hgs3guqc9zz3cy7bffeufiuqehumq.4-lbl8.mailshell.net-223.238.255.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck:none,DomainCache:0,MSF:not bulk,SPF:fp,MSBL:0,DNSB L:neutra X-HE-Tag: week46_03133d4271bf X-Filterd-Recvd-Size: 7641 Received: from mail-qv1-f73.google.com (mail-qv1-f73.google.com [209.85.219.73]) by imf15.hostedemail.com (Postfix) with ESMTP for ; Mon, 5 Oct 2020 15:40:21 +0000 (UTC) Received: by mail-qv1-f73.google.com with SMTP id t7so6091783qvz.5 for ; Mon, 05 Oct 2020 08:40:21 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=sender:date:message-id:mime-version:subject:from:cc :content-transfer-encoding; bh=roRRmpnOQfqBgouvFdnsiNMWHoFG1to3sn9HMTXsuVQ=; b=ISCc2/Q+3RqQHnmu/kT5NtbJpNZ7wC8V64UlYxth0OYKIluZdxX7K1qgddenEuyZkZ Wc8U6+kyTzsPPNyB+D9cDFo3M4s3lBLOfMlJJxYiV4Ltu9WPKkx8LeCnf3CGMyu8pe24 QIGKxtMSedAWRhEGXxS0Czaq2oiy71ShEVY7Ny+oG2nkFMpoiSWHyoAzbffu/G8vt1qm eXe1gnFdmR2B0WLUvrfX5yF+c/CGo5F5OCtcPRN88pnNiyl4nNnJeDRa7KIyr/t/xLbn r+McOy57d3h71tj/brwaYwm0tHmetXO0th1kYsTBVqPc0WeiLDFOn5mbQ/vuX5IbqSp1 CFqw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:sender:date:message-id:mime-version:subject:from :cc:content-transfer-encoding; bh=roRRmpnOQfqBgouvFdnsiNMWHoFG1to3sn9HMTXsuVQ=; b=RJc3zhee8fPlfmt2cc4+w8sZnY35bkJK0BQ46NcaaqM9mbwyZITbsYNaocE7B7nQEn 6oyoJXzVAwQ2QCc5pI503bTXRvcapzWbUD/2yBvnk69mR1W9zcaOqoYSnWXFn4SzWhAq StAF01TF/hJdblTF+yZtInywMNlFjHH0hOY0YwIblJE6kbErFUWiLjHMhIpApC5L3CFs L6LOB3iZfp96NQFdrufzQztI1Tc5q3OjPzM7T5+OJM/YhDizND9pyC3yyTdOLSiIxTru zdWsrn1kUUGVzDjxPIijksW1Sk2O4YpiGhR0cPMkAUPPAESPAD6hf923pVFpa2bMpMGb VhlA== X-Gm-Message-State: AOAM532TU+f8pksm4Vh4LOmkz7yV5vkcqZg/wYf5h23r6mGfh3X/tHlU gpSYPZjqH8xZZvdDEWZVs+fxCRv0ZRUZu8i7Qg== X-Google-Smtp-Source: ABdhPJzWIPbd8bmYokW5hjiB2Kdv49nELig2YTyft80Zu/HTSnekvJDgjzVfD9yHuYp1YWGhjsp5xyZutg5nHRLLjw== X-Received: from kaleshsingh.c.googlers.com ([fda3:e722:ac3:10:14:4d90:c0a8:2145]) (user=kaleshsingh job=sendgmr) by 2002:ad4:58c7:: with SMTP id dh7mr278895qvb.20.1601912420924; Mon, 05 Oct 2020 08:40:20 -0700 (PDT) Date: Mon, 5 Oct 2020 15:40:03 +0000 Message-Id: <20201005154017.474722-1-kaleshsingh@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.28.0.806.g8561365e88-goog Subject: [PATCH v3 0/5] Speed up mremap on large regions From: Kalesh Singh Cc: surenb@google.com, minchan@google.com, joelaf@google.com, lokeshgidra@google.com, kaleshsingh@google.com, kernel-team@android.com, Catalin Marinas , Will Deacon , Thomas Gleixner , Ingo Molnar , Borislav Petkov , x86@kernel.org, "H. Peter Anvin" , Andrew Morton , Shuah Khan , "Aneesh Kumar K.V" , Kees Cook , Peter Zijlstra , Masahiro Yamada , Sami Tolvanen , Arnd Bergmann , Krzysztof Kozlowski , Frederic Weisbecker , Hassan Naveed , Christian Brauner , Mark Rutland , Mark Brown , Mike Rapoport , Gavin Shan , Jia He , Zhenyu Ye , John Hubbard , Sandipan Das , Thiago Jung Bauermann , "Kirill A. Shutemov" , Ram Pai , Ralph Campbell , Dave Hansen , Mina Almasry , Brian Geffon , Masami Hiramatsu , Jason Gunthorpe , SeongJae Park , linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-mm@kvack.org, linux-kselftest@vger.kernel.org X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This version 3 of the mremap speed up patches previously posted at: v1 - https://lore.kernel.org/r/20200930222130.4175584-1-kaleshsingh@google.com v2 - https://lore.kernel.org/r/20201002162101.665549-1-kaleshsingh@google.com mremap time can be optimized by moving entries at the PMD/PUD level if the source and destination addresses are PMD/PUD-aligned and PMD/PUD-sized. Enable moving at the PMD and PUD levels on arm64 and x86. Other architectures where this type of move is supported and known to be safe can also opt-in to these optimizations by enabling HAVE_MOVE_PMD and HAVE_MOVE_PUD. Observed Performance Improvements for remapping a PUD-aligned 1GB-sized region on x86 and arm64: - HAVE_MOVE_PMD is already enabled on x86 : N/A - Enabling HAVE_MOVE_PUD on x86 : ~13x speed up - Enabling HAVE_MOVE_PMD on arm64 : ~ 8x speed up - Enabling HAVE_MOVE_PUD on arm64 : ~19x speed up Altogether, HAVE_MOVE_PMD and HAVE_MOVE_PUD give a total of ~150x speed up on arm64. Changes in v2: - Reduce mremap_test time by only validating a configurable threshold of the remapped region, as per John. - Use a random pattern for mremap validation. Provide pattern seed in test output, as per John. - Moved set_pud_at() to separate patch, per Kirill. - Use switch() instead of ifs in move_pgt_entry(), per Kirill. - Update commit message with description of Android garbage collector use case for HAVE_MOVE_PUD, as per Joel. - Fix build test error reported by kernel test robot in [1]. Changes in v3: - Make lines 80 cols or less where they don’t need to be longer, per John. - Removed unused PATTERN_SIZE in mremap_test - Added Reviewed-by tag for patch 1/5 (mremap kselftest patch). - Use switch() instead of ifs in get_extent(), per Kirill - Add BUILD_BUG() is get_extent() default case. - Move get_old_pud() and alloc_new_pud() out of #ifdef CONFIG_HAVE_MOVE_PUD, per Kirill. - Have get_old_pmd() and alloc_new_pmd() use get_old_pud() and alloc_old_pud(), per Kirill. - Replace #ifdef CONFIG_HAVE_MOVE_PMD / PUD in move_page_tables() with IS_ENABLED(CONFIG_HAVE_MOVE_PMD / PUD), per Kirill. - Fold Add set_pud_at() patch into patch 4/5, per Kirill. [1] https://lists.01.org/hyperkitty/list/kbuild-all@lists.01.org/thread/CKPGL4FH4NG7TGH2CVYX2UX76L25BTA3/ Kalesh Singh (5): kselftests: vm: Add mremap tests arm64: mremap speedup - Enable HAVE_MOVE_PMD mm: Speedup mremap on 1GB or larger regions arm64: mremap speedup - Enable HAVE_MOVE_PUD x86: mremap speedup - Enable HAVE_MOVE_PUD arch/Kconfig | 7 + arch/arm64/Kconfig | 2 + arch/arm64/include/asm/pgtable.h | 1 + arch/x86/Kconfig | 1 + mm/mremap.c | 230 ++++++++++++--- tools/testing/selftests/vm/.gitignore | 1 + tools/testing/selftests/vm/Makefile | 1 + tools/testing/selftests/vm/mremap_test.c | 344 +++++++++++++++++++++++ tools/testing/selftests/vm/run_vmtests | 11 + 9 files changed, 558 insertions(+), 40 deletions(-) create mode 100644 tools/testing/selftests/vm/mremap_test.c base-commit: 549738f15da0e5a00275977623be199fbbf7df50