From patchwork Fri Oct 9 19:54:08 2020 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Kees Cook X-Patchwork-Id: 11828117 Return-Path: Received: from mail.kernel.org (pdx-korg-mail-1.web.codeaurora.org [172.30.200.123]) by pdx-korg-patchwork-2.web.codeaurora.org (Postfix) with ESMTP id 9A9381744 for ; Fri, 9 Oct 2020 19:54:44 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 56530225A9 for ; Fri, 9 Oct 2020 19:54:44 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=chromium.org header.i=@chromium.org header.b="WmBTqbBH" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 56530225A9 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=chromium.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C0F186B011D; Fri, 9 Oct 2020 15:54:19 -0400 (EDT) Delivered-To: linux-mm-outgoing@kvack.org Received: by kanga.kvack.org (Postfix, from userid 40) id B4BC46B011E; Fri, 9 Oct 2020 15:54:19 -0400 (EDT) X-Original-To: int-list-linux-mm@kvack.org X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A13876B0120; Fri, 9 Oct 2020 15:54:19 -0400 (EDT) X-Original-To: linux-mm@kvack.org X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0169.hostedemail.com [216.40.44.169]) by kanga.kvack.org (Postfix) with ESMTP id 66E866B011D for ; Fri, 9 Oct 2020 15:54:19 -0400 (EDT) Received: from smtpin09.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id 0DEF31EE6 for ; Fri, 9 Oct 2020 19:54:19 +0000 (UTC) X-FDA: 77353438638.09.pest55_4b0615d271e3 Received: from filter.hostedemail.com (10.5.16.251.rfc1918.com [10.5.16.251]) by smtpin09.hostedemail.com (Postfix) with ESMTP id D57CD180AD806 for ; Fri, 9 Oct 2020 19:54:18 +0000 (UTC) X-Spam-Summary: 1,0,0,5c87375fa3060a21,d41d8cd98f00b204,keescook@chromium.org,,RULES_HIT:41:69:355:379:541:800:965:966:967:973:988:989:1260:1311:1314:1345:1437:1515:1534:1539:1711:1714:1730:1747:1777:1792:2196:2199:2393:2525:2559:2563:2682:2685:2859:2898:2933:2937:2939:2942:2945:2947:2951:2954:3022:3138:3139:3140:3141:3142:3351:3865:3866:3867:3868:3870:3874:3934:3936:3938:3941:3944:3947:3950:3953:3956:3959:4321:4362:4385:4390:4395:4605:5007:6119:6261:6653:6742:7901:7903:8531:9025:9040:10004:11658:11914:12043:12297:12517:12519:12555:12683:12895:12986:13069:13132:13231:13311:13357:13846:13894:14095:14096:14181:14384:14394:14721:21080:21444:21451:21627:21740:21771:21811:21984:30054:30069:30070,0,RBL:209.85.214.195:@chromium.org:.lbl8.mailshell.net-66.201.201.201 62.14.0.100;04y89kjmcyyqruix7ufc5rc6yn1hqocwg93b6h1774wsctsg4u9bm33a5fhd88a.48ciwe9rfry8d1w5dcgjhqdbky7k4acui45zm3fk1qzoj4awjkpnipruar5bohk.y-lbl8.mailshell.net-223.238.255.100,CacheIP:none,Bayesian:0.5,0.5,0.5,Netcheck: none,Dom X-HE-Tag: pest55_4b0615d271e3 X-Filterd-Recvd-Size: 3718 Received: from mail-pl1-f195.google.com (mail-pl1-f195.google.com [209.85.214.195]) by imf07.hostedemail.com (Postfix) with ESMTP for ; Fri, 9 Oct 2020 19:54:18 +0000 (UTC) Received: by mail-pl1-f195.google.com with SMTP id m15so4953855pls.8 for ; Fri, 09 Oct 2020 12:54:18 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=chromium.org; s=google; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=t2TuK5ejrS4eO7yBYGxlh4AfvTTT9eubX9M0NFaNHUw=; b=WmBTqbBHc/fLbnYNSF9b2ZcYqm01OyvGBVCdOMlOlplf+K84OlLZT78WwFWOagQuLL tDy2L8MOtypox20wQcgMiCc7YNVSLgaLbl/v5wT3DFsEBCQ5+QAukKZ+evprA3Lh/MCc glirkHKlR1Dy+Nksiwkc5zH0AJjLGUHWF+KuQ= X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=t2TuK5ejrS4eO7yBYGxlh4AfvTTT9eubX9M0NFaNHUw=; b=WKVVWzbVwEtbS5zP2RMPKDdETiPp76uBuIZV0yT3k4mHNScqlGl4FZyzAz3t3HwLQN z38JhbVg8gGD9j+UG0i3p12mTveMxLYiyUdXE12dbuvdDMevRK7Gf9QYaqp9fj7W4l/j Ax49T6CquI12w0kYiMCvOxpgCqCNYF1Ib8sDPCPVB7UjDof2j12umHZNq1+nAjfHFVrN PC8RxEIuD+/GaSm3b9wPbVKxHPsbxdoJPKatFe102DotHLPvR0dWcQDKujoaziobmBvk i99UHX2r0tIPpz6U/ge+BhFQDxXpW2rzsp8RaPUHzYkj5d3UpZuHlBtpGPuFBF+DD9kk qIfA== X-Gm-Message-State: AOAM530uXcQws7BO0/tce4TJCM1i3SBvfghT+cmS6Yo6agqNmUjX9PBc 8uzKuzzcQAsjGjShjvYXFmn+0w== X-Google-Smtp-Source: ABdhPJylPL8PSKzfsb/31DQv1ffR9H5CiGwEbjOyZ1DOxnKQzkhmw2oI6Kjc3x/3NEhDPJExrT73pQ== X-Received: by 2002:a17:902:6545:b029:d3:d1fc:ff28 with SMTP id d5-20020a1709026545b02900d3d1fcff28mr13609528pln.34.1602273257514; Fri, 09 Oct 2020 12:54:17 -0700 (PDT) Received: from www.outflux.net (smtp.outflux.net. [198.145.64.163]) by smtp.gmail.com with ESMTPSA id b185sm11752903pgc.68.2020.10.09.12.54.16 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Fri, 09 Oct 2020 12:54:16 -0700 (PDT) From: Kees Cook To: Andrew Morton Cc: Kees Cook , Marco Elver , Jonathan Corbet , Christoph Lameter , Pekka Enberg , David Rientjes , Joonsoo Kim , Vlastimil Babka , Roman Gushchin , linux-kernel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org Subject: [PATCH v2 0/3] Actually fix freelist pointer vs redzoning Date: Fri, 9 Oct 2020 12:54:08 -0700 Message-Id: <20201009195411.4018141-1-keescook@chromium.org> X-Mailer: git-send-email 2.25.1 MIME-Version: 1.0 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: v2: - add additional clean-up patches - add Tested-by v1: https://lore.kernel.org/lkml/20201008233443.3335464-1-keescook@chromium.org This fixes redzoning vs the freelist pointer (both for middle-position and very small caches). Both are "theoretical" fixes, in that I see no evidence of such small-sized caches actually be used in the kernel, but that's no reason to let the bugs continue to exist. :) Thanks! -Kees Kees Cook (3): mm/slub: Clarify verification reporting mm/slub: Fix redzoning for small allocations mm/slub: Actually fix freelist pointer vs redzoning Documentation/vm/slub.rst | 10 +++++----- mm/slub.c | 36 +++++++++++++++--------------------- 2 files changed, 20 insertions(+), 26 deletions(-)