| Message ID | 20210214161348.369023-1-timur@kernel.org (mailing list archive) |
|---|---|
| Headers | show |
| Series | add support for never printing hashed addresses | expand |
On 2/14/21 10:13 AM, Timur Tabi wrote: > Although hashing addresses printed via printk does make the > kernel more secure, it interferes with debugging, especially > with some functions like print_hex_dump() which always uses > hashed addresses. I believe that this version addresses all outstanding issues, so unless there are any complaints, I would like for this patch set to be merged for 5.12-rc1. I don't know who should pick it up, though. Thanks.
On Sun 2021-02-14 10:18:39, Timur Tabi wrote: > On 2/14/21 10:13 AM, Timur Tabi wrote: > > Although hashing addresses printed via printk does make the > > kernel more secure, it interferes with debugging, especially > > with some functions like print_hex_dump() which always uses > > hashed addresses. > > I believe that this version addresses all outstanding issues, so unless > there are any complaints, I would like for this patch set to be merged for > 5.12-rc1. I don't know who should pick it up, though. I have pushed the patchset into printk/linux.git, branch for-5.12-no_hash_pointers. I am going to send the pull request on Thursday. Anyone still could comment and even stop it until them. I just wanted to give it at least few days in linux-next. Best Regards, Petr
Although hashing addresses printed via printk does make the kernel more secure, it interferes with debugging, especially with some functions like print_hex_dump() which always uses hashed addresses. To avoid having to choose between %p and %px, it's easier to add a kernel command line that treats all %p as %px. This encourages developers to use %p more without making debugging more difficult. Patches #1 and #2 upgrade the kselftest framework so that it can report on tests that were skipped outright. This is needed for the test_printf module which will now skip %p hashing tests if hashing is disabled. Patch #2 upgrades the printf library to check the command line. It also updates test_printf(). Timur Tabi (3): [v4] lib: use KSTM_MODULE_GLOBALS macro in kselftest drivers [v4] kselftest: add support for skipped tests [v4] lib/vsprintf: debug_never_hash_pointers prints all addresses as unhashed .../admin-guide/kernel-parameters.txt | 15 ++++++++ lib/test_bitmap.c | 3 +- lib/test_printf.c | 12 +++++- lib/vsprintf.c | 38 ++++++++++++++++++- tools/testing/selftests/kselftest_module.h | 18 ++++++--- 5 files changed, 74 insertions(+), 12 deletions(-)