mbox series

[0/5] Cleanup and fixup for khugepaged

Message ID 20210304123013.23560-1-linmiaohe@huawei.com (mailing list archive)
Headers show
Series Cleanup and fixup for khugepaged | expand

Message

Miaohe Lin March 4, 2021, 12:30 p.m. UTC
Hi all,
This series contains cleanups to remove unneeded return value, use
helper function and so on. And there is one fix to correct the wrong
result value for trace_mm_collapse_huge_page_isolate().

More details can be found in the respective changelogs. Thanks!

Miaohe Lin (5):
  khugepaged: remove unneeded return value of
    khugepaged_collapse_pte_mapped_thps()
  khugepaged: reuse the smp_wmb() inside __SetPageUptodate()
  khugepaged: use helper khugepaged_test_exit() in __khugepaged_enter()
  khugepaged: remove unnecessary mem_cgroup_uncharge() in
    collapse_[file|huge_page]
  khugepaged: fix wrong result value for
    trace_mm_collapse_huge_page_isolate()

 mm/khugepaged.c | 47 ++++++++++++++++++++---------------------------
 1 file changed, 20 insertions(+), 27 deletions(-)

Comments

Kirill A . Shutemov March 5, 2021, 5:40 p.m. UTC | #1
On Thu, Mar 04, 2021 at 07:30:08AM -0500, Miaohe Lin wrote:
> Hi all,
> This series contains cleanups to remove unneeded return value, use
> helper function and so on. And there is one fix to correct the wrong
> result value for trace_mm_collapse_huge_page_isolate().
> 
> More details can be found in the respective changelogs. Thanks!
> 
> Miaohe Lin (5):
>   khugepaged: remove unneeded return value of
>     khugepaged_collapse_pte_mapped_thps()
>   khugepaged: reuse the smp_wmb() inside __SetPageUptodate()
>   khugepaged: use helper khugepaged_test_exit() in __khugepaged_enter()
>   khugepaged: remove unnecessary mem_cgroup_uncharge() in
>     collapse_[file|huge_page]
>   khugepaged: fix wrong result value for
>     trace_mm_collapse_huge_page_isolate()
> 
>  mm/khugepaged.c | 47 ++++++++++++++++++++---------------------------
>  1 file changed, 20 insertions(+), 27 deletions(-)

Apart from patch 4/5, looks fine. For the rest, you can use:

Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>
Miaohe Lin March 6, 2021, 2:44 a.m. UTC | #2
On 2021/3/6 1:40, Kirill A. Shutemov wrote:
> On Thu, Mar 04, 2021 at 07:30:08AM -0500, Miaohe Lin wrote:
>> Hi all,
>> This series contains cleanups to remove unneeded return value, use
>> helper function and so on. And there is one fix to correct the wrong
>> result value for trace_mm_collapse_huge_page_isolate().
>>
>> More details can be found in the respective changelogs. Thanks!
>>
>> Miaohe Lin (5):
>>   khugepaged: remove unneeded return value of
>>     khugepaged_collapse_pte_mapped_thps()
>>   khugepaged: reuse the smp_wmb() inside __SetPageUptodate()
>>   khugepaged: use helper khugepaged_test_exit() in __khugepaged_enter()
>>   khugepaged: remove unnecessary mem_cgroup_uncharge() in
>>     collapse_[file|huge_page]
>>   khugepaged: fix wrong result value for
>>     trace_mm_collapse_huge_page_isolate()
>>
>>  mm/khugepaged.c | 47 ++++++++++++++++++++---------------------------
>>  1 file changed, 20 insertions(+), 27 deletions(-)
> 
> Apart from patch 4/5, looks fine. For the rest, you can use:
> 
> Acked-by: Kirill A. Shutemov <kirill.shutemov@linux.intel.com>

Many thanks for review and ack! :)

>