From patchwork Tue Mar 9 10:07:13 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Muchun Song X-Patchwork-Id: 12124585 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A06DC433DB for ; Tue, 9 Mar 2021 10:09:01 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id BF3696525D for ; Tue, 9 Mar 2021 10:09:00 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org BF3696525D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id 2B0358D00D5; Tue, 9 Mar 2021 05:09:00 -0500 (EST) Received: by kanga.kvack.org (Postfix, from userid 40) id 260C48D007F; Tue, 9 Mar 2021 05:09:00 -0500 (EST) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 129DF8D00D5; Tue, 9 Mar 2021 05:09:00 -0500 (EST) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0055.hostedemail.com [216.40.44.55]) by kanga.kvack.org (Postfix) with ESMTP id E97FC8D007F for ; Tue, 9 Mar 2021 05:08:59 -0500 (EST) Received: from smtpin10.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay02.hostedemail.com (Postfix) with ESMTP id 9EEE91DF6 for ; Tue, 9 Mar 2021 10:08:59 +0000 (UTC) X-FDA: 77899912398.10.1EDAC78 Received: from mail-pg1-f174.google.com (mail-pg1-f174.google.com [209.85.215.174]) by imf16.hostedemail.com (Postfix) with ESMTP id 59B808019141 for ; Tue, 9 Mar 2021 10:08:56 +0000 (UTC) Received: by mail-pg1-f174.google.com with SMTP id n10so8435830pgl.10 for ; Tue, 09 Mar 2021 02:08:56 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=rDStk8DgxtEE1GF5JjL7SE91exow+FT+q7nfT2+yXh8=; b=R3zKbYbxbsS0Suufmnc5FerkZosS+1IOgQpr2GSfCHVFVd2c+JH68wUlVC6XDH0JWv LxQ5sfNo58G6gsSU7ei7nXN5UPw9TJgL9TVhf1K2gJiLLiKA4orF0hgfI5NEGlf+aQdl rfnV7I9WBXowUKWor+jseIBxrkEfVcbSEr2Bs3Bd140HAOPXhIurZTPDdPAcEeDvkTbd X/aZfbI4DnwAykwRxuOCOZ2P0jqzQbe00uO5NsSIVJy5H5ExaauMNTfQkH8airPoJbBN m0GfL7VqW9y3qSFGVkPlRUP+f+PyB3wnB/PxLTlxdmedSXOMDq9ig3sCZhOp0tlR8q6e zNQw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=rDStk8DgxtEE1GF5JjL7SE91exow+FT+q7nfT2+yXh8=; b=jzMd/vLlPWmGGtQI0kgTsMDM0TJA/Fhq1vnisMjMiA0PEJoAaAetjhx2O765ZlepJe ggbFzvGAneYBwnNAZSAbCO5AlyOmmrG7CGjSIvwmpCk9hrxINS8NMZh7QLkzNM03lJ3I I9PraM3pGpQQqBWXMNId9f3ydqHyq5Tuz6c81rpQ80rlOFy60sATXpWVUFo4MlZXqXkk oXZ99ziGuK3p5n1IkjWh2erHFCU4ggq/jU2IWSjlxH+3G5BtX390MqAWNa52WqsK4jvU E5BTbTIadsOdHGjvLPkZN1crTeutpNSFIvSq62yFT1nbuqBMcHdAwEr0AhJHa1V0khk+ b3tA== X-Gm-Message-State: AOAM531KvGLKD6zlShWn9HHyXqfGGLSQEZLtL/0oIbnYTtqsyfZLTBHz bmcVDnLNWzy//6zBrZOQrEd4cw== X-Google-Smtp-Source: ABdhPJycIi2+Vn9ABatwajG+Dhilho0TN/FMMDjOnoziaYPiya9elHzBD+iWU3/AWPVr+pYv/+OyLA== X-Received: by 2002:a62:3c4:0:b029:1ee:9771:2621 with SMTP id 187-20020a6203c40000b02901ee97712621mr2874134pfd.47.1615284535384; Tue, 09 Mar 2021 02:08:55 -0800 (PST) Received: from localhost.localdomain ([139.177.225.255]) by smtp.gmail.com with ESMTPSA id a70sm9258424pfa.202.2021.03.09.02.08.50 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Tue, 09 Mar 2021 02:08:54 -0800 (PST) From: Muchun Song To: guro@fb.com, hannes@cmpxchg.org, mhocko@kernel.org, akpm@linux-foundation.org, shakeelb@google.com, vdavydov.dev@gmail.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, duanxiongchun@bytedance.com, Muchun Song Subject: [PATCH v3 0/4] Use obj_cgroup APIs to charge kmem pages Date: Tue, 9 Mar 2021 18:07:13 +0800 Message-Id: <20210309100717.253-1-songmuchun@bytedance.com> X-Mailer: git-send-email 2.21.0 (Apple Git-122) MIME-Version: 1.0 X-Rspamd-Server: rspam03 X-Rspamd-Queue-Id: 59B808019141 X-Stat-Signature: zjofy8718n8gm73cmdiune9cqthtsj89 Received-SPF: none (bytedance.com>: No applicable sender policy available) receiver=imf16; identity=mailfrom; envelope-from=""; helo=mail-pg1-f174.google.com; client-ip=209.85.215.174 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1615284536-463050 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Since Roman series "The new cgroup slab memory controller" applied. All slab objects are charged with the new APIs of obj_cgroup. The new APIs introduce a struct obj_cgroup to charge slab objects. It prevents long-living objects from pinning the original memory cgroup in the memory. But there are still some corner objects (e.g. allocations larger than order-1 page on SLUB) which are not charged with the new APIs. Those objects (include the pages which are allocated from buddy allocator directly) are charged as kmem pages which still hold a reference to the memory cgroup. E.g. We know that the kernel stack is charged as kmem pages because the size of the kernel stack can be greater than 2 pages (e.g. 16KB on x86_64 or arm64). If we create a thread (suppose the thread stack is charged to memory cgroup A) and then move it from memory cgroup A to memory cgroup B. Because the kernel stack of the thread hold a reference to the memory cgroup A. The thread can pin the memory cgroup A in the memory even if we remove the cgroup A. If we want to see this scenario by using the following script. We can see that the system has added 500 dying cgroups (This is not a real world issue, just a script to show that the large kmallocs are charged as kmem pages which can pin the memory cgroup in the memory). #!/bin/bash cat /proc/cgroups | grep memory cd /sys/fs/cgroup/memory echo 1 > memory.move_charge_at_immigrate for i in range{1..500} do mkdir kmem_test echo $$ > kmem_test/cgroup.procs sleep 3600 & echo $$ > cgroup.procs echo `cat kmem_test/cgroup.procs` > cgroup.procs rmdir kmem_test done cat /proc/cgroups | grep memory This patchset aims to make those kmem pages to drop the reference to memory cgroup by using the APIs of obj_cgroup. Finally, we can see that the number of the dying cgroups will not increase if we run the above test script. Changlogs in v3: 1. Drop "remote objcg charging APIs" patch. 2. Rename obj_cgroup_{un}charge_page to obj_cgroup_{un}charge_pages. 3. Make page_memcg/page_memcg_rcu safe for adding new memcg_data flags. 4. Reuse the ug infrastructure to uncharge the kmem pages. 5. Add a new patch to move PageMemcgKmem to the scope of CONFIG_MEMCG_KMEM. Thanks to Roman's review and suggestions. Changlogs in v2: 1. Fix some types in the commit log (Thanks Roman). 2. Do not introduce page_memcg_kmem helper (Thanks to Johannes and Shakeel). 3. Reduce the CC list to mm/memcg folks (Thanks to Johannes). 4. Introduce remote objcg charging APIs instead of convert "remote memcg charging APIs" to "remote objcg charging APIs". Muchun Song (4): mm: memcontrol: introduce obj_cgroup_{un}charge_pages mm: memcontrol: make page_memcg{_rcu} only applicable for non-kmem page mm: memcontrol: use obj_cgroup APIs to charge kmem pages mm: memcontrol: move PageMemcgKmem to the scope of CONFIG_MEMCG_KMEM include/linux/memcontrol.h | 103 ++++++++++++++++++++++++------ mm/memcontrol.c | 156 +++++++++++++++++++++++++++++++-------------- mm/page_alloc.c | 4 +- 3 files changed, 191 insertions(+), 72 deletions(-)