[0/5] userfaultfd/selftests: A few cleanups

Message

Peter Xu March 10, 2021, 12:45 a.m. UTC

Based on v5.12-rc2-mmots-2021-03-08-21-54.

I wanted to cleanup userfaultfd.c fault handling for a long time. If it's not
cleaned, when the new code grows the file it'll also grow the size that needs
to be cleaned...  This is my attempt to cleanup the userfaultfd selftest on
fault handling, to use an err() macro instead of either fprintf() or perror()
then another exit() call.

The huge cleanup is done in the last patch.  The first 4 patches are some other
standalone cleanups for the same file, so I put them together.

Please review, thanks.

Peter Xu (5):
  userfaultfd/selftests: Use user mode only
  userfaultfd/selftests: Remove the time() check on delayed uffd
  userfaultfd/selftests: Dropping VERIFY check in locking_thread
  userfaultfd/selftests: Only dump counts if mode enabled
  userfaultfd/selftests: Unify error handling

 tools/testing/selftests/vm/userfaultfd.c | 742 +++++++----------------
 1 file changed, 235 insertions(+), 507 deletions(-)

Comments

Axel Rasmussen March 10, 2021, 9:26 p.m. UTC | #1

These look like good cleanups to me! I reviewed all of the patches,
and tried out the resulting selftest program, it seems to work
correctly. So, for what it's worth:

Reviewed-by: Axel Rasmussen <[e-mail]>


On Tue, Mar 9, 2021 at 4:45 PM Peter Xu <[e-mail]> wrote:
>
> Based on v5.12-rc2-mmots-2021-03-08-21-54.
>
> I wanted to cleanup userfaultfd.c fault handling for a long time. If it's not
> cleaned, when the new code grows the file it'll also grow the size that needs
> to be cleaned...  This is my attempt to cleanup the userfaultfd selftest on
> fault handling, to use an err() macro instead of either fprintf() or perror()
> then another exit() call.
>
> The huge cleanup is done in the last patch.  The first 4 patches are some other
> standalone cleanups for the same file, so I put them together.
>
> Please review, thanks.
>
> Peter Xu (5):
>   userfaultfd/selftests: Use user mode only
>   userfaultfd/selftests: Remove the time() check on delayed uffd
>   userfaultfd/selftests: Dropping VERIFY check in locking_thread
>   userfaultfd/selftests: Only dump counts if mode enabled
>   userfaultfd/selftests: Unify error handling
>
>  tools/testing/selftests/vm/userfaultfd.c | 742 +++++++----------------
>  1 file changed, 235 insertions(+), 507 deletions(-)
>
> --
> 2.26.2
>
>