[v3,0/5] Cleanup and fixup for mm/migrate.c

Message

Miaohe Lin March 25, 2021, 1:15 p.m. UTC

Hi all,
This series contains cleanups to remove unnecessary VM_BUG_ON_PAGE and
rc != MIGRATEPAGE_SUCCESS check. Also use helper function to remove some
duplicated codes. What's more, this fixes potential deadlock in NUMA
balancing shared exec THP case and so on. More details can be found in
the respective changelogs. Thanks!

v2->v3:
Collect Reviewed-by tag
Revert commit c77c5cbafe54 ("mm: migrate: skip shared exec THP for NUMA
balancing") per Yang
Remove all 3 VM_BUG_ON_PAGE and make putback_movable_page static per Yang

v1->v2:
Fix removing the wrong assertion per Rafael.
Use pr_warn_once() instead per David.
Collect Reviewed-by tag.

Miaohe Lin (5):
  mm/migrate.c: make putback_movable_page() static
  mm/migrate.c: remove unnecessary rc != MIGRATEPAGE_SUCCESS check in
    'else' case
  mm/migrate.c: fix potential indeterminate pte entry in
    migrate_vma_insert_page()
  mm/migrate.c: use helper migrate_vma_collect_skip() in
    migrate_vma_collect_hole()
  Revert "mm: migrate: skip shared exec THP for NUMA balancing"

 include/linux/migrate.h |  1 -
 mm/migrate.c            | 62 +++++++++++++++--------------------------
 2 files changed, 22 insertions(+), 41 deletions(-)