From patchwork Wed Apr 21 07:00:47 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Muchun Song X-Patchwork-Id: 12215547 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C4DB7C433ED for ; Wed, 21 Apr 2021 07:01:21 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 4F0326141C for ; Wed, 21 Apr 2021 07:01:21 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 4F0326141C Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id D87D56B006E; Wed, 21 Apr 2021 03:01:20 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id D5D836B0070; Wed, 21 Apr 2021 03:01:20 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id BFE686B0071; Wed, 21 Apr 2021 03:01:20 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0110.hostedemail.com [216.40.44.110]) by kanga.kvack.org (Postfix) with ESMTP id A48C96B006E for ; Wed, 21 Apr 2021 03:01:20 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 64073180AE816 for ; Wed, 21 Apr 2021 07:01:20 +0000 (UTC) X-FDA: 78055477920.25.A945ED5 Received: from mail-pf1-f177.google.com (mail-pf1-f177.google.com [209.85.210.177]) by imf19.hostedemail.com (Postfix) with ESMTP id CAA389001175 for ; Wed, 21 Apr 2021 07:00:53 +0000 (UTC) Received: by mail-pf1-f177.google.com with SMTP id d124so27782179pfa.13 for ; Wed, 21 Apr 2021 00:01:16 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=pkSVS2YCjVQvqsgnImMuXupcbzBZpj2KtRtviCbjdFI=; b=fibkw8xQDhCYyY7TuSaQGDQfpVLcOo/wHEkWSbs7rC362g3qcRmkb6qA5cswEs9pzu UT0st8t5a4jzQOpQB3RwixyVhYqGGKXpZ5jr9eOnOj7Vwu8qQimiR735BH7ygzVZkdLX 7UOVZih2pSB+eFrFo0G8tMmQ3ezLZmmb+OQ2duPoz0mag8K9ViiJCHW2pBk18oTZiasp nEvlokm+qeZo9d809wQDQS5qxKICS84mq41sxmy3Yl60u6ySeQxCBUzqRk4pncHewOLZ 2laooZ7N299W4oEK4L3GURcpAIIXiiyDJVEMOMiPJLUY4gl+v1sR+eh9/ogjzpzazi1C YuJg== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=pkSVS2YCjVQvqsgnImMuXupcbzBZpj2KtRtviCbjdFI=; b=Z5BPVAIHui1e6My/hKbGIojjsjmZWRG8IuUTYkmOIEz5LJf45fu8jp4mRP0dxkrjQD C9I+5YR0dzezDKzlW44cDVJtZCGxldFbbEld4vdWxgFm+6OT9hC+XbkFYdvrFkJapNRC INMqddk/AqxUTOsPG5+0uZsQA8kWE1SmPqmg2c2cwEA4qfkUHaKH2vtL+1hPuD9ZnSUv vecF+jZeNFryYswlGlkuQfI7B8joYzc8lct37fA7elzsx0GLgzxtued+8jTN2GLye9gF BuwKl9oA0DQgTpIlVZByvvJ7tM1mQy9tZJtaTZkg/PaYD3Gm/APW2dFLREoWAPVcIxWf Vb/A== X-Gm-Message-State: AOAM533YXfGX8rLHZ6Frw1mm3+bN+glHUn9t3PDr/99uKs2MAErJxbGI mGF6+US+n/ZCyvwP0zWdP0iZ/Q== X-Google-Smtp-Source: ABdhPJxGDsvyIpyLQfQw6SW6VlR4eiF1JC+LcAxoZZaLSbZuuuay+GazHOtO2DyfuJIxRbE+49jVZg== X-Received: by 2002:a63:db47:: with SMTP id x7mr11537072pgi.360.1618988475453; Wed, 21 Apr 2021 00:01:15 -0700 (PDT) Received: from localhost.localdomain ([139.177.225.255]) by smtp.gmail.com with ESMTPSA id c4sm929842pfb.94.2021.04.21.00.01.08 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Wed, 21 Apr 2021 00:01:14 -0700 (PDT) From: Muchun Song To: guro@fb.com, hannes@cmpxchg.org, mhocko@kernel.org, akpm@linux-foundation.org, shakeelb@google.com, vdavydov.dev@gmail.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, duanxiongchun@bytedance.com, fam.zheng@bytedance.com, bsingharora@gmail.com, shy828301@gmail.com, alex.shi@linux.alibaba.com, Muchun Song Subject: [RFC PATCH v3 00/12] Use obj_cgroup APIs to charge the LRU pages Date: Wed, 21 Apr 2021 15:00:47 +0800 Message-Id: <20210421070059.69361-1-songmuchun@bytedance.com> X-Mailer: git-send-email 2.21.0 (Apple Git-122) MIME-Version: 1.0 X-Rspamd-Server: rspam01 X-Rspamd-Queue-Id: CAA389001175 X-Stat-Signature: 5iowgyho8hnp1zbf8e1tisxtgygxbbzs Received-SPF: none (bytedance.com>: No applicable sender policy available) receiver=imf19; identity=mailfrom; envelope-from=""; helo=mail-pf1-f177.google.com; client-ip=209.85.210.177 X-HE-DKIM-Result: pass/pass X-HE-Tag: 1618988453-334491 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: This is v3 based on the top of the series[1] (memcontrol code cleanup and simplification). Roman is working on the generalization of obj_cgroup API. But before that, hope someone can review this patches for correctness. Since the following patchsets applied. All the kernel memory are charged with the new APIs of obj_cgroup. [v17,00/19] The new cgroup slab memory controller[2] [v5,0/7] Use obj_cgroup APIs to charge kmem pages[3] But user memory allocations (LRU pages) pinning memcgs for a long time - it exists at a larger scale and is causing recurring problems in the real world: page cache doesn't get reclaimed for a long time, or is used by the second, third, fourth, ... instance of the same job that was restarted into a new cgroup every time. Unreclaimable dying cgroups pile up, waste memory, and make page reclaim very inefficient. We can convert LRU pages and most other raw memcg pins to the objcg direction to fix this problem, and then the LRU pages will not pin the memcgs. This patchset aims to make the LRU pages to drop the reference to memory cgroup by using the APIs of obj_cgroup. Finally, we can see that the number of the dying cgroups will not increase if we run the following test script. ```bash #!/bin/bash cat /proc/cgroups | grep memory cd /sys/fs/cgroup/memory for i in range{1..500} do mkdir test echo $$ > test/cgroup.procs sleep 60 & echo $$ > cgroup.procs echo `cat test/cgroup.procs` > cgroup.procs rmdir test done cat /proc/cgroups | grep memory ``` Thanks. [1] https://lore.kernel.org/linux-mm/20210417043538.9793-1-songmuchun@bytedance.com/ [2] https://lore.kernel.org/linux-mm/20200623015846.1141975-1-guro@fb.com/ [3] https://lore.kernel.org/linux-mm/20210319163821.20704-1-songmuchun@bytedance.com/ Changlogs in RFC v3: 1. Drop the code cleanup and simplification patches. Gather those patches into a separate series[1]. 2. Rework patch #1 suggested by Johannes. Changlogs in RFC v2: 1. Collect Acked-by tags by Johannes. Thanks. 2. Rework lruvec_holds_page_lru_lock() suggested by Johannes. Thanks. 3. Fix move_pages_to_lru(). Muchun Song (12): mm: memcontrol: move the objcg infrastructure out of CONFIG_MEMCG_KMEM mm: memcontrol: introduce compact_lock_page_lruvec_irqsave mm: memcontrol: make lruvec lock safe when the LRU pages reparented mm: vmscan: rework move_pages_to_lru() mm: thp: introduce lock/unlock_split_queue{_irqsave}() mm: thp: make deferred split queue lock safe when the LRU pages reparented mm: memcontrol: make all the callers of page_memcg() safe mm: memcontrol: introduce memcg_reparent_ops mm: memcontrol: use obj_cgroup APIs to charge the LRU pages mm: memcontrol: rename {un}lock_page_memcg() to {un}lock_page_objcg() mm: lru: add VM_BUG_ON_PAGE to lru maintenance function mm: lru: use lruvec lock to serialize memcg changes Documentation/admin-guide/cgroup-v1/memory.rst | 2 +- fs/buffer.c | 13 +- fs/fs-writeback.c | 23 +- fs/iomap/buffered-io.c | 4 +- include/linux/memcontrol.h | 182 ++++---- include/linux/mm_inline.h | 6 + mm/compaction.c | 36 +- mm/filemap.c | 2 +- mm/huge_memory.c | 171 ++++++-- mm/memcontrol.c | 562 ++++++++++++++++++------- mm/migrate.c | 4 + mm/page-writeback.c | 24 +- mm/page_io.c | 5 +- mm/rmap.c | 14 +- mm/swap.c | 46 +- mm/vmscan.c | 56 ++- 16 files changed, 795 insertions(+), 355 deletions(-)