From patchwork Thu May 27 09:33:24 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Muchun Song X-Patchwork-Id: 12283849 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB0EFC4707F for ; Thu, 27 May 2021 09:33:52 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 45409613E6 for ; Thu, 27 May 2021 09:33:52 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 45409613E6 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=bytedance.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id C42E16B0078; Thu, 27 May 2021 05:33:51 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id BCBFC6B007B; Thu, 27 May 2021 05:33:51 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id A1DA06B007D; Thu, 27 May 2021 05:33:51 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0070.hostedemail.com [216.40.44.70]) by kanga.kvack.org (Postfix) with ESMTP id 677E66B0078 for ; Thu, 27 May 2021 05:33:51 -0400 (EDT) Received: from smtpin25.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay04.hostedemail.com (Postfix) with ESMTP id EAEFA18C9 for ; Thu, 27 May 2021 09:33:50 +0000 (UTC) X-FDA: 78186499020.25.30882C6 Received: from mail-pf1-f180.google.com (mail-pf1-f180.google.com [209.85.210.180]) by imf09.hostedemail.com (Postfix) with ESMTP id 33943600025F for ; Thu, 27 May 2021 09:33:45 +0000 (UTC) Received: by mail-pf1-f180.google.com with SMTP id d78so121123pfd.10 for ; Thu, 27 May 2021 02:33:49 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=bytedance-com.20150623.gappssmtp.com; s=20150623; h=from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=sHbpGJMam8NU22tgKHYOQSyOi8RztO3bNwAJiFedN7s=; b=J9useeXoCsMYh/byHeKUeScxpn7jZk/NPMMEA0sz/ycNh3Uyj0rRjF4zu8/qmTrM+Z 1tRUMhxbhKvRZj0/eh/YdVp2Y38MQzVmDZaSM9ekauPU6xYcf6TwPkMV+k85K+CZegRe aumRgfXAwOSV3Szt928WbZYMS94RVCHFkmxe7KScejTBE+vseaQZ38EoYQ8DAKY/X1Kz 4u1/EKYnD6iH2P+O1Ru8wlf/JodqoQiqYQbC+SIMojOCcyd49SXMKzcPb6w1lK5l67/9 oDowrVSiFC6mriJnDlHZy67lug1wAKVL6aOsQ+PWMWC2N5CixBw4DSZgylAC116EnvYP ixVQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:from:to:cc:subject:date:message-id:mime-version :content-transfer-encoding; bh=sHbpGJMam8NU22tgKHYOQSyOi8RztO3bNwAJiFedN7s=; b=MqQcpU8W6J58gH+nTJFTHN65Ml6NkUQ6P6G9SHiwsUpMjlsoEC+775urCvoNCByWRL lGW/Ml354JRp1A50AGTGux3d8rvX2fEkx5+2+IqwNC9UmNr2ZSM2puEiOwxR/jYYf+Mb HdkiYWSl5IY9HxIpxbQYEcAWiFxWlM74rxP7LEPf+kCqS+/TvZ33hYGt50i0luPiuWGL 6tbkFMNzKqMIiK64//wNTL0k66Mbn/Jx5e9I1WIArzEUBVF6qKZM1NiWv2Hz1NbAQzaw kUkkZ2rnR4Mcp+S1J7W4kPyEQe+2VMO5Fotnvis8yV2lM+Lm5nXG7/kjdzb55pMPp5MS 97AQ== X-Gm-Message-State: AOAM5311EfnJfS30TdXv2ickaZrcrsl3Fb3cMRndULKXTiMkBfNNXd9d 40otZHnBre6rqs0S4nUAsHpOOQ== X-Google-Smtp-Source: ABdhPJzP4fvbHuX2LjTBCTdv3631Uj/6zhB8/172SGoP/ORjU9lB9mkSQkAcV+TyhRahrAgHd4oUTA== X-Received: by 2002:a05:6a00:234f:b029:2c4:b8d6:843 with SMTP id j15-20020a056a00234fb02902c4b8d60843mr2842745pfj.71.1622108028493; Thu, 27 May 2021 02:33:48 -0700 (PDT) Received: from localhost.bytedance.net ([139.177.225.254]) by smtp.gmail.com with ESMTPSA id a9sm1418917pfl.57.2021.05.27.02.33.42 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Thu, 27 May 2021 02:33:47 -0700 (PDT) From: Muchun Song To: guro@fb.com, hannes@cmpxchg.org, mhocko@kernel.org, akpm@linux-foundation.org, shakeelb@google.com, vdavydov.dev@gmail.com Cc: linux-kernel@vger.kernel.org, linux-mm@kvack.org, duanxiongchun@bytedance.com, fam.zheng@bytedance.com, bsingharora@gmail.com, shy828301@gmail.com, alexs@kernel.org, smuchun@gmail.com, zhengqi.arch@bytedance.com, Muchun Song Subject: [RFC PATCH v4 00/12] Use obj_cgroup APIs to charge the LRU pages Date: Thu, 27 May 2021 17:33:24 +0800 Message-Id: <20210527093336.14895-1-songmuchun@bytedance.com> X-Mailer: git-send-email 2.21.0 (Apple Git-122) MIME-Version: 1.0 X-Rspamd-Queue-Id: 33943600025F Authentication-Results: imf09.hostedemail.com; dkim=pass header.d=bytedance-com.20150623.gappssmtp.com header.s=20150623 header.b=J9useeXo; spf=pass (imf09.hostedemail.com: domain of songmuchun@bytedance.com designates 209.85.210.180 as permitted sender) smtp.mailfrom=songmuchun@bytedance.com; dmarc=pass (policy=none) header.from=bytedance.com X-Rspamd-Server: rspam04 X-Stat-Signature: p7aerghwyg4oor97kjy8xt18nife1sj4 X-HE-Tag: 1622108025-507030 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: Since the following patchsets applied. All the kernel memory are charged with the new APIs of obj_cgroup. [v17,00/19] The new cgroup slab memory controller[1] [v5,0/7] Use obj_cgroup APIs to charge kmem pages[2] But user memory allocations (LRU pages) pinning memcgs for a long time - it exists at a larger scale and is causing recurring problems in the real world: page cache doesn't get reclaimed for a long time, or is used by the second, third, fourth, ... instance of the same job that was restarted into a new cgroup every time. Unreclaimable dying cgroups pile up, waste memory, and make page reclaim very inefficient. We can convert LRU pages and most other raw memcg pins to the objcg direction to fix this problem, and then the LRU pages will not pin the memcgs. This patchset aims to make the LRU pages to drop the reference to memory cgroup by using the APIs of obj_cgroup. Finally, we can see that the number of the dying cgroups will not increase if we run the following test script. ```bash #!/bin/bash cat /proc/cgroups | grep memory cd /sys/fs/cgroup/memory for i in range{1..500} do mkdir test echo $$ > test/cgroup.procs sleep 60 & echo $$ > cgroup.procs echo `cat test/cgroup.procs` > cgroup.procs rmdir test done cat /proc/cgroups | grep memory ``` Thanks. [1] https://lore.kernel.org/linux-mm/20200623015846.1141975-1-guro@fb.com/ [2] https://lore.kernel.org/linux-mm/20210319163821.20704-1-songmuchun@bytedance.com/ Changlogs in RFC v4: 1. Collect Acked-by from Roman. 2. Rebase to linux next-20210525. 3. Rename obj_cgroup_release_uncharge() to obj_cgroup_release_kmem(). 4. Change the patch 1 title to "prepare objcg API for non-kmem usage". 5. Convert reparent_ops_head to an array in patch 8. Thanks for Roman's review and suggestions. Changlogs in RFC v3: 1. Drop the code cleanup and simplification patches. Gather those patches into a separate series[1]. 2. Rework patch #1 suggested by Johannes. Changlogs in RFC v2: 1. Collect Acked-by tags by Johannes. Thanks. 2. Rework lruvec_holds_page_lru_lock() suggested by Johannes. Thanks. 3. Fix move_pages_to_lru(). Muchun Song (12): mm: memcontrol: prepare objcg API for non-kmem usage mm: memcontrol: introduce compact_lock_page_irqsave mm: memcontrol: make lruvec lock safe when the LRU pages reparented mm: vmscan: rework move_pages_to_lru() mm: thp: introduce lock/unlock_split_queue{_irqsave}() mm: thp: make deferred split queue lock safe when the LRU pages reparented mm: memcontrol: make all the callers of page_memcg() safe mm: memcontrol: introduce memcg_reparent_ops mm: memcontrol: use obj_cgroup APIs to charge the LRU pages mm: memcontrol: rename {un}lock_page_memcg() to {un}lock_page_objcg() mm: lru: add VM_BUG_ON_PAGE to lru maintenance function mm: lru: use lruvec lock to serialize memcg changes Documentation/admin-guide/cgroup-v1/memory.rst | 2 +- fs/buffer.c | 13 +- fs/fs-writeback.c | 23 +- fs/iomap/buffered-io.c | 4 +- include/linux/memcontrol.h | 178 ++++---- include/linux/mm_inline.h | 6 + mm/compaction.c | 36 +- mm/filemap.c | 2 +- mm/huge_memory.c | 165 ++++++-- mm/memcontrol.c | 563 ++++++++++++++++++------- mm/migrate.c | 4 + mm/page-writeback.c | 24 +- mm/page_io.c | 5 +- mm/rmap.c | 14 +- mm/swap.c | 46 +- mm/vmscan.c | 56 ++- 16 files changed, 784 insertions(+), 357 deletions(-)