mbox series

[0/6] Cleanup and fixup for z3fold

Message ID 20210619093151.1492174-1-linmiaohe@huawei.com (mailing list archive)
Headers show
Series Cleanup and fixup for z3fold | expand

Message

Miaohe Lin June 19, 2021, 9:31 a.m. UTC
Hi all,
This series contains cleanups to remove unused function, redefine macro
to improve readability and so on. Also this fixes several bugs in z3fold,
such as memory leak in z3fold_destroy_pool(). More details can be found
in the respective changelogs. Thanks!

Miaohe Lin (6):
  mm/z3fold: define macro NCHUNKS as TOTAL_CHUNKS - ZHDR_CHUNKS
  mm/z3fold: avoid possible underflow in z3fold_alloc()
  mm/z3fold: remove magic number in z3fold_create_pool()
  mm/z3fold: remove unused function handle_to_z3fold_header()
  mm/z3fold: fix potential memory leak in z3fold_destroy_pool()
  mm/z3fold: use release_z3fold_page_locked() to release locked z3fold
    page

 mm/z3fold.c | 37 ++++++++++++++-----------------------
 1 file changed, 14 insertions(+), 23 deletions(-)

Comments

Vitaly Wool June 21, 2021, 8 a.m. UTC | #1
On Sat, Jun 19, 2021 at 11:32 AM Miaohe Lin <linmiaohe@huawei.com> wrote:

> Hi all,
> This series contains cleanups to remove unused function, redefine macro
> to improve readability and so on. Also this fixes several bugs in z3fold,
> such as memory leak in z3fold_destroy_pool(). More details can be found
> in the respective changelogs. Thanks!
>
> Miaohe Lin (6):
>   mm/z3fold: define macro NCHUNKS as TOTAL_CHUNKS - ZHDR_CHUNKS
>   mm/z3fold: avoid possible underflow in z3fold_alloc()
>   mm/z3fold: remove magic number in z3fold_create_pool()
>   mm/z3fold: remove unused function handle_to_z3fold_header()
>   mm/z3fold: fix potential memory leak in z3fold_destroy_pool()
>   mm/z3fold: use release_z3fold_page_locked() to release locked z3fold
>     page
>
>  mm/z3fold.c | 37 ++++++++++++++-----------------------
>  1 file changed, 14 insertions(+), 23 deletions(-)
>
> Thanks for looking into this!

Reviewed-by: Vitaly Wool <vitaly.wool@konsulko.com>