mbox series

[v3,0/3] kasan: add memory corruption identification support for hw tag-based kasan

Message ID 20210620114756.31304-1-Kuan-Ying.Lee@mediatek.com (mailing list archive)
Headers show
Series kasan: add memory corruption identification support for hw tag-based kasan | expand

Message

Kuan-Ying Lee (李冠穎) June 20, 2021, 11:47 a.m. UTC
Add memory corruption identification for hardware tag-based KASAN mode.

Changes since v3:
 - Preserve Copyright from hw_tags.c/sw_tags.c and
   report_sw_tags.c/report_hw_tags.c
 - Make non-trivial change in kasan sw tag-based mode

Changes since v2:
 - Thanks for Marco's Suggestion
 - Rename the CONFIG_KASAN_SW_TAGS_IDENTIFY
 - Integrate tag-based kasan common part
 - Rebase to latest linux-next

Kuan-Ying Lee (3):
  kasan: rename CONFIG_KASAN_SW_TAGS_IDENTIFY to
    CONFIG_KASAN_TAGS_IDENTIFY
  kasan: integrate the common part of two KASAN tag-based modes
  kasan: add memory corruption identification support for hardware
    tag-based mode

 lib/Kconfig.kasan         |  4 +--
 mm/kasan/Makefile         |  4 +--
 mm/kasan/hw_tags.c        | 22 ---------------
 mm/kasan/kasan.h          |  4 +--
 mm/kasan/report_hw_tags.c |  6 +---
 mm/kasan/report_sw_tags.c | 46 +-----------------------------
 mm/kasan/report_tags.h    | 55 ++++++++++++++++++++++++++++++++++++
 mm/kasan/sw_tags.c        | 41 ---------------------------
 mm/kasan/tags.c           | 59 +++++++++++++++++++++++++++++++++++++++
 9 files changed, 122 insertions(+), 119 deletions(-)
 create mode 100644 mm/kasan/report_tags.h
 create mode 100644 mm/kasan/tags.c

Comments

Marco Elver June 21, 2021, 12:45 p.m. UTC | #1
On Sun, 20 Jun 2021 at 13:48, Kuan-Ying Lee <Kuan-Ying.Lee@mediatek.com> wrote:
>
> Add memory corruption identification for hardware tag-based KASAN mode.
>
> Changes since v3:
>  - Preserve Copyright from hw_tags.c/sw_tags.c and
>    report_sw_tags.c/report_hw_tags.c
>  - Make non-trivial change in kasan sw tag-based mode
>
> Changes since v2:
>  - Thanks for Marco's Suggestion
>  - Rename the CONFIG_KASAN_SW_TAGS_IDENTIFY
>  - Integrate tag-based kasan common part
>  - Rebase to latest linux-next
>
> Kuan-Ying Lee (3):
>   kasan: rename CONFIG_KASAN_SW_TAGS_IDENTIFY to
>     CONFIG_KASAN_TAGS_IDENTIFY
>   kasan: integrate the common part of two KASAN tag-based modes
>   kasan: add memory corruption identification support for hardware
>     tag-based mode

I think this looks fine, thank you for your efforts. How did you test
this? Did you run the lib/test_kasan module with both SW_TAGS and
HW_TAGS mode? I was about to run that before adding my Reviewed-by.

Andrey, Alex, if you have time, please have a quick look at the series.

Thanks,
-- Marco
Kuan-Ying Lee (李冠穎) June 26, 2021, 10:13 a.m. UTC | #2
On Mon, 2021-06-21 at 14:45 +0200, Marco Elver wrote:
> On Sun, 20 Jun 2021 at 13:48, Kuan-Ying Lee <
> Kuan-Ying.Lee@mediatek.com> wrote:
> > 
> > Add memory corruption identification for hardware tag-based KASAN
> > mode.
> > 
> > Changes since v3:
> >  - Preserve Copyright from hw_tags.c/sw_tags.c and
> >    report_sw_tags.c/report_hw_tags.c
> >  - Make non-trivial change in kasan sw tag-based mode
> > 
> > Changes since v2:
> >  - Thanks for Marco's Suggestion
> >  - Rename the CONFIG_KASAN_SW_TAGS_IDENTIFY
> >  - Integrate tag-based kasan common part
> >  - Rebase to latest linux-next
> > 
> > Kuan-Ying Lee (3):
> >   kasan: rename CONFIG_KASAN_SW_TAGS_IDENTIFY to
> >     CONFIG_KASAN_TAGS_IDENTIFY
> >   kasan: integrate the common part of two KASAN tag-based modes
> >   kasan: add memory corruption identification support for hardware
> >     tag-based mode
> 
> I think this looks fine, thank you for your efforts. How did you test
> this? Did you run the lib/test_kasan module with both SW_TAGS and
> HW_TAGS mode? I was about to run that before adding my Reviewed-by.

Thanks for the reminder.
Yes, I run the lib/test_kasan module with SW_TAGS and HW_TAGS mode. :)

> 
> Andrey, Alex, if you have time, please have a quick look at the
> series.
> 
> Thanks,
> -- Marco