From patchwork Mon Jul 19 13:06:01 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Gavin Shan X-Patchwork-Id: 12385829 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.6 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id ADB86C07E9D for ; Mon, 19 Jul 2021 13:07:26 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 5B8266112D for ; Mon, 19 Jul 2021 13:07:26 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 5B8266112D Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=owner-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix) id EB7688D00F4; Mon, 19 Jul 2021 09:07:26 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id E40878D00EC; Mon, 19 Jul 2021 09:07:26 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id CE2CF8D00F4; Mon, 19 Jul 2021 09:07:26 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0026.hostedemail.com [216.40.44.26]) by kanga.kvack.org (Postfix) with ESMTP id A5ED68D00EC for ; Mon, 19 Jul 2021 09:07:26 -0400 (EDT) Received: from smtpin02.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id 4AA04183EC324 for ; Mon, 19 Jul 2021 13:07:25 +0000 (UTC) X-FDA: 78379363650.02.293BEF0 Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) by imf17.hostedemail.com (Postfix) with ESMTP id CA165F00038F for ; Mon, 19 Jul 2021 13:07:24 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1626700044; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding; bh=htLWUl9ptDYSCDmTTDEtd9WdgLa8oSPYzBBixivS3+w=; b=ha72pt2cPbXptHjEtMBMREor1SjZ43S/fL0rpte99MBetxblSNMhwsWL7euMrzpRBkbGsa MtrXMfwfmsq4QGhFBQZNcQe3+O7d9dNPrN+swMU7+gwxbWqftrmzjNXNWStwBsBeJ0BVRF 3VIx6nCkgHvAcRtBQhSygtGwXfVQCJw= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-565-gD8EUaYAPV-gS68Nz1JOXQ-1; Mon, 19 Jul 2021 09:07:21 -0400 X-MC-Unique: gD8EUaYAPV-gS68Nz1JOXQ-1 Received: from smtp.corp.redhat.com (int-mx05.intmail.prod.int.phx2.redhat.com [10.5.11.15]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 749BF362FF; Mon, 19 Jul 2021 13:07:19 +0000 (UTC) Received: from gshan.redhat.com (vpn2-54-195.bne.redhat.com [10.64.54.195]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 468DA5D6A1; Mon, 19 Jul 2021 13:07:14 +0000 (UTC) From: Gavin Shan To: linux-mm@kvack.org Cc: linux-kernel@vger.kernel.org, anshuman.khandual@arm.com, catalin.marinas@arm.com, will@kernel.org, akpm@linux-foundation.org, chuhu@redhat.com, shan.gavin@gmail.com Subject: [PATCH v3 00/12] mm/debug_vm_pgtable: Enhancements Date: Mon, 19 Jul 2021 21:06:01 +0800 Message-Id: <20210719130613.334901-1-gshan@redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.15 X-Rspamd-Server: rspam04 X-Rspamd-Queue-Id: CA165F00038F X-Stat-Signature: 37kxz1opyee9ihybnax4yxfxr8cao5cx Authentication-Results: imf17.hostedemail.com; dkim=pass header.d=redhat.com header.s=mimecast20190719 header.b=ha72pt2c; dmarc=pass (policy=none) header.from=redhat.com; spf=none (imf17.hostedemail.com: domain of gshan@redhat.com has no SPF policy when checking 216.205.24.124) smtp.mailfrom=gshan@redhat.com X-HE-Tag: 1626700044-33482 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: There are couple of issues with current implementations and this series tries to resolve the issues: (a) All needed information are scattered in variables, passed to various test functions. The code is organized in pretty much relaxed fashion. (b) The page isn't allocated from buddy during page table entry modifying tests. The page can be invalid, conflicting to the implementations of set_xxx_at() on ARM64. The target page is accessed so that the iCache can be flushed when execution permission is given on ARM64. Besides, the target page can be unmapped and access to it causes kernel crash. "struct pgtable_debug_args" is introduced to address issue (a). For issue (b), the used page is allocated from buddy in page table entry modifying tests. The corresponding tets will be skipped if we fail to allocate the (huge) page. For other test cases, the original page around to kernel symbol (@start_kernel) is still used. The patches are organized as below. PATCH[2-10] could be combined to one patch, but it will make the review harder: PATCH[1] introduces "struct pgtable_debug_args" as place holder of all needed information. With it, the old and new implementation can coexist. PATCH[2-10] uses "struct pgtable_debug_args" in various test functions. PATCH[11] removes the unused code for old implementation. PATCH[12] fixes the issue of corrupted page flag for ARM64 Changelog ========= v3: * Fix the warning caused by allocating more pages than (1 << (MAX_ORDER - 1)) in init_args() (syzbot) * Fix build warning by dropping unused variables in separate patches (0-day) * Missed "WARN_ON(!pud_none(pud))" in pud_huge_tests() in PATCH[v2 09/12] (0-day) * Fix the subjects for PATCH[05/12] and PATCH[09/12] (Gavin) v2: * Rename struct vm_pgtable_debug to struct pgtable_debug_args. The parameter name to various test functions are renamed to "@args" (Anshuman) * Code changes as suggested by Anshuman (Anshuman) Gavin Shan (12): mm/debug_vm_pgtable: Introduce struct pgtable_debug_args mm/debug_vm_pgtable: Use struct pgtable_debug_args in basic tests mm/debug_vm_pgtable: Use struct pgtable_debug_args in leaf and savewrite tests mm/debug_vm_pgtable: Use struct pgtable_debug_args in protnone and devmap tests mm/debug_vm_pgtable: Use struct pgtable_debug_args in soft_dirty and swap tests mm/debug_vm_pgtable: Use struct pgtable_debug_args in migration and thp tests mm/debug_vm_pgtable: Use struct pgtable_debug_args in PTE modifying tests mm/debug_vm_pgtable: Use struct pgtable_debug_args in PMD modifying tests mm/debug_vm_pgtable: Use struct pgtable_debug_args in PUD modifying tests mm/debug_vm_pgtable: Use struct pgtable_debug_args in PGD and P4D modifying tests mm/debug_vm_pgtable: Remove unused code mm/debug_vm_pgtable: Fix corrupted page flag mm/debug_vm_pgtable.c | 849 ++++++++++++++++++++++++------------------ 1 file changed, 480 insertions(+), 369 deletions(-)