From patchwork Fri Aug 27 19:18:55 2021 Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit X-Patchwork-Submitter: Suren Baghdasaryan X-Patchwork-Id: 12462813 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-21.3 required=3.0 tests=BAYES_00,DKIMWL_WL_MED, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,USER_AGENT_GIT, USER_IN_DEF_DKIM_WL autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 83124C432BE for ; Fri, 27 Aug 2021 19:19:08 +0000 (UTC) Received: from kanga.kvack.org (kanga.kvack.org [205.233.56.17]) by mail.kernel.org (Postfix) with ESMTP id 2CC1760FD9 for ; Fri, 27 Aug 2021 19:19:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 2CC1760FD9 Authentication-Results: mail.kernel.org; dmarc=fail (p=reject dis=none) header.from=google.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=kvack.org Received: by kanga.kvack.org (Postfix) id 61C018D0001; Fri, 27 Aug 2021 15:19:07 -0400 (EDT) Received: by kanga.kvack.org (Postfix, from userid 40) id 5A4766B0071; Fri, 27 Aug 2021 15:19:07 -0400 (EDT) X-Delivered-To: int-list-linux-mm@kvack.org Received: by kanga.kvack.org (Postfix, from userid 63042) id 4450A8D0001; Fri, 27 Aug 2021 15:19:07 -0400 (EDT) X-Delivered-To: linux-mm@kvack.org Received: from forelay.hostedemail.com (smtprelay0135.hostedemail.com [216.40.44.135]) by kanga.kvack.org (Postfix) with ESMTP id 249556B006C for ; Fri, 27 Aug 2021 15:19:07 -0400 (EDT) Received: from smtpin34.hostedemail.com (10.5.19.251.rfc1918.com [10.5.19.251]) by forelay01.hostedemail.com (Postfix) with ESMTP id C1449181CCB0D for ; Fri, 27 Aug 2021 19:19:06 +0000 (UTC) X-FDA: 78521823492.34.DFB967F Received: from mail-qv1-f74.google.com (mail-qv1-f74.google.com [209.85.219.74]) by imf15.hostedemail.com (Postfix) with ESMTP id 7E371D0000A2 for ; Fri, 27 Aug 2021 19:19:06 +0000 (UTC) Received: by mail-qv1-f74.google.com with SMTP id q2-20020ad45ca2000000b00374fa0dbedfso3717540qvh.1 for ; Fri, 27 Aug 2021 12:19:06 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20161025; h=date:message-id:mime-version:subject:from:to:cc; bh=RRkML5aaLpabtiv7lMTsCxfjkz2roCtfewQM+FW/noA=; b=sHNZLIBtukDKX17un4BpyKt9o/NbkOKdeGKhtEUC+VIhW+JR5IRHL/MeI5m4UiRgqZ 23gqGbl9Sb7h5tWJhUjmXAenuxo7to0hGDzQrIWaCF8ZzLqPlesKPZxXUDSeQxvUTGmc Y2q4AfRIF7k7FcPTgS069D4hyRgQrpknm3wcTyXWeNlENvMKkdvKWpiP4biyfRWVb59v B91dhUVE/mHPNPBjNK4ZRgRdi5t9QmrSgUOwyv/flhMGooimzka+r5zb/ibMZ1WhvfaB MXQaZMd3mgBtEhejxWPzQM+aR6bjI65i/DIQJhV7XR5fILiAOHJva5SMoP1jY3C5UH3J il3A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:date:message-id:mime-version:subject:from:to:cc; bh=RRkML5aaLpabtiv7lMTsCxfjkz2roCtfewQM+FW/noA=; b=L5z8WEGlTjy9HOihp3R+jox7GtMhjeyjz3Is4sUNb2zSuSIXIfR+WbRgVrf5VYBe0j Ot2Mpk3q3nN8bxO0KeDPWWWDpl5ECDpPohME/l5teNH8JB4nzuZfUPNw/PivcoOmUHp3 HGOg02i3abXToxGc2l61oSMfhDSkk8rCs97mhpiVZ18DoEytOUuKnzzUnc44tTMk8L3J OWRP9bs1EDgZ2k+wz1jo8Z7MjliU/De5IMRPMCCnmtiNaZ+EfKa2QfB88T8NCuA9XfhL 6zPVIN7KXQGPSVRSiNQ96J0MBSQc7JwDKbDb7g11ZYPvkQoyOR1MBQaEuVV4zx/VJ84/ 57iw== X-Gm-Message-State: AOAM5317L3NwXBzEbLKSgpb5Y6VA1mxVLjCQZWTKvE2VQyzTomzA5d1G iVoweyShdm3LZr7KiEReUK6g53wOSOE= X-Google-Smtp-Source: ABdhPJwlVMTSP3mPPLPB1FcLBEO5KECbnVlvJAx1zWj/a6b3fF2DC7neWZh9xHOrwjaAJJ+ycpZ/93uH+YM= X-Received: from surenb-desktop.mtv.corp.google.com ([2620:15c:211:200:fd8e:f32b:a64b:dd89]) (user=surenb job=sendgmr) by 2002:a05:6214:922:: with SMTP id dk2mr11208979qvb.36.1630091945639; Fri, 27 Aug 2021 12:19:05 -0700 (PDT) Date: Fri, 27 Aug 2021 12:18:55 -0700 Message-Id: <20210827191858.2037087-1-surenb@google.com> Mime-Version: 1.0 X-Mailer: git-send-email 2.33.0.259.gc128427fd7-goog Subject: [PATCH v8 0/3] Anonymous VMA naming patches From: Suren Baghdasaryan To: akpm@linux-foundation.org Cc: ccross@google.com, sumit.semwal@linaro.org, mhocko@suse.com, dave.hansen@intel.com, keescook@chromium.org, willy@infradead.org, kirill.shutemov@linux.intel.com, vbabka@suse.cz, hannes@cmpxchg.org, corbet@lwn.net, viro@zeniv.linux.org.uk, rdunlap@infradead.org, kaleshsingh@google.com, peterx@redhat.com, rppt@kernel.org, peterz@infradead.org, catalin.marinas@arm.com, vincenzo.frascino@arm.com, chinwen.chang@mediatek.com, axelrasmussen@google.com, aarcange@redhat.com, jannh@google.com, apopple@nvidia.com, jhubbard@nvidia.com, yuzhao@google.com, will@kernel.org, fenghua.yu@intel.com, thunder.leizhen@huawei.com, hughd@google.com, feng.tang@intel.com, jgg@ziepe.ca, guro@fb.com, tglx@linutronix.de, krisman@collabora.com, chris.hyser@oracle.com, pcc@google.com, ebiederm@xmission.com, axboe@kernel.dk, legion@kernel.org, eb@emlix.com, songmuchun@bytedance.com, viresh.kumar@linaro.org, thomascedeno@google.com, sashal@kernel.org, cxfcosmos@gmail.com, linux@rasmusvillemoes.dk, linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, linux-doc@vger.kernel.org, linux-mm@kvack.org, kernel-team@android.com, surenb@google.com Authentication-Results: imf15.hostedemail.com; dkim=pass header.d=google.com header.s=20161025 header.b=sHNZLIBt; spf=pass (imf15.hostedemail.com: domain of 3qTopYQYKCNIGIF2Bz4CC492.0CA96BIL-AA8Jy08.CF4@flex--surenb.bounces.google.com designates 209.85.219.74 as permitted sender) smtp.mailfrom=3qTopYQYKCNIGIF2Bz4CC492.0CA96BIL-AA8Jy08.CF4@flex--surenb.bounces.google.com; dmarc=pass (policy=reject) header.from=google.com X-Stat-Signature: hkh1eryk3ntusskedw9pysrnzp6zmrxi X-Rspamd-Queue-Id: 7E371D0000A2 X-Rspamd-Server: rspam04 X-HE-Tag: 1630091946-933341 X-Bogosity: Ham, tests=bogofilter, spamicity=0.000000, version=1.2.4 Sender: owner-linux-mm@kvack.org Precedence: bulk X-Loop: owner-majordomo@kvack.org List-ID: There were a number of previous attempts to upstream support for anonymous VMA naming. The original submission by Colin Cross [1] implemented a dictionary of refcounted names to reuse same name strings. Dave Hansen suggested [2] to use userspace pointers instead and the patch was rewritten that way. The last v7 version of this patch was posted by Sumit Semwal [3] and a very similar patch has been used in Android to name anonymous VMAs for a number of years. Concerns about this patch were raised by Kees Cook [4] noting the lack of string sanitization and the use of userspace pointers from the kernel. In conclusion [5], it was suggested to strndup_user the strings from userspace, perform appropriate checks and store a copy as a vm_area_struct member. Performance impact from additional strdup's during fork() should be measured by allocating a large number (64k) of VMAs with longest names and timing fork()s. This patchset implements the suggested approach in the first 2 patches and the 3rd patch implements simple refcounting to avoid strdup'ing the names during fork() and minimize the regression. Proposed test was conducted on an ARM64 Android device with CPU frequency locked at 2.4GHz, performance governor and Android system being stopped (adb shell stop) to minimize the noise. Test includes 3 different scenarios. In each scenario a process with 64K named anonymous VMAs forks children 1000 times while timing each fork and reporting the average time. The scenarios differ in the VMA content: 1. VMAs are not populated with any data (not realistic scenario but helps in emphasizing the regression). 2. Each VMA contains 1 page populated with random data. 3. Each VMA contains 10 pages populated with random data. With the first 2 patches implementing strdup approach, the average fork() times are: unnamed VMAs named VMAs REGRESSION Unpopulated VMAs 16.73ms 23.34ms 39.51% VMAs with 1 page of data 51.98ms 59.94ms 15.31% VMAs with 10 pages of data 66.86ms 76.31ms 14.13% From the perf results, the regression can be attributed to strlen() and strdup() calls. The regression shrinking with the increased amount of populated data can be attributed mostly to anon_vma_fork() and copy_page_range() consuming more time during fork(). After the refcounting implemented in the last patch of this series the results are: unnamed VMAs named VMAs REGRESSION Unpopulated VMAs 16.36ms 18.35ms 12.16%% VMAs with 1 page of data 48.16ms 51.30ms 6.52% VMAs with 10 pages of data 64.23ms 67.69ms 5.39% From the perf results, the regression can be attributed to refcount_inc_checked() (called from kref_get()). While there is obviously a measurable regression, 64K named anonymous VMAs is truly a worst case scenario. In the real usage, the only current user of this feature, namely Android, rarely has processes with the number of VMAs reaching 4000 (that's the highest I've measured). The regression of forking a process with that number of VMAs is at the noise level. 1. https://lore.kernel.org/linux-mm/1372901537-31033-1-git-send-email-ccross@android.com/ 2. https://lore.kernel.org/linux-mm/51DDFA02.9040707@intel.com/ 3. https://lore.kernel.org/linux-mm/20200901161459.11772-1-sumit.semwal@linaro.org/ 4. https://lore.kernel.org/linux-mm/202009031031.D32EF57ED@keescook/ 5. https://lore.kernel.org/linux-mm/5d0358ab-8c47-2f5f-8e43-23b89d6a8e95@intel.com/ Colin Cross (2): mm: rearrange madvise code to allow for reuse mm: add a field to store names for private anonymous memory Suren Baghdasaryan (1): mm: add anonymous vma name refcounting Documentation/filesystems/proc.rst | 2 + fs/proc/task_mmu.c | 14 +- fs/userfaultfd.c | 7 +- include/linux/mm.h | 13 +- include/linux/mm_types.h | 55 +++- include/uapi/linux/prctl.h | 3 + kernel/fork.c | 2 + kernel/sys.c | 48 ++++ mm/madvise.c | 447 +++++++++++++++++++---------- mm/mempolicy.c | 3 +- mm/mlock.c | 2 +- mm/mmap.c | 38 +-- mm/mprotect.c | 2 +- 13 files changed, 462 insertions(+), 174 deletions(-)