mbox series

[0/2] Use generic code for virtual address of randomization of x86

Message ID 20210921110252.2593542-1-sxwjean@me.com (mailing list archive)
Headers show
Series Use generic code for virtual address of randomization of x86 | expand

Message

Xiongwei Song Sept. 21, 2021, 11:02 a.m. UTC
From: Xiongwei Song <sxwjean@gmail.com>

Hello,

The two patches are to use generic code for randomization of virtual
address of x86. Since the basic code logic of x86 is same as generic
code, so no need to implement these functions on x86, please see the
details in comments of patch 2.

Please review it.

Cc: Thomas Gleixner <tglx@linutronix.de>
Cc: Ingo Molnar <mingo@redhat.com>
Cc: Borislav Petkov <bp@alien8.de>
Cc: "H. Peter Anvin" <hpa@zytor.com>
Cc: Andy Lutomirski <luto@kernel.org>
Cc: Gabriel Krisman Bertazi <krisman@collabora.com>
Cc: "Chang S. Bae" <chang.seok.bae@intel.com>
Cc: Al Viro <viro@zeniv.linux.org.uk>
Cc: Arvind Sankar <nivedita@alum.mit.edu>
Cc: Alexey Dobriyan <adobriyan@gmail.com>
Cc: Oleg Nesterov <oleg@redhat.com>
Cc: Balbir Singh <sblbir@amazon.com>
Cc: Jens Axboe <axboe@kernel.dk>
Cc: Lai Jiangshan <laijs@linux.alibaba.com>
Cc: Dave Hansen <dave.hansen@linux.intel.com>
Cc: Peter Zijlstra <peterz@infradead.org>
Cc: Andrew Morton <akpm@linux-foundation.org>
Cc: Arnd Bergmann <arnd@arndb.de>
Cc: "David S. Miller" <davem@davemloft.net>
Cc: Kees Cook <keescook@chromium.org>
Cc: Kim Phillips <kim.phillips@amd.com>
Cc: Yazen Ghannam <yazen.ghannam@amd.com>
Cc: Davidlohr Bueso <dave@stgolabs.net>
Cc: Stefan Metzmacher <metze@samba.org>
Cc: Marco Elver <elver@google.com>
Cc: "Eric W. Biederman" <ebiederm@xmission.com>
Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
Cc: linux-kernel@vger.kernel.org

Xiongwei Song (2):
  x86: Rename TIF_ADDR32 to TIF_32BIT
  x86/mm: Randomize va with generic arch_pick_mmap_layout()

 arch/x86/Kconfig                     |   2 +-
 arch/x86/include/asm/compat.h        |   7 +-
 arch/x86/include/asm/elf.h           |   2 +-
 arch/x86/include/asm/page_64_types.h |   6 +-
 arch/x86/include/asm/processor.h     |   4 +-
 arch/x86/include/asm/thread_info.h   |   4 +-
 arch/x86/kernel/process.c            |   5 --
 arch/x86/kernel/process_64.c         |   4 +-
 arch/x86/mm/mmap.c                   | 112 ---------------------------
 include/linux/compat.h               |   4 +
 mm/util.c                            |  18 ++++-
 11 files changed, 37 insertions(+), 131 deletions(-)

Comments

Kees Cook Sept. 21, 2021, 1:24 p.m. UTC | #1
On September 21, 2021 4:02:50 AM PDT, sxwjean@me.com wrote:
>From: Xiongwei Song <sxwjean@gmail.com>
>
>Hello,
>
>The two patches are to use generic code for randomization of virtual
>address of x86. Since the basic code logic of x86 is same as generic
>code, so no need to implement these functions on x86, please see the
>details in comments of patch 2.

Hi!

The other patches do not seem to have arrived; I only see 0/2.

-Kees

>
>Please review it.
>
>Cc: Thomas Gleixner <tglx@linutronix.de>
>Cc: Ingo Molnar <mingo@redhat.com>
>Cc: Borislav Petkov <bp@alien8.de>
>Cc: "H. Peter Anvin" <hpa@zytor.com>
>Cc: Andy Lutomirski <luto@kernel.org>
>Cc: Gabriel Krisman Bertazi <krisman@collabora.com>
>Cc: "Chang S. Bae" <chang.seok.bae@intel.com>
>Cc: Al Viro <viro@zeniv.linux.org.uk>
>Cc: Arvind Sankar <nivedita@alum.mit.edu>
>Cc: Alexey Dobriyan <adobriyan@gmail.com>
>Cc: Oleg Nesterov <oleg@redhat.com>
>Cc: Balbir Singh <sblbir@amazon.com>
>Cc: Jens Axboe <axboe@kernel.dk>
>Cc: Lai Jiangshan <laijs@linux.alibaba.com>
>Cc: Dave Hansen <dave.hansen@linux.intel.com>
>Cc: Peter Zijlstra <peterz@infradead.org>
>Cc: Andrew Morton <akpm@linux-foundation.org>
>Cc: Arnd Bergmann <arnd@arndb.de>
>Cc: "David S. Miller" <davem@davemloft.net>
>Cc: Kees Cook <keescook@chromium.org>
>Cc: Kim Phillips <kim.phillips@amd.com>
>Cc: Yazen Ghannam <yazen.ghannam@amd.com>
>Cc: Davidlohr Bueso <dave@stgolabs.net>
>Cc: Stefan Metzmacher <metze@samba.org>
>Cc: Marco Elver <elver@google.com>
>Cc: "Eric W. Biederman" <ebiederm@xmission.com>
>Cc: Christophe Leroy <christophe.leroy@csgroup.eu>
>Cc: linux-kernel@vger.kernel.org
>
>Xiongwei Song (2):
>  x86: Rename TIF_ADDR32 to TIF_32BIT
>  x86/mm: Randomize va with generic arch_pick_mmap_layout()
>
> arch/x86/Kconfig                     |   2 +-
> arch/x86/include/asm/compat.h        |   7 +-
> arch/x86/include/asm/elf.h           |   2 +-
> arch/x86/include/asm/page_64_types.h |   6 +-
> arch/x86/include/asm/processor.h     |   4 +-
> arch/x86/include/asm/thread_info.h   |   4 +-
> arch/x86/kernel/process.c            |   5 --
> arch/x86/kernel/process_64.c         |   4 +-
> arch/x86/mm/mmap.c                   | 112 ---------------------------
> include/linux/compat.h               |   4 +
> mm/util.c                            |  18 ++++-
> 11 files changed, 37 insertions(+), 131 deletions(-)
>
Xiongwei Song Sept. 21, 2021, 2:11 p.m. UTC | #2
> On Sep 21, 2021, at 9:24 PM, Kees Cook <keescook@chromium.org> wrote:
> 
> 
> 
> On September 21, 2021 4:02:50 AM PDT, sxwjean@me.com wrote:
>> From: Xiongwei Song <sxwjean@gmail.com>
>> 
>> Hello,
>> 
>> The two patches are to use generic code for randomization of virtual
>> address of x86. Since the basic code logic of x86 is same as generic
>> code, so no need to implement these functions on x86, please see the
>> details in comments of patch 2.
> 
> Hi!
> 
> The other patches do not seem to have arrived; I only see 0/2.

Sorry for that. Let me resend the patches.

Regards,
Xiongwei
Peter Zijlstra Sept. 21, 2021, 2:19 p.m. UTC | #3
On Tue, Sep 21, 2021 at 06:24:07AM -0700, Kees Cook wrote:
> 
> 
> On September 21, 2021 4:02:50 AM PDT, sxwjean@me.com wrote:
> >From: Xiongwei Song <sxwjean@gmail.com>
> >
> >Hello,
> >
> >The two patches are to use generic code for randomization of virtual
> >address of x86. Since the basic code logic of x86 is same as generic
> >code, so no need to implement these functions on x86, please see the
> >details in comments of patch 2.
> 
> Hi!
> 
> The other patches do not seem to have arrived; I only see 0/2.

They were only sent to the list for some weird raisin. Operator error
perhaps.